Skip to contentSkip to conversation

random: mix in cycle counter when jitter timer fires

PATCH New Jason A. Donenfeld 1 participant 1 message Nov 30, 2022 Random number driver

lore
Share & tools
lore

Jason A. Donenfeld

author maintainer
#0 lore raw

PATCH 1/1 random: mix in cycle counter when jitter timer fires

Rather than just relying on interaction between cache lines of the timer and the main loop, also explicitly take into account the fact that the timer might fire at some time that's hard to predict, due to scheduling, interrupts, or cross-CPU conditions. Mix in a cycle counter during the firing of the timer, in addition to the existing one during the scheduling of the timer. It can't hurt and can only help.

---
 drivers/char/random.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/char/random.c +2 -0
index 2494e08c76d8..69ea6cb14a86 100644
@@ -1250,7 +1250,9 @@ struct entropy_timer_state {
 static void __cold entropy_timer(struct timer_list *timer)
 {
 	struct entropy_timer_state *state = container_of(timer, struct entropy_timer_state, timer);
+	unsigned long entropy = random_get_entropy();
 
+	mix_pool_bytes(&entropy, sizeof(entropy));
 	if (atomic_inc_return(&state->samples) % state->samples_per_bit == 0)
 		credit_init_bits(1);
 }
Signature · 1 line
2.38.1