Skip to contentSkip to conversation

dm: remove redundant sz variable

PATCH NAK [email protected] 2 participants 2 messages Nov 30, 2022 Device mapper

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dm: remove redundant sz variable

From: zhang songyi <[email protected]>

Return value from hst_status() directly instead of taking this in another redundant variable.

---
 drivers/md/dm-ps-historical-service-time.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/md/dm-ps-historical-service-time.c +1 -2
index 1d82c95d323d..6c8e83ad2662 100644
@@ -237,7 +237,6 @@ static void hst_destroy(struct path_selector *ps)
 static int hst_status(struct path_selector *ps, struct dm_path *path,
                     status_type_t type, char *result, unsigned int maxlen)
 {
-       unsigned int sz = 0;
        struct path_info *pi;
 
        if (!path) {
@@ -261,7 +260,7 @@ static int hst_status(struct path_selector *ps, struct dm_path *path,
                }
        }
 
-       return sz;
+       return 0;
 }
 
 static int hst_add_path(struct path_selector *ps, struct dm_path *path,

--
2.15.2

#1 lore raw
Quoted 32 lines · On Wed, Nov 30 2022 at 2:35P -0500, [email protected]…

From: zhang songyi <[email protected]>

Return value from hst_status() directly instead of taking this in another redundant variable.

---
 drivers/md/dm-ps-historical-service-time.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/md/dm-ps-historical-service-time.c +1 -3
index 1d82c95d323d..6c8e83ad2662 100644
@@ -237,7 +237,6 @@ static void hst_destroy(struct path_selector *ps)
 static int hst_status(struct path_selector *ps, struct dm_path *path,
                     status_type_t type, char *result, unsigned int maxlen)
 {
-       unsigned int sz = 0;
        struct path_info *pi;
 
        if (!path) {
@@ -261,7 +260,7 @@ static int hst_status(struct path_selector *ps, struct dm_path *path,
                }
        }
 
-       return sz;
+       return 0;
 }
 
 static int hst_add_path(struct path_selector *ps, struct dm_path *path,
--
Quoted 2 lines

2.15.2

NACK

This sz variable is needed! (see DMEMIT)