Skip to contentSkip to conversation

net/mlx5: remove NULL check before dev_{put, hold}

PATCH Applied [email protected] 4 participants 5 messages Nov 30, 2022 – Dec 3, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mlx5: remove NULL check before dev_{put, hold}

From: zhang songyi <[email protected]>

The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}.

Fix the following coccicheck warning:
/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10:
WARNING:
WARNING NULL check before dev_{put, hold} functions is not needed.

---
 drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c +1 -2
index 32c3e0a649a7..6ab3a6b6dd8d 100644
@@ -1448,8 +1448,7 @@ struct net_device *mlx5_lag_get_roce_netdev(struct mlx5_core_dev *dev)
        } else {
                ndev = ldev->pf[MLX5_LAG_P1].netdev;
        }
-       if (ndev)
-               dev_hold(ndev);
+       dev_hold(ndev);
 
 unlock:
        spin_unlock_irqrestore(&lag_lock, flags);

--
2.25.1

#1 lore raw
Quoted 10 lines · On Wed, Nov 30, 2022 at 03:41:27PM +0800, [email protected] wrote:

From: zhang songyi <[email protected]>

The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}.

Fix the following coccicheck warning:
/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10:
WARNING:
WARNING NULL check before dev_{put, hold} functions is not needed.

Quoted 4 lines
---
 drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Please change all places in mlx5 in one patch.

You can find these with the following command
git grep -B 1 -E "dev_put|dev_hold" drivers/net/ethernet/mellanox/mlx5/

Thanks

Quoted 17 lines
drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c +1 -3
index 32c3e0a649a7..6ab3a6b6dd8d 100644
@@ -1448,8 +1448,7 @@ struct net_device *mlx5_lag_get_roce_netdev(struct mlx5_core_dev *dev)
        } else {
                ndev = ldev->pf[MLX5_LAG_P1].netdev;
        }
-       if (ndev)
-               dev_hold(ndev);
+       dev_hold(ndev);
 
 unlock:
        spin_unlock_irqrestore(&lag_lock, flags);
--

2.25.1

maintainer
#2 lore raw
Quoted 11 lines · On Wed, 30 Nov 2022 11:00:34 +0200 Leon Romanovsky wrote:
Quoted 10 lines · On Wed, Nov 30, 2022 at 03:41:27PM +0800, [email protected] wrote:

From: zhang songyi <[email protected]>

The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}.

Fix the following coccicheck warning:
/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10:
WARNING:
WARNING NULL check before dev_{put, hold} functions is not needed.

Quoted 6 lines
Quoted 4 lines
---
 drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)  

Please change all places in mlx5 in one patch.

Your call as a mlx5 maintainer, but I'd say don't change them at all. All these trivial patches are such a damn waste of time.

#3 lore raw
Quoted 12 lines · Jakub Kicinski
Quoted 11 lines · On Wed, 30 Nov 2022 11:00:34 +0200 Leon Romanovsky wrote:
Quoted 10 lines · On Wed, Nov 30, 2022 at 03:41:27PM +0800, [email protected] wrote:

From: zhang songyi <[email protected]>

The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}.

Fix the following coccicheck warning:
/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10:
WARNING:
WARNING NULL check before dev_{put, hold} functions is not needed.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
---
 drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)  

Please change all places in mlx5 in one patch.

Your call as a mlx5 maintainer, but I'd say don't change them at all.

I'm fine with one patch per-driver, I'm not fine with one patch per-line :).

Quoted 1 line

All these trivial patches are such a damn waste of time.

IMHO, it is valuable changes for actively developed code.

Thanks

#4 lore raw
In reply to Jakub Kicinski
Quoted 17 lines · Jakub Kicinski
Quoted 16 lines · On Wed, 30 Nov 2022 11:00:34 +0200 Leon Romanovsky wrote:
Quoted 14 lines · On Wed, Nov 30, 2022 at 03:41:27PM +0800, [email protected] wrote:

From: zhang songyi <[email protected]>

The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}.

Fix the following coccicheck warning:
/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:1450:2-10:
WARNING:
WARNING NULL check before dev_{put, hold} functions is not needed.

---
 drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Quoted 4 lines
Quoted 1 line

Please change all places in mlx5 in one patch.

Your call as a mlx5 maintainer, but I'd say don't change them at all. All these trivial patches are such a damn waste of time.

I agree, let's not waste more time on this, I will accept this patch as is since it's already marked awating-upstream..

Applied to net-next-mlx5