Skip to contentSkip to conversation

docs-admin-guide-mm-damon-usage-fix-wrong-usage-example-of-init_regions-file.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Dec 1, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: Docs/admin-guide/mm/damon/usage: fix wrong usage example of init_regions file
has been removed from the -mm tree. Its filename was
docs-admin-guide-mm-damon-usage-fix-wrong-usage-example-of-init_regions-file.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: SeongJae Park <[email protected]>
Subject: Docs/admin-guide/mm/damon/usage: fix wrong usage example of init_regions file
Date: Mon, 24 Oct 2022 17:46:19 +0000

DAMON debugfs interface assumes the users will write all inputs at once. However, redirecting a string of multiple lines sometimes end up writing line by line. Therefore, the example usage of 'init_regions' file, which writes input as a string of multiple lines can fail. Fix it to use a single line string instead. Also update the description of the usage to not assume users will write inputs in multiple lines.

---

 Documentation/admin-guide/mm/damon/usage.rst |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)
Documentation/admin-guide/mm/damon/usage.rst renamed from Documentation/admin-guide/mm/damon/usage.rst~docs-admin-guide-mm-damon-usage-fix-wrong-usage-example-of-init_regions-file +6 -5
@@ -468,8 +468,9 @@ regions in case of physical memory monit
 monitoring target regions by themselves.
 
 In such cases, users can explicitly set the initial monitoring target regions
-as they want, by writing proper values to the ``init_regions`` file.  Each line
-of the input should represent one region in below form.::
+as they want, by writing proper values to the ``init_regions`` file.  The input
+should be a sequence of three integers separated by white spaces that represent
+one region in below form.::
 
     <target idx> <start address> <end address>
 
@@ -484,9 +485,9 @@ ranges, ``20-40`` and ``50-100`` as that
     # cd <debugfs>/damon
     # cat target_ids
     42 4242
-    # echo "0   1       100
-            0   100     200
-            1   20      40
+    # echo "0   1       100 \
+            0   100     200 \
+            1   20      40  \
             1   50      100" > init_regions
 
 Note that this sets the initial monitoring target regions only.  In case of

_

Patches currently in -mm which might be from [email protected] are