media-videobuf-dma-sg-remove-foll_force-usage.patch removed from -mm tree
The quilt patch titled
Subject: media: videobuf-dma-sg: remove FOLL_FORCE usage
has been removed from the -mm tree. Its filename was
media-videobuf-dma-sg-remove-foll_force-usage.patch
This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: David Hildenbrand <[email protected]>
Subject: media: videobuf-dma-sg: remove FOLL_FORCE usage
Date: Wed, 16 Nov 2022 11:26:52 +0100
GUP now supports reliable R/O long-term pinning in COW mappings, such that we break COW early. MAP_SHARED VMAs only use the shared zeropage so far in one corner case (DAXFS file with holes), which can be ignored because GUP does not support long-term pinning in fsdax (see check_vma_flags()).
Consequently, FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM is no longer required for reliable R/O long-term pinning: FOLL_LONGTERM is sufficient. So stop using FOLL_FORCE, which is really only for ptrace access.
---
drivers/media/v4l2-core/videobuf-dma-sg.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-)
drivers/media/v4l2-core/videobuf-dma-sg.c renamed from drivers/media/v4l2-core/videobuf-dma-sg.c~media-videobuf-dma-sg-remove-foll_force-usage +5 -9
@@ -151,17 +151,16 @@ static void videobuf_dma_init(struct vidstatic int videobuf_dma_init_user_locked (struct videobuf_dmabuf *dma,int direction,unsigned long data,unsigned long size) { +unsigned int gup_flags =FOLL_LONGTERM ;unsigned long first, last; -int err, rw =0 ; -unsigned int flags =FOLL_FORCE ; +int err; dma->direction = direction;switch (dma->direction) {case DMA_FROM_DEVICE : - rw =READ ; + gup_flags |=FOLL_WRITE ;break ;case DMA_TO_DEVICE : - rw =WRITE ;break ;default :BUG ();
@@ -177,14 +176,11 @@ static int videobuf_dma_init_user_lockedif (NULL == dma->pages)return -ENOMEM ; -if (rw ==READ ) - flags |=FOLL_WRITE ; -dprintk (1 ,"init user [0x%lx+0x%lx => %lu pages]\n" , data, size, dma->nr_pages); - err =pin_user_pages (data &PAGE_MASK , dma->nr_pages, - flags |FOLL_LONGTERM , dma->pages,NULL ); + err =pin_user_pages (data &PAGE_MASK , dma->nr_pages, gup_flags, + dma->pages,NULL );if (err != dma->nr_pages) { dma->nr_pages = (err >=0 ) ? err :0 ;
_
Patches currently in -mm which might be from [email protected] are
selftests-vm-add-ksm-unmerge-tests.patch mm-pagewalk-dont-trigger-test_walk-in-walk_page_vma.patch selftests-vm-add-test-to-measure-madv_unmergeable-performance.patch mm-ksm-simplify-break_ksm-to-not-rely-on-vm_fault_write.patch mm-remove-vm_fault_write.patch mm-ksm-fix-ksm-cow-breaking-with-userfaultfd-wp-via-fault_flag_unshare.patch mm-pagewalk-add-walk_page_range_vma.patch mm-ksm-convert-break_ksm-to-use-walk_page_range_vma.patch mm-gup-remove-foll_migration.patch