Skip to contentSkip to conversation

rdma-hw-qib-qib_user_pages-remove-foll_force-usage.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Dec 1, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: RDMA/hw/qib/qib_user_pages: remove FOLL_FORCE usage
has been removed from the -mm tree. Its filename was
rdma-hw-qib-qib_user_pages-remove-foll_force-usage.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: David Hildenbrand <[email protected]>
Subject: RDMA/hw/qib/qib_user_pages: remove FOLL_FORCE usage
Date: Wed, 16 Nov 2022 11:26:57 +0100

FOLL_FORCE is really only for ptrace access. As we unpin the pinned pages using unpin_user_pages_dirty_lock(true), the assumption is that all these pages are writable.

FOLL_FORCE in this case seems to be a legacy leftover. Let's just remove it.

---

 drivers/infiniband/hw/qib/qib_user_pages.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/qib/qib_user_pages.c renamed from drivers/infiniband/hw/qib/qib_user_pages.c~rdma-hw-qib-qib_user_pages-remove-foll_force-usage +1 -1
@@ -110,7 +110,7 @@ int qib_get_user_pages(unsigned long sta
 	for (got = 0; got < num_pages; got += ret) {
 		ret = pin_user_pages(start_page + got * PAGE_SIZE,
 				     num_pages - got,
-				     FOLL_LONGTERM | FOLL_WRITE | FOLL_FORCE,
+				     FOLL_LONGTERM | FOLL_WRITE,
 				     p + got, NULL);
 		if (ret < 0) {
 			mmap_read_unlock(current->mm);

_

Patches currently in -mm which might be from [email protected] are

selftests-vm-add-ksm-unmerge-tests.patch mm-pagewalk-dont-trigger-test_walk-in-walk_page_vma.patch selftests-vm-add-test-to-measure-madv_unmergeable-performance.patch mm-ksm-simplify-break_ksm-to-not-rely-on-vm_fault_write.patch mm-remove-vm_fault_write.patch mm-ksm-fix-ksm-cow-breaking-with-userfaultfd-wp-via-fault_flag_unshare.patch mm-pagewalk-add-walk_page_range_vma.patch mm-ksm-convert-break_ksm-to-use-walk_page_range_vma.patch mm-gup-remove-foll_migration.patch