fixed some spelling mistakes
cover fixed some spelling mistakes
Fixed some spelling mistakes of countable nouns.
Zikui Zhao (1):
BUILDROOT: fixed some spelling mistakes
board/chromebook/elm/readme.txt | 2 +- board/chromebook/snow/readme.txt | 2 +- docs/manual/customize-directory-structure.txt | 4 ++-- docs/manual/writing-rules.txt | 4 ++-- support/kconfig/menu.c | 2 +- support/kconfig/streamline_config.pl | 2 +- support/kconfig/zconf.lex.c_shipped | 4 ++-- support/testing/tests/package/test_crudini.py | 2 +- 8 files changed, 11 insertions(+), 11 deletions(-)
Signature · 7 lines
2.17.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 1/1 BUILDROOT: fixed some spelling mistakes
Fixed some spelling mistakes of countable nouns.
Zikui Zhao <[email protected]>
--- board/chromebook/elm/readme.txt | 2 +- board/chromebook/snow/readme.txt | 2 +- docs/manual/customize-directory-structure.txt | 4 ++-- docs/manual/writing-rules.txt | 4 ++-- support/kconfig/menu.c | 2 +- support/kconfig/streamline_config.pl | 2 +- support/kconfig/zconf.lex.c_shipped | 4 ++-- support/testing/tests/package/test_crudini.py | 2 +- 8 files changed, 11 insertions(+), 11 deletions(-)
board/chromebook/elm/readme.txt +1 -1
@@ -30,7 +30,7 @@ The important files are: rootfs.tar bootsd.img (SD card image containing both kernel and rootfs) -Write the image directly to some SD card. +Write the image directly to some SD cards. WARNING: make sure there is nothing important on that card, and double-check the device name!
board/chromebook/snow/readme.txt +1 -1
@@ -30,7 +30,7 @@ The important files are: rootfs.tar bootsd.img (SD card image containing both kernel and rootfs) -Write the image directly to some SD card. +Write the image directly to some SD cards. WARNING: make sure there is nothing important on that card, and double-check the device name!
docs/manual/customize-directory-structure.txt +2 -2
@@ -27,10 +27,10 @@ to you. | +-- post_image.sh | +-- rootfs_overlay/ | | +-- etc/ -| | +-- <some file> +| | +-- <some files> | +-- patches/ | +-- foo/ -| | +-- <some patch> +| | +-- <some patches> | +-- libbar/ | +-- <some other patches> |
docs/manual/writing-rules.txt +2 -2
@@ -6,8 +6,8 @@ Overall, these coding style rules are here to help you to add new files in Buildroot or refactor existing ones. -If you slightly modify some existing file, the important thing is -to keep the consistency of the whole file, so you can: +If you slightly modify some existing files, the important thing is +to keep the consistency of the whole files, so you can: * either follow the potentially deprecated coding style used in this file,
support/kconfig/menu.c +1 -1
@@ -376,7 +376,7 @@ void menu_finalize(struct menu *parent)* * 2. The property belongs to a symbol * defined in multiple locations and -* is from some other location. It +* is from some other locations. It * will be handled there in that * case. *
support/kconfig/streamline_config.pl +1 -1
@@ -24,7 +24,7 @@ # 3. Copy the configuraton file to this directory as .config # 4. Have all your devices that you need modules for connected and # operational (make sure that their corresponding modules are loaded) -# 5. Run this script redirecting the output to some other file +# 5. Run this script redirecting the output to some other files # like config_strip. # 6. Back up your old config (if you want too). # 7. copy the config_strip file to .config
support/kconfig/zconf.lex.c_shipped +2 -2
@@ -247,7 +247,7 @@ struct yy_buffer_state #define YY_BUFFER_NEW 0 #define YY_BUFFER_NORMAL 1 - /* When an EOF's been seen but there's still some text to process + /* When an EOF's been seen but there's still some texts to process * then we mark the buffer as YY_EOF_PENDING, to indicate that we * shouldn't try reading from the input source any more. We might * still have a bunch of tokens to match, though, because of
@@ -1549,7 +1549,7 @@ static int yy_get_next_buffer (void) else { - /* We matched some text prior to the EOB, first + /* We matched some texts prior to the EOB, first * process it. */ return EOB_ACT_LAST_MATCH;
support/testing/tests/package/test_crudini.py +1 -1
@@ -22,7 +22,7 @@ class TestCrudiniBase(TestPythonPackageBase): self.emulator.login() - # 1. Create some sample .ini file + # 1. Create some sample .ini files cmd = "echo -e '%s' > config.ini" % INI_FILE_CONTENT _, ret = self.emulator.run(cmd) self.assertEqual(ret, 0)
Signature · 7 lines
2.17.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 1/1] BUILDROOT: fixed some spelling mistakes
Zhao, All,
On 2022-12-01 08:44 +0800, Zikui Zhao spake thusly:
Quoted 4 lines
Fixed some spelling mistakes of countable nouns.
Zikui Zhao <[email protected]>
---
[--SNIP--]
board/chromebook/elm/readme.txt The important files are: · line 33
Quoted 10 lines
board/chromebook/elm/readme.txt +1
-1@@ -30,7 +30,7 @@ The important files are: rootfs.tar bootsd.img (SD card image containing both kernel and rootfs) -Write the image directly to some SD card. +Write the image directly to some SD cards.
No. 'some' does not refer to a plural, but to an arbitrary item left to the choice of the user. See first sense in:
https://www.merriam-webster.com/dictionary/some
Besides, it does not make sense to write the resulting image to more than one SD card to boot a single board, which the readme is about.
board/chromebook/snow/readme.txt The important files are: · line 33
Quoted 13 lines
board/chromebook/elm/readme.txt +0
-0WARNING: make sure there is nothing important on that card, and double-check the device name!board/chromebook/snow/readme.txt +1
-1@@ -30,7 +30,7 @@ The important files are: rootfs.tar bootsd.img (SD card image containing both kernel and rootfs) -Write the image directly to some SD card. +Write the image directly to some SD cards.
Ditto
Quoted 8 lines
board/chromebook/snow/readme.txt +0
-0WARNING: make sure there is nothing important on that card, and double-check the device name!docs/manual/customize-directory-structure.txt +0
-0
docs/manual/customize-directory-structure.txt to you. · line 33
Quoted 9 lines
docs/manual/customize-directory-structure.txt +2
-2@@ -27,10 +27,10 @@ to you. | +-- post_image.sh | +-- rootfs_overlay/ | | +-- etc/ -| | +-- <some file> +| | +-- <some files> | +-- patches/ | +-- foo/ -| | +-- <some patch> +| | +-- <some patches>
Those two are acceptable.
Quoted 8 lines
docs/manual/customize-directory-structure.txt +0
-0| +-- libbar/ | +-- <some other patches> |docs/manual/writing-rules.txt +0
-0
docs/manual/writing-rules.txt line 10
Quoted 7 lines
docs/manual/writing-rules.txt +2
-2@@ -6,8 +6,8 @@ Overall, these coding style rules are here to help you to add new files in Buildroot or refactor existing ones. -If you slightly modify some existing file, the important thing is -to keep the consistency of the whole file, so you can: +If you slightly modify some existing files, the important thing is +to keep the consistency of the whole files, so you can:
Again, nope. For 'some', the reason is the same as above: it is not a plural, but an indetermined unit.
For 'whole', we still refer to the "existing file" mentioned just before, and what this sentence means is that, when modifying an existing file in Buildroot, we want the code style of that file to be consistent, hence the "whole file", i.e. "whole" means "entire".
See sense 3.a in:
https://www.merriam-webster.com/dictionary/whole
The following fixes to "some" are also incorrect:
support/kconfig/menu.c | 2 +-
support/kconfig/streamline_config.pl | 2 +-
support/kconfig/zconf.lex.c_shipped | 4 ++--The first three (kconfig) are from the kernel, so we just copied them as-is; any fixes should be pushed to the kernel instead (but those "some" fixes are incorrect).
support/testing/tests/package/test_crudini.py class TestCrudiniBase(TestPythonPackageBase): · line 25
Quoted 10 lines
support/testing/tests/package/test_crudini.py +1
-1@@ -22,7 +22,7 @@ class TestCrudiniBase(TestPythonPackageBase): self.emulator.login() - # 1. Create some sample .ini file + # 1. Create some sample .ini files
This one, like the others above, is incorrect. Furthermore, it is obvious in contect that we are indeed creating only one .ini file:
support/testing/tests/package/test_crudini.py class TestCrudiniBase(TestPythonPackageBase): · line 26
Quoted 1 line
support/testing/tests/package/test_crudini.py +0
-0cmd = "echo -e '%s' > config.ini" % INI_FILE_CONTENT
... here, this only creates a single .ini file.
Can you re-send a patch with only the two correct fixes, please?
Regards,
Yann E. MORIN.
Quoted 2 lines
support/testing/tests/package/test_crudini.py +0
-0_, ret = self.emulator.run(cmd) self.assertEqual(ret, 0)
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot