Skip to contentSkip to conversation

dco: disable dco on Windows if --remote is not defined

PATCH In review Lev Stipakov 2 participants 2 messages Dec 1, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dco: disable dco on Windows if --remote is not defined

From: Lev Stipakov <[email protected]...>

At the moment Windows driver requires remote to work.

---
 src/openvpn/dco.c | 8 ++++++++
 1 file changed, 8 insertions(+)
src/openvpn/dco.c +8 -0
index 47fb0003..19a449ba 100644
@@ -251,6 +251,14 @@ dco_check_option_ce(const struct connection_entry *ce, int msglevel)
     }
 #endif
 
+#if defined(_WIN32)
+    if (!ce->remote)
+    {
+        msg(msglevel, "NOTE: --remote is not defined, disabling data channel offload.");
+        return false;
+    }
+#endif
+
     return true;
 }
 
Signature · 1 line
2.38.1.windows.1
Acked-by on v1 1/1
#1 lore raw

"DCO WIN wants to do outgoing stuff", no server, no no-remote - so yes, makes sense.

Your patch has been applied to the master branch.

commit fd1c460ccfa38ca03e40e05524e2627917c58647

Author: Lev Stipakov
Date:   Thu Dec 1 14:59:02 2022 +0200
     dco: disable dco on Windows if --remote is not defined

     Signed-off-by: Lev Stipakov <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg25604.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering