bluetooth.ver: Export sanitizer symbols.
cover bluetooth.ver: Export sanitizer symbols.
We landed a ChromeOS-specific patch to make it possible to run bluez with sanitizers enabled, and I figured it might make sense to land it upstream so it is easier for the community to find bugs.
The patch any LLVM sanitzer related symbols so linking against libbase does not fail.
The ChromeOS patch landed here:
https://crrev.com/c/4060017
Note that on ChromeOS we don't yet use all the sanitizers so for this patch I added the missing sanitizers.
Allen Webb (1):
bluetooth.ver: Export sanitizer symbols.
src/bluetooth.ver | 6 ++++++ 1 file changed, 6 insertions(+)
Signature · 1 line
2.38.1.584.g0f3c55d4c2-goog
PATCH 1/1 bluetooth.ver: Export sanitizer symbols.
Fix llvm sanitizer support by not hidding sanitizer related symbols.
--- src/bluetooth.ver | 6 ++++++ 1 file changed, 6 insertions(+)
src/bluetooth.ver +6 -0
@@ -7,6 +7,12 @@ debug; baswap; ba2str; + /* Sanitizer support */ + __asan*; + __lsan*; + __msan*; + __sanitizer*; + __ubsan*; local: *; };
Signature · 1 line
2.38.1.584.g0f3c55d4c2-goog
v2 cover Add missing sanitizers.
This includes the additional sanitizers not in the original ChromeOS patch.
Allen Webb (1):
bluetooth.ver: Export sanitizer symbols.
src/bluetooth.ver | 8 ++++++++ 1 file changed, 8 insertions(+)
Signature · 1 line
2.38.1.584.g0f3c55d4c2-goog
PATCH v2 1/1 bluetooth.ver: Export sanitizer symbols.
In reply to Allen WebbFix llvm sanitizer support by not hidding sanitizer related symbols.
--- src/bluetooth.ver | 8 ++++++++ 1 file changed, 8 insertions(+)
src/bluetooth.ver +8 -0
@@ -7,6 +7,14 @@ debug; baswap; ba2str; + /* Don't break LLVM sanitizers */ + __asan*; + __dfsan*; + __lsan*; + __msan*; + __sanitizer*; + __tsan*; + __ubsan*; local: *; };
Signature · 1 line
2.38.1.584.g0f3c55d4c2-goog
RE: Add missing sanitizers.
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=700907
---Test result---
Test Summary:
CheckPatch PASS 0.44 seconds GitLint FAIL 0.59 seconds BuildEll PASS 26.49 seconds BluezMake PASS 768.96 seconds MakeCheck PASS 11.50 seconds MakeDistcheck PASS 148.78 seconds CheckValgrind PASS 244.46 seconds bluezmakeextell PASS 95.06 seconds IncrementalBuild PASS 639.32 seconds ScanBuild PASS 979.22 seconds
Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v2,1/1] bluetooth.ver: Export sanitizer symbols.
1: T3 Title has trailing punctuation (.): "[BlueZ,v2,1/1] bluetooth.ver: Export sanitizer symbols."
---
Regards,
Linux Bluetooth
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=700903
---Test result---
Test Summary:
CheckPatch PASS 0.36 seconds GitLint FAIL 0.52 seconds BuildEll PASS 26.68 seconds BluezMake PASS 842.23 seconds MakeCheck PASS 11.03 seconds MakeDistcheck PASS 143.48 seconds CheckValgrind PASS 239.25 seconds bluezmakeextell PASS 93.39 seconds IncrementalBuild PASS 695.15 seconds ScanBuild PASS 986.64 seconds
Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,1/1] bluetooth.ver: Export sanitizer symbols.
1: T3 Title has trailing punctuation (.): "[BlueZ,1/1] bluetooth.ver: Export sanitizer symbols."
---
Regards,
Linux Bluetooth
v3 cover Fix git lint error
This version of the patch removes the trailing punctuation from the commit message.
Allen Webb (1):
bluetooth.ver: Export sanitizer symbols
src/bluetooth.ver | 8 ++++++++ 1 file changed, 8 insertions(+)
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
PATCH v3 1/1 bluetooth.ver: Export sanitizer symbols
In reply to [email protected]Fix llvm sanitizer support by not hidding sanitizer related symbols.
--- src/bluetooth.ver | 8 ++++++++ 1 file changed, 8 insertions(+)
src/bluetooth.ver +8 -0
@@ -7,6 +7,14 @@ debug; baswap; ba2str; + /* Don't break LLVM sanitizers */ + __asan*; + __dfsan*; + __lsan*; + __msan*; + __sanitizer*; + __tsan*; + __ubsan*; local: *; };
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
Re: [PATCH BlueZ v3 1/1] bluetooth.ver: Export sanitizer symbols
Dear Allen,
Thank you for upstreaming your changes.
Am 01.12.22 um 18:16 schrieb Allen Webb:
Quoted 1 line
Fix llvm sanitizer support by not hidding sanitizer related symbols.
hiding
Quoted 3 lines
--- src/bluetooth.ver | 8 ++++++++ 1 file changed, 8 insertions(+)
[…]
Kind regards,
Paul
v4 cover Fix spelling error in the commit message
This version of the patch fixes a spelling error in the commit message.
Allen Webb (1):
bluetooth.ver: Export sanitizer symbols
src/bluetooth.ver | 8 ++++++++ 1 file changed, 8 insertions(+)
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
PATCH v4 1/1 bluetooth.ver: Export sanitizer symbols
Fix llvm sanitizer support by not hiding sanitizer related symbols.
--- src/bluetooth.ver | 8 ++++++++ 1 file changed, 8 insertions(+)
src/bluetooth.ver +8 -0
@@ -7,6 +7,14 @@ debug; baswap; ba2str; + /* Don't break LLVM sanitizers */ + __asan*; + __dfsan*; + __lsan*; + __msan*; + __sanitizer*; + __tsan*; + __ubsan*; local: *; };
Signature · 1 line
2.39.0.rc0.267.gcb52ba06e7-goog
RE: Fix spelling error in the commit message
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=700956
---Test result---
Test Summary:
CheckPatch PASS 0.50 seconds GitLint PASS 0.37 seconds BuildEll PASS 27.16 seconds BluezMake PASS 873.98 seconds MakeCheck PASS 11.15 seconds MakeDistcheck PASS 146.04 seconds CheckValgrind PASS 243.63 seconds bluezmakeextell PASS 94.74 seconds IncrementalBuild PASS 712.61 seconds ScanBuild PASS 1013.02 seconds
---
Regards,
Linux Bluetooth
RE: Fix git lint error
In reply to Allen WebbThis is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=700921
---Test result---
Test Summary:
CheckPatch PASS 0.35 seconds GitLint PASS 0.26 seconds BuildEll PASS 34.37 seconds BluezMake PASS 1186.40 seconds MakeCheck PASS 13.08 seconds MakeDistcheck PASS 189.04 seconds CheckValgrind PASS 306.64 seconds bluezmakeextell PASS 124.33 seconds IncrementalBuild PASS 986.86 seconds ScanBuild PASS 1316.16 seconds
---
Regards,
Linux Bluetooth