memstick/mspro_block: use sysfs_emit() to instead of scnprintf()
Subsystems (2)
PATCH 1/1 memstick/mspro_block: use sysfs_emit() to instead of scnprintf()
From: ye xingchen <[email protected]>
Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.
Signed-off-by ye xingchen <[email protected]>
--- drivers/memstick/core/mspro_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/memstick/core/mspro_block.c +1 -1
@@ -356,7 +356,7 @@ static ssize_t mspro_block_attr_show_modelname(struct device *dev, struct mspro_sys_attr, dev_attr); -return scnprintf (buffer,PAGE_SIZE ,"%s" , (char *)s_attr->data); +return sysfs_emit (buffer,"%s\n" , (char *)s_attr->data); } static ssize_t mspro_block_attr_show_mbr(struct device *dev,
Signature · 1 line
2.25.1
Quoted 6 lines · On Thu, 1 Dec 2022 at 12:50, <[email protected]> wrote:
From: ye xingchen <[email protected]>
Follow the advice of the
Documentation/filesystems/sysfs.rstandshow()should only usesysfs_emit()orsysfs_emit_at()when formatting the value to be returned to user space.
There are plenty of other conversions that can be done using sysfs_emit_at() in drivers/memstick/core/mspro_block.c. Would you mind doing that too, as part of the $subject patch?
Kind regards
Uffe
Quoted 21 lines
Signed-off-by ye xingchen <[email protected]>--- drivers/memstick/core/mspro_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/memstick/core/mspro_block.c +1
-2@@ -356,7 +356,7 @@ static ssize_t mspro_block_attr_show_modelname(struct device *dev, struct mspro_sys_attr, dev_attr); -return scnprintf (buffer,PAGE_SIZE ,"%s" , (char *)s_attr->data); +return sysfs_emit (buffer,"%s\n" , (char *)s_attr->data); } static ssize_t mspro_block_attr_show_mbr(struct device *dev, --2.25.1