Skip to contentSkip to conversation

pxa: Remove dev_err() after platform_get_irq()

PATCH Applied [email protected] 2 participants 2 messages Dec 2, 2022 – Dec 4, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 pxa: Remove dev_err() after platform_get_irq()

From: zhang songyi <[email protected]>

There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure.

---
 drivers/soc/pxa/ssp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/soc/pxa/ssp.c +1 -3
index 93449fb3519e..bd029e838241 100644
@@ -146,10 +146,8 @@ static int pxa_ssp_probe(struct platform_device *pdev)
 	}
 
 	ssp->irq = platform_get_irq(pdev, 0);
-	if (ssp->irq < 0) {
-		dev_err(dev, "no IRQ resource defined\n");
+	if (ssp->irq < 0)
 		return -ENODEV;
-	}
 
 	if (dev->of_node) {
 		const struct of_device_id *id =
Signature · 1 line
2.15.2
#1 lore raw
This patch was applied to soc/soc.git (for-next) by Arnd Bergmann <[email protected]>:

Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <[email protected]>:

Quoted 8 lines · On Fri, 2 Dec 2022 10:42:04 +0800 (CST) you wrote:

From: zhang songyi <[email protected]>

There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure.

[...]

Here is the summary with links:
- [linux-next,v2] pxa: Remove dev_err() after platform_get_irq()

    https://git.kernel.org/soc/soc/c/1d9ae5a1356a

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html