sfc: use sysfs_emit() to instead of scnprintf()
Subsystems (3)
PATCH 1/1 sfc: use sysfs_emit() to instead of scnprintf()
From: ye xingchen <[email protected]>
Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.
Signed-off-by ye xingchen <[email protected]>
--- drivers/net/ethernet/sfc/efx_common.c | 2 +- drivers/net/ethernet/sfc/siena/efx_common.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/sfc/efx_common.c +1 -1
@@ -1164,7 +1164,7 @@ static ssize_t mcdi_logging_show(struct device *dev,struct efx_nic *efx =dev_get_drvdata (dev);struct efx_mcdi_iface *mcdi =efx_mcdi (efx); -return scnprintf (buf,PAGE_SIZE ,"%d\n" , mcdi->logging_enabled); +return sysfs_emit (buf,"%d\n" , mcdi->logging_enabled); } static ssize_t mcdi_logging_store(struct device *dev,
drivers/net/ethernet/sfc/siena/efx_common.c +1 -1
@@ -1178,7 +1178,7 @@ static ssize_t mcdi_logging_show(struct device *dev,struct efx_nic *efx =dev_get_drvdata (dev);struct efx_mcdi_iface *mcdi =efx_mcdi (efx); -return scnprintf (buf,PAGE_SIZE ,"%d\n" , mcdi->logging_enabled); +return sysfs_emit (buf,"%d\n" , mcdi->logging_enabled); } static ssize_t mcdi_logging_store(struct device *dev,
Signature · 1 line
2.25.1
Quoted 11 lines · On Fri, Dec 02, 2022 at 04:32:20PM +0800, [email protected] wrote:
From: ye xingchen <[email protected]>
Follow the advice of the
Documentation/filesystems/sysfs.rstandshow()should only usesysfs_emit()orsysfs_emit_at()when formatting the value to be returned to user space.Signed-off-by ye xingchen <[email protected]>--- drivers/net/ethernet/sfc/efx_common.c | 2 +- drivers/net/ethernet/sfc/siena/efx_common.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Please use [PATCH net-next] ... format in title.
Thanks