net: ipa: use sysfs_emit() to instead of scnprintf()
Subsystems (3)
PATCH 1/1 net: ipa: use sysfs_emit() to instead of scnprintf()
From: ye xingchen <[email protected]>
Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.
--- drivers/net/ipa/ipa_sysfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ipa/ipa_sysfs.c +3 -3
@@ -46,7 +46,7 @@ version_show(struct device *dev, struct device_attribute *attr, char *buf) {struct ipa *ipa =dev_get_drvdata (dev); -return scnprintf (buf,PAGE_SIZE ,"%s\n" ,ipa_version_string (ipa)); +return sysfs_emit (buf,"%s\n" ,ipa_version_string (ipa)); }static DEVICE_ATTR_RO (version);
@@ -70,7 +70,7 @@ static ssize_t rx_offload_show(struct device *dev, {struct ipa *ipa =dev_get_drvdata (dev); -return scnprintf (buf,PAGE_SIZE ,"%s\n" ,ipa_offload_string (ipa)); +return sysfs_emit (buf,"%s\n" ,ipa_offload_string (ipa)); }static DEVICE_ATTR_RO (rx_offload);
@@ -80,7 +80,7 @@ static ssize_t tx_offload_show(struct device *dev, {struct ipa *ipa =dev_get_drvdata (dev); -return scnprintf (buf,PAGE_SIZE ,"%s\n" ,ipa_offload_string (ipa)); +return sysfs_emit (buf,"%s\n" ,ipa_offload_string (ipa)); }static DEVICE_ATTR_RO (tx_offload);
Signature · 1 line
2.25.1
Quoted 5 lines · On 12/2/22 2:42 AM, [email protected] wrote:
From: ye xingchen <[email protected]>
Follow the advice of the
Documentation/filesystems/sysfs.rstandshow()should only usesysfs_emit()orsysfs_emit_at()when formatting the value to be returned to user space.
The buffer passed is non-null and the existing code properly limits the buffer to PAGE_SIZE.
But... OK.
Quoted 37 lines
Signed-off-by ye xingchen <[email protected]>--- drivers/net/ipa/ipa_sysfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/net/ipa/ipa_sysfs.c +3
-3@@ -46,7 +46,7 @@ version_show(struct device *dev, struct device_attribute *attr, char *buf) {struct ipa *ipa =dev_get_drvdata (dev); -return scnprintf (buf,PAGE_SIZE ,"%s\n" ,ipa_version_string (ipa)); +return sysfs_emit (buf,"%s\n" ,ipa_version_string (ipa)); }static DEVICE_ATTR_RO (version);@@ -70,7 +70,7 @@ static ssize_t rx_offload_show(struct device *dev, {struct ipa *ipa =dev_get_drvdata (dev); -return scnprintf (buf,PAGE_SIZE ,"%s\n" ,ipa_offload_string (ipa)); +return sysfs_emit (buf,"%s\n" ,ipa_offload_string (ipa)); }static DEVICE_ATTR_RO (rx_offload);@@ -80,7 +80,7 @@ static ssize_t tx_offload_show(struct device *dev, {struct ipa *ipa =dev_get_drvdata (dev); -return scnprintf (buf,PAGE_SIZE ,"%s\n" ,ipa_offload_string (ipa)); +return sysfs_emit (buf,"%s\n" ,ipa_offload_string (ipa)); }static DEVICE_ATTR_RO (tx_offload);
Jakub Kicinski
maintainerQuoted 7 lines · On Fri, 2 Dec 2022 16:20:16 -0600 Alex Elder wrote:
Quoted 5 lines · On 12/2/22 2:42 AM, [email protected] wrote:
From: ye xingchen <[email protected]>
Follow the advice of the
Documentation/filesystems/sysfs.rstandshow()should only usesysfs_emit()orsysfs_emit_at()when formatting the value to be returned to user space.
Quoted 7 lines
The buffer passed is non-null and the existing code properly limits the buffer to
PAGE_SIZE.But... OK.
Reviewed-by Alex Elder <[email protected]>
Thanks! 38db82e2940 in net-next.