Skip to contentSkip to conversation

clk: qcom: rpmh: add support for SM6350 rpmh IPA clock

PATCH Applied Alex Elder 4 participants 6 messages Dec 2, 2022 – Dec 7, 2022

Subsystems (3)
lore
Share & tools
lore

Alex Elder

author
#0 lore raw

PATCH v2 1/1 clk: qcom: rpmh: add support for SM6350 rpmh IPA clock

From: Luca Weiss <[email protected]>

The IPA core clock is required for SM6350. Define it.

[[email protected]: rebased with Dmitry's changes]

---
v2: This is now based on qualcomm/for-next.

 drivers/clk/qcom/clk-rpmh.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/qcom/clk-rpmh.c +1 -0
index 2c2ef4b6d130e..586a810c682ca 100644
@@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
 	[RPMH_LN_BB_CLK3_A]	= &clk_rpmh_ln_bb_clk3_g4_ao.hw,
 	[RPMH_QLINK_CLK]	= &clk_rpmh_qlink_div4.hw,
 	[RPMH_QLINK_CLK_A]	= &clk_rpmh_qlink_div4_ao.hw,
+	[RPMH_IPA_CLK]		= &clk_rpmh_ipa.hw,
 };
 
 static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
Signature · 1 line
2.34.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 7 lines · Alex Elder

From: Luca Weiss <[email protected]>

The IPA core clock is required for SM6350. Define it.

[[email protected]: rebased with Dmitry's changes]

---

Konrad

Quoted 17 lines

v2: This is now based on qualcomm/for-next.

 drivers/clk/qcom/clk-rpmh.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/qcom/clk-rpmh.c +1 -0
index 2c2ef4b6d130e..586a810c682ca 100644
@@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
 	[RPMH_LN_BB_CLK3_A]	= &clk_rpmh_ln_bb_clk3_g4_ao.hw,
 	[RPMH_QLINK_CLK]	= &clk_rpmh_qlink_div4.hw,
 	[RPMH_QLINK_CLK_A]	= &clk_rpmh_qlink_div4_ao.hw,
+	[RPMH_IPA_CLK]		= &clk_rpmh_ipa.hw,
 };
 
 static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
maintainer
#2 lore raw
In reply to Alex Elder
Quoted 6 lines · Alex Elder

From: Luca Weiss <[email protected]>

The IPA core clock is required for SM6350. Define it.

[[email protected]: rebased with Dmitry's changes]

Thanks for rebasing this Alex. But as you're handling the patch you need to add your S-o-b; which will make sure your [] makes sense as well.

Regards,
Bjorn

Quoted 21 lines

---
v2: This is now based on qualcomm/for-next.

 drivers/clk/qcom/clk-rpmh.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/qcom/clk-rpmh.c +1 -0
index 2c2ef4b6d130e..586a810c682ca 100644
@@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
 	[RPMH_LN_BB_CLK3_A]	= &clk_rpmh_ln_bb_clk3_g4_ao.hw,
 	[RPMH_QLINK_CLK]	= &clk_rpmh_qlink_div4.hw,
 	[RPMH_QLINK_CLK_A]	= &clk_rpmh_qlink_div4_ao.hw,
+	[RPMH_IPA_CLK]		= &clk_rpmh_ipa.hw,
 };
 
 static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
Signature · 1 line
2.34.1
#3 lore raw
Quoted 7 lines · Bjorn Andersson
Quoted 6 lines · Alex Elder

From: Luca Weiss <[email protected]>

The IPA core clock is required for SM6350. Define it.

[[email protected]: rebased with Dmitry's changes]

Sorry about that, I knew I was supposed to sign
off and thought I had.

You told me separately that this was sufficient:

If you want me to send a new version with the
signoff just let me know. Thanks.

-Alex

Quoted 28 lines

Thanks for rebasing this Alex. But as you're handling the patch you need to add your S-o-b; which will make sure your [] makes sense as well.

Regards,
Bjorn

Quoted 21 lines

---
v2: This is now based on qualcomm/for-next.

  drivers/clk/qcom/clk-rpmh.c | 1 +
  1 file changed, 1 insertion(+)
drivers/clk/qcom/clk-rpmh.c +1 -0
index 2c2ef4b6d130e..586a810c682ca 100644
@@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
  	[RPMH_LN_BB_CLK3_A]	= &clk_rpmh_ln_bb_clk3_g4_ao.hw,
  	[RPMH_QLINK_CLK]	= &clk_rpmh_qlink_div4.hw,
  	[RPMH_QLINK_CLK_A]	= &clk_rpmh_qlink_div4_ao.hw,
+	[RPMH_IPA_CLK]		= &clk_rpmh_ipa.hw,
  };
 
  static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
Signature · 1 line
2.34.1
maintainer
#4 lore raw
Quoted 12 lines · Alex Elder
Quoted 7 lines · Bjorn Andersson
Quoted 6 lines · Alex Elder

From: Luca Weiss <[email protected]>

The IPA core clock is required for SM6350. Define it.

[[email protected]: rebased with Dmitry's changes]

Sorry about that, I knew I was supposed to sign
off and thought I had.

Quoted 7 lines

You told me separately that this was sufficient:

If you want me to send a new version with the
signoff just let me know. Thanks.

That works fine, thank you.
Bjorn

Quoted 29 lines

-Alex

Quoted 27 lines

Thanks for rebasing this Alex. But as you're handling the patch you need to add your S-o-b; which will make sure your [] makes sense as well.

Regards,
Bjorn

Quoted 20 lines

---
v2: This is now based on qualcomm/for-next.

  drivers/clk/qcom/clk-rpmh.c | 1 +
  1 file changed, 1 insertion(+)
drivers/clk/qcom/clk-rpmh.c +1 -0
index 2c2ef4b6d130e..586a810c682ca 100644
@@ -606,6 +606,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = {
  	[RPMH_LN_BB_CLK3_A]	= &clk_rpmh_ln_bb_clk3_g4_ao.hw,
  	[RPMH_QLINK_CLK]	= &clk_rpmh_qlink_div4.hw,
  	[RPMH_QLINK_CLK_A]	= &clk_rpmh_qlink_div4_ao.hw,
+	[RPMH_IPA_CLK]		= &clk_rpmh_ipa.hw,
  };
  static const struct clk_rpmh_desc clk_rpmh_sm6350 = {
Signature · 1 line
2.34.1