Skip to contentSkip to conversation

rtc: ds1307: use sysfs_emit() to instead of scnprintf()

PATCH Applied [email protected] 2 participants 2 messages Dec 5, 2022 – Dec 12, 2022 Real time clock (RTC)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtc: ds1307: use sysfs_emit() to instead of scnprintf()

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

---
 drivers/rtc/rtc-ds1307.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/rtc/rtc-ds1307.c +1 -2
index 7c2276cf5514..def9b7f9d957 100644
@@ -1219,8 +1219,7 @@ static ssize_t frequency_test_show(struct device *dev,
 
 	regmap_read(ds1307->regmap, M41TXX_REG_CONTROL, &ctrl_reg);
 
-	return scnprintf(buf, PAGE_SIZE, (ctrl_reg & M41TXX_BIT_FT) ? "on\n" :
-			"off\n");
+	return sysfs_emit(buf, (ctrl_reg & M41TXX_BIT_FT) ? "on\n" : "off\n");
 }
 
 static DEVICE_ATTR_RW(frequency_test);
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw
Quoted 8 lines · On Mon, 5 Dec 2022 11:34:45 +0800 (CST), [email protected] wrote:

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

[...]

Applied, thanks!

[1/1] rtc: ds1307: use sysfs_emit() to instead of scnprintf()

      commit: 20ff2be9cf5c1951e5a14e570129cf118039a25a

Best regards,

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com