Skip to contentSkip to conversation

ksmbd: use sysfs_emit() to instead of scnprintf()

PATCH In review [email protected] 2 participants 2 messages Dec 5, 2022 – Dec 6, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ksmbd: use sysfs_emit() to instead of scnprintf()

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

---
 fs/ksmbd/server.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ksmbd/server.c +1 -1
index a0d635304754..b0da15377709 100644
@@ -433,7 +433,7 @@ static ssize_t stats_show(struct class *class, struct class_attribute *attr,
 		"shutdown"
 	};
 
-	ssize_t sz = scnprintf(buf, PAGE_SIZE, "%d %s %d %lu\n", stats_version,
+	ssize_t sz = sysfs_emit(buf, "%d %s %d %lu\n", stats_version,
 			       state[server_conf.state], server_conf.tcp_port,
 			       server_conf.ipc_last_active / HZ);
 	return sz;
Signature · 1 line
2.25.1
maintainer
#1 lore raw

2022-12-05 18:03 GMT+09:00, [email protected] <[email protected]>:

Quoted 16 lines

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

---
 fs/ksmbd/server.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ksmbd/server.c +0 -0
index a0d635304754..b0da15377709 100644

fs/ksmbd/server.c static ssize_t stats_show(struct class *class, struct · line 439

Quoted 8 lines
fs/ksmbd/server.c +1 -1
@@ -433,7 +433,7 @@ static ssize_t stats_show(struct class *class, struct
 class_attribute *attr,
 		"shutdown"
 	};
 
-	ssize_t sz = scnprintf(buf, PAGE_SIZE, "%d %s %d %lu\n", stats_version,
+	ssize_t sz = sysfs_emit(buf, "%d %s %d %lu\n", stats_version,
 			       state[server_conf.state], server_conf.tcp_port,
 			       server_conf.ipc_last_active / HZ);

It would be great if you remove sz variable and return it directly.

Thanks.

Quoted 4 lines

return sz;
--
2.25.1