cpufreq: acpi: Only set boost MSRs on supported CPUs
PATCH 1/1 cpufreq: acpi: Only set boost MSRs on supported CPUs
Stop trying to set boost MSRs on CPUs that don't support boost.
This corrects a bug in the recent patch "Defer setting boost MSRs".
--- drivers/cpufreq/acpi-cpufreq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/cpufreq/acpi-cpufreq.c +2 -1
@@ -888,7 +888,8 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)if (perf->states[0 ].core_frequency *1000 != freq_table[0 ].frequency)pr_warn (FW_WARN "P-state 0 is not max freq\n" ); -set_boost (policy, acpi_cpufreq_driver.boost_enabled); +if (acpi_cpufreq_driver.set_boost) +set_boost (policy, acpi_cpufreq_driver.boost_enabled);return result;
Signature · 1 line
2.31.1
Quoted 14 lines · Stuart Hayes
Stop trying to set boost MSRs on CPUs that don't support boost.
This corrects a bug in the recent patch "Defer setting boost MSRs".
Signed-off-by Stuart Hayes <[email protected]>--- drivers/cpufreq/acpi-cpufreq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/cpufreq/acpi-cpufreq.c +0
-0
drivers/cpufreq/acpi-cpufreq.c static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy) · line 895
Quoted 9 lines
drivers/cpufreq/acpi-cpufreq.c +2
-1@@ -888,7 +888,8 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)if (perf->states[0 ].core_frequency *1000 != freq_table[0 ].frequency)pr_warn (FW_WARN "P-state 0 is not max freq\n" ); -set_boost (policy, acpi_cpufreq_driver.boost_enabled); +if (acpi_cpufreq_driver.set_boost) +set_boost (policy, acpi_cpufreq_driver.boost_enabled);return result;
My apologies--adding Boris, I forgot to put him on the "to" list.
Borislav Petkov
Tested-byQuoted 12 lines · stuart hayes
Quoted 9 lines · Stuart Hayes
Stop trying to set boost MSRs on CPUs that don't support boost.
This corrects a bug in the recent patch "Defer setting boost MSRs".
Signed-off-by Stuart Hayes <[email protected]>--- drivers/cpufreq/acpi-cpufreq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 13 lines
drivers/cpufreq/acpi-cpufreq.c static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy) · line 892
Quoted 11 lines
drivers/cpufreq/acpi-cpufreq.c +2
-1@@ -888,7 +888,8 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)if (perf->states[0 ].core_frequency *1000 != freq_table[0 ].frequency)pr_warn (FW_WARN "P-state 0 is not max freq\n" ); -set_boost (policy, acpi_cpufreq_driver.boost_enabled); +if (acpi_cpufreq_driver.set_boost) +set_boost (policy, acpi_cpufreq_driver.boost_enabled);return result;My apologies--adding Boris, I forgot to put him on the "to" list.
Yap, that does it.
Thx.
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteRafael J. Wysocki
maintainerQuoted 28 lines · Borislav Petkov
Quoted 12 lines · stuart hayes
Quoted 9 lines · Stuart Hayes
Stop trying to set boost MSRs on CPUs that don't support boost.
This corrects a bug in the recent patch "Defer setting boost MSRs".
Signed-off-by Stuart Hayes <[email protected]>--- drivers/cpufreq/acpi-cpufreq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Quoted 13 lines
drivers/cpufreq/acpi-cpufreq.c static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy) · line 892
Quoted 11 lines
drivers/cpufreq/acpi-cpufreq.c +2
-1@@ -888,7 +888,8 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)if (perf->states[0 ].core_frequency *1000 != freq_table[0 ].frequency)pr_warn (FW_WARN "P-state 0 is not max freq\n" ); -set_boost (policy, acpi_cpufreq_driver.boost_enabled); +if (acpi_cpufreq_driver.set_boost) +set_boost (policy, acpi_cpufreq_driver.boost_enabled);return result;My apologies--adding Boris, I forgot to put him on the "to" list.
Quoted 4 lines
Yap, that does it.
Reported-by Borislav Petkov (AMD) <[email protected]>
OK, applied, thanks!