Skip to contentSkip to conversation

cpufreq: acpi: Only set boost MSRs on supported CPUs

PATCH In review Stuart Hayes 3 participants 4 messages Dec 5, 2022 – Dec 6, 2022 CPU frequency scaling framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpufreq: acpi: Only set boost MSRs on supported CPUs

Stop trying to set boost MSRs on CPUs that don't support boost.

This corrects a bug in the recent patch "Defer setting boost MSRs".

---
 drivers/cpufreq/acpi-cpufreq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/cpufreq/acpi-cpufreq.c +2 -1
index bb58175a8d40..a7c5e312340e 100644
@@ -888,7 +888,8 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	if (perf->states[0].core_frequency * 1000 != freq_table[0].frequency)
 		pr_warn(FW_WARN "P-state 0 is not max freq\n");
 
-	set_boost(policy, acpi_cpufreq_driver.boost_enabled);
+	if (acpi_cpufreq_driver.set_boost)
+		set_boost(policy, acpi_cpufreq_driver.boost_enabled);
 
 	return result;
 
Signature · 1 line
2.31.1
#1 lore raw
Quoted 14 lines · Stuart Hayes

Stop trying to set boost MSRs on CPUs that don't support boost.

This corrects a bug in the recent patch "Defer setting boost MSRs".

---
  drivers/cpufreq/acpi-cpufreq.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/cpufreq/acpi-cpufreq.c +0 -0
index bb58175a8d40..a7c5e312340e 100644

drivers/cpufreq/acpi-cpufreq.c static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy) · line 895

Quoted 9 lines
drivers/cpufreq/acpi-cpufreq.c +2 -1
@@ -888,7 +888,8 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
  	if (perf->states[0].core_frequency * 1000 != freq_table[0].frequency)
  		pr_warn(FW_WARN "P-state 0 is not max freq\n");
 
-	set_boost(policy, acpi_cpufreq_driver.boost_enabled);
+	if (acpi_cpufreq_driver.set_boost)
+		set_boost(policy, acpi_cpufreq_driver.boost_enabled);
 
  	return result;
 

My apologies--adding Boris, I forgot to put him on the "to" list.

Tested-by
#2 lore raw
Quoted 12 lines · stuart hayes
Quoted 9 lines · Stuart Hayes

Stop trying to set boost MSRs on CPUs that don't support boost.

This corrects a bug in the recent patch "Defer setting boost MSRs".

---
  drivers/cpufreq/acpi-cpufreq.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 13 lines

drivers/cpufreq/acpi-cpufreq.c static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy) · line 892

Quoted 11 lines
drivers/cpufreq/acpi-cpufreq.c +2 -1
index bb58175a8d40..a7c5e312340e 100644
@@ -888,7 +888,8 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
  	if (perf->states[0].core_frequency * 1000 != freq_table[0].frequency)
  		pr_warn(FW_WARN "P-state 0 is not max freq\n");
-	set_boost(policy, acpi_cpufreq_driver.boost_enabled);
+	if (acpi_cpufreq_driver.set_boost)
+		set_boost(policy, acpi_cpufreq_driver.boost_enabled);
  	return result;

My apologies--adding Boris, I forgot to put him on the "to" list.

Yap, that does it.

Thx.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
#3 lore raw
Quoted 28 lines · Borislav Petkov
Quoted 12 lines · stuart hayes
Quoted 9 lines · Stuart Hayes

Stop trying to set boost MSRs on CPUs that don't support boost.

This corrects a bug in the recent patch "Defer setting boost MSRs".

---
  drivers/cpufreq/acpi-cpufreq.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 13 lines

drivers/cpufreq/acpi-cpufreq.c static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy) · line 892

Quoted 11 lines
drivers/cpufreq/acpi-cpufreq.c +2 -1
index bb58175a8d40..a7c5e312340e 100644
@@ -888,7 +888,8 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
    if (perf->states[0].core_frequency * 1000 != freq_table[0].frequency)
            pr_warn(FW_WARN "P-state 0 is not max freq\n");
-   set_boost(policy, acpi_cpufreq_driver.boost_enabled);
+   if (acpi_cpufreq_driver.set_boost)
+           set_boost(policy, acpi_cpufreq_driver.boost_enabled);
    return result;

My apologies--adding Boris, I forgot to put him on the "to" list.

Quoted 4 lines

Yap, that does it.

OK, applied, thanks!