rockchip: Pinebook Pro: Do not initialize i2c before relocation
PATCH 1/1 rockchip: Pinebook Pro: Do not initialize i2c before relocation
The i2c locks up when initialized before relocation, and it stays broken in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before commit ad607512f575 ("power: pmic: rk8xx: Support sysreset shutdown method")
The cause is not known.
This is board-specific, other boards that do not add the option to include the i2c bus in pre-reloc DT are not affected.
---
This is not tested, my board does not currentl;y boot at all, YMMV
--- arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 8 -------- 1 file changed, 8 deletions(-)
arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi +0 -8
@@ -20,14 +20,6 @@ rockchip,panel = <&edp_panel>; }; -&i2c0 { - u-boot,dm-pre-reloc; -}; - -&rk808 { - u-boot,dm-pre-reloc; -}; - &sdhci { max-frequency = <25000000>; u-boot,dm-pre-reloc;
Signature · 1 line
2.38.1
Quoted 7 lines · Michal Suchanek
The i2c locks up when initialized before relocation, and it stays broken in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before commit
ad607512f575("power: pmic: rk8xx: Support sysreset shutdown method")
Quoted 6 lines
The cause is not known.
This is board-specific, other boards that do not add the option to include the i2c bus in pre-reloc DT are not affected.
Signed-off-by Michal Suchanek <[email protected]>
Thanks for checking this out, I had noticed a regression and had got as far as bisecting it but not getting to a fix.
Tom: can we get this pulled into 2023.01 please?
Peter
Quoted 29 lines
---
This is not tested, my board does not currentl;y boot at all, YMMV
--- arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 8 -------- 1 file changed, 8 deletions(-)arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi +0
-9@@ -20,14 +20,6 @@ rockchip,panel = <&edp_panel>; }; -&i2c0 { - u-boot,dm-pre-reloc; -}; - -&rk808 { - u-boot,dm-pre-reloc; -}; - &sdhci { max-frequency = <25000000>; u-boot,dm-pre-reloc; --2.38.1
Quoted 15 lines · Peter Robinson
Quoted 7 lines · Michal Suchanek
The i2c locks up when initialized before relocation, and it stays broken in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before commit
ad607512f575("power: pmic: rk8xx: Support sysreset shutdown method")Quoted 6 lines
The cause is not known.
This is board-specific, other boards that do not add the option to include the i2c bus in pre-reloc DT are not affected.
Signed-off-by Michal Suchanek <[email protected]>
Quoted 7 lines
Reviewed-by Peter Robinson <[email protected]>Tested-by Peter Robinson <[email protected]>Thanks for checking this out, I had noticed a regression and had got as far as bisecting it but not getting to a fix.
Tom: can we get this pulled into 2023.01 please?
Probably should be, yes. Kever, are there any other rockchip must-fixes for v2023.01? I can take this directly if you don't have others and/or don't want to make up a PR, thanks!
Signature · 1 line
Tom
Hi,
Quoted 20 lines · Tom Rini
Quoted 18 lines · Peter Robinson
Quoted 7 lines · Michal Suchanek
The i2c locks up when initialized before relocation, and it stays broken in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before commit
ad607512f575("power: pmic: rk8xx: Support sysreset shutdown method")Quoted 6 lines
The cause is not known.
This is board-specific, other boards that do not add the option to include the i2c bus in pre-reloc DT are not affected.
Signed-off-by Michal Suchanek <[email protected]>Reviewed-by Peter Robinson <[email protected]>Tested-by Peter Robinson <[email protected]>
Quoted 8 lines
Quoted 4 lines
Thanks for checking this out, I had noticed a regression and had got as far as bisecting it but not getting to a fix.
Tom: can we get this pulled into 2023.01 please?
Probably should be, yes. Kever, are there any other rockchip must-fixes for v2023.01? I can take this directly if you don't have others and/or don't want to make up a PR, thanks!
There is also this one:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
Regards,
Simon
Hi Simon,
Quoted 23 lines · Simon Glass
Hi,
Quoted 20 lines · Tom Rini
Quoted 19 lines · Peter Robinson
Quoted 6 lines · Michal Suchanek
The i2c locks up when initialized before relocation, and it stays broken in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before commit
ad607512f575("power: pmic: rk8xx: Support sysreset shutdown method")Quoted 6 lines
The cause is not known.
This is board-specific, other boards that do not add the option to include the i2c bus in pre-reloc DT are not affected.
Signed-off-by Michal Suchanek <[email protected]>Reviewed-by Peter Robinson <[email protected]>Tested-by Peter Robinson <[email protected]>Thanks for checking this out, I had noticed a regression and had got as far as bisecting it but not getting to a fix.
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
Tom: can we get this pulled into 2023.01 please?
Probably should be, yes. Kever, are there any other rockchip must-fixes for v2023.01? I can take this directly if you don't have others and/or don't want to make up a PR, thanks!
There is also this one:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
This patch has been merge into mainline at about 21th Oct.
I forgot to update the patch status in patchwork system.
Thanks,
- Kever
Quoted 2 lines
Regards,
Simon
Hi Tom,
Quoted 17 lines · Tom Rini
Quoted 16 lines · Peter Robinson
Quoted 6 lines · Michal Suchanek
The i2c locks up when initialized before relocation, and it stays broken in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before commit
ad607512f575("power: pmic: rk8xx: Support sysreset shutdown method")Quoted 6 lines
The cause is not known.
This is board-specific, other boards that do not add the option to include the i2c bus in pre-reloc DT are not affected.
Signed-off-by Michal Suchanek <[email protected]>Reviewed-by Peter Robinson <[email protected]>Tested-by Peter Robinson <[email protected]>
Quoted 7 lines
Quoted 4 lines
Thanks for checking this out, I had noticed a regression and had got as far as bisecting it but not getting to a fix.
Tom: can we get this pulled into 2023.01 please?
Probably should be, yes. Kever, are there any other rockchip must-fixes for v2023.01? I can take this directly if you don't have others and/or don't want to make up a PR, thanks!
I will take these fixes, and send a PR to you later.
Thanks,
- Kever
Quoted 1 line
Quoted 6 lines · Michal Suchanek
The i2c locks up when initialized before relocation, and it stays broken in Linux as well breaking the ability to boot Linux.
The i2c bus and pmic was not actually used in pre-reloc before commit
ad607512f575("power: pmic: rk8xx: Support sysreset shutdown method")
Quoted 6 lines
The cause is not known.
This is board-specific, other boards that do not add the option to include the i2c bus in pre-reloc DT are not affected.
Signed-off-by Michal Suchanek <[email protected]>
Thanks,
- Kever
Quoted 26 lines
---
This is not tested, my board does not currentl;y boot at all, YMMV
--- arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi | 8 -------- 1 file changed, 8 deletions(-)arch/arm/dts/rk3399-pinebook-pro-u-boot.dtsi +0
-8@@ -20,14 +20,6 @@ rockchip,panel = <&edp_panel>; }; -&i2c0 { - u-boot,dm-pre-reloc; -}; - -&rk808 { - u-boot,dm-pre-reloc; -}; - &sdhci { max-frequency = <25000000>; u-boot,dm-pre-reloc;