Skip to contentSkip to conversation

cmd: spi: Judge the number of added parameters

PATCH In review chenzhipeng 3 participants 3 messages Dec 6, 2022 – Jan 13, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cmd: spi: Judge the number of added parameters

When only sspi is entered, help information can be printed.

---
 cmd/spi.c | 3 +++
 1 file changed, 3 insertions(+)
cmd/spi.c +3 -0
index 454ebe37d7..f30018f33b 100644
@@ -112,6 +112,9 @@ int do_spi(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
 
 	if ((flag & CMD_FLAG_REPEAT) == 0)
 	{
+		if (argc < 2)
+			return CMD_RET_USAGE;
+
 		if (argc >= 2) {
 			mode = CONFIG_DEFAULT_SPI_MODE;
 			bus = dectoul(argv[1], &cp);
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · chenzhipeng

When only sspi is entered, help information can be printed.

---
 cmd/spi.c | 3 +++
 1 file changed, 3 insertions(+)
Quoted 17 lines
cmd/spi.c +3 -1
index 454ebe37d7..f30018f33b 100644
@@ -112,6 +112,9 @@ int do_spi(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
 
        if ((flag & CMD_FLAG_REPEAT) == 0)
        {
+               if (argc < 2)
+                       return CMD_RET_USAGE;
+
                if (argc >= 2) {
                        mode = CONFIG_DEFAULT_SPI_MODE;
                        bus = dectoul(argv[1], &cp);
--

2.25.1