libertas/libertas_tf: don't call kfree_skb() under spin_lock_irqsave()
cover libertas/libertas_tf: don't call kfree_skb() under spin_lock_irqsave()
It is not allowed to call kfree_skb() from hardware interrupt context or with interrupts being disabled. As the comment of dev_kfree_skb_irq() says, kfree_skb() can be replaced with dev_kfree_skb_irq() under spin_lock_irqsave().
Yang Yingliang (4):
libertas_tf: don't call kfree_skb() under spin_lock_irqsave()
libertas: don't call kfree_skb() under spin_lock_irqsave() in
process_cmdrequest()
libertas: don't call kfree_skb() under spin_lock_irqsave() in
lbs_stop_iface()
libertas: don't call kfree_skb() under spin_lock_irqsave() in
lbs_mac_event_disconnected()
drivers/net/wireless/marvell/libertas/cmdresp.c | 2 +- drivers/net/wireless/marvell/libertas/if_usb.c | 2 +- drivers/net/wireless/marvell/libertas/main.c | 2 +- drivers/net/wireless/marvell/libertas_tf/if_usb.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.25.1
PATCH 1/4 libertas_tf: don't call kfree_skb() under spin_lock_irqsave()
It is not allowed to call kfree_skb() from hardware interrupt context or with interrupts being disabled. So replace kfree_skb() with dev_kfree_skb_irq() under spin_lock_irqsave().
--- drivers/net/wireless/marvell/libertas_tf/if_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/marvell/libertas_tf/if_usb.c +1 -1
@@ -613,7 +613,7 @@ static inline void process_cmdrequest(int recvlength, uint8_t *recvbuff,spin_lock_irqsave (&priv->driver_lock, flags);memcpy (priv->cmd_resp_buff, recvbuff +MESSAGE_HEADER_LEN , recvlength -MESSAGE_HEADER_LEN ); -kfree_skb (skb); +dev_kfree_skb_irq (skb);lbtf_cmd_response_rx (priv);spin_unlock_irqrestore (&priv->driver_lock, flags); }
Signature · 1 line
2.25.1
PATCH 2/4 libertas: don't call kfree_skb() under spin_lock_irqsave() in process_cmdrequest()
In reply to Yang YingliangIt is not allowed to call kfree_skb() from hardware interrupt context or with interrupts being disabled. So replace kfree_skb() with dev_kfree_skb_irq() under spin_lock_irqsave().
--- drivers/net/wireless/marvell/libertas/if_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/marvell/libertas/if_usb.c +1 -1
@@ -637,7 +637,7 @@ static inline void process_cmdrequest(int recvlength, uint8_t *recvbuff, priv->resp_len[i] = (recvlength -MESSAGE_HEADER_LEN );memcpy (priv->resp_buf[i], recvbuff +MESSAGE_HEADER_LEN , priv->resp_len[i]); -kfree_skb (skb); +dev_kfree_skb_irq (skb);lbs_notify_command_response (priv, i);spin_unlock_irqrestore (&priv->driver_lock, flags);
Signature · 1 line
2.25.1
PATCH 3/4 libertas: don't call kfree_skb() under spin_lock_irqsave() in lbs_stop_iface()
In reply to Yang YingliangIt is not allowed to call kfree_skb() from hardware interrupt context or with interrupts being disabled. So replace kfree_skb() with dev_kfree_skb_irq() under spin_lock_irqsave().
--- drivers/net/wireless/marvell/libertas/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/marvell/libertas/main.c +1 -1
@@ -216,7 +216,7 @@ int lbs_stop_iface(struct lbs_private *priv)spin_lock_irqsave (&priv->driver_lock, flags); priv->iface_running = false; -kfree_skb (priv->currenttxskb); +dev_kfree_skb_irq (priv->currenttxskb); priv->currenttxskb =NULL ; priv->tx_pending_len =0 ;spin_unlock_irqrestore (&priv->driver_lock, flags);
Signature · 1 line
2.25.1
Re: [PATCH 3/4] libertas: don't call kfree_skb() under spin_lock_irqsave() in lbs_stop_iface()
Hi,
thank you for your information.
On our website you can find email addresses of companies and people.
https://www.skymem.info
In short, it’s like Google for emails.
Best regards,
Robert,
Skymem team
Quoted 32 lines · Yang Yingliang
It is not allowed to call
kfree_skb()from hardware interrupt context or with interrupts being disabled. So replacekfree_skb()withdev_kfree_skb_irq()underspin_lock_irqsave().Fixes d2e7b3425c47 ("libertas: disable functionality when interface is down")Signed-off-by Yang Yingliang <[email protected]>--- drivers/net/wireless/marvell/libertas/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/wireless/marvell/libertas/main.c +1
-2@@ -216,7 +216,7 @@ int lbs_stop_iface(struct lbs_private *priv)spin_lock_irqsave (&priv->driver_lock, flags); priv->iface_running = false; -kfree_skb (priv->currenttxskb); +dev_kfree_skb_irq (priv->currenttxskb); priv->currenttxskb =NULL ; priv->tx_pending_len =0 ;spin_unlock_irqrestore (&priv->driver_lock, flags); --2.25.1
_______________________________________________
libertas-dev mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/libertas-dev
PATCH 4/4 libertas: don't call kfree_skb() under spin_lock_irqsave() in lbs_mac_event_disconnected()
In reply to Yang YingliangIt is not allowed to call kfree_skb() from hardware interrupt context or with interrupts being disabled. So replace kfree_skb() with dev_kfree_skb_irq() under spin_lock_irqsave().
--- drivers/net/wireless/marvell/libertas/cmdresp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/marvell/libertas/cmdresp.c +1 -1
@@ -48,7 +48,7 @@ void lbs_mac_event_disconnected(struct lbs_private *priv,/* Free Tx and Rx packets */ spin_lock_irqsave (&priv->driver_lock, flags); -kfree_skb (priv->currenttxskb); +dev_kfree_skb_irq (priv->currenttxskb); priv->currenttxskb =NULL ; priv->tx_pending_len =0 ;spin_unlock_irqrestore (&priv->driver_lock, flags);
Signature · 1 line
2.25.1
Re: [PATCH 4/4] libertas: don't call kfree_skb() under spin_lock_irqsave() in lbs_mac_event_disconnected()
Hi,
thank you for your information.
On our website you can find email addresses of companies and people.
https://www.skymem.info
In short, it’s like Google for emails.
Best regards,
Robert,
Skymem team
Quoted 32 lines · Yang Yingliang
It is not allowed to call
kfree_skb()from hardware interrupt context or with interrupts being disabled. So replacekfree_skb()withdev_kfree_skb_irq()underspin_lock_irqsave().Fixes f52b041aed77 ("libertas: Add spinlock to avoid race condition")Signed-off-by Yang Yingliang <[email protected]>--- drivers/net/wireless/marvell/libertas/cmdresp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/wireless/marvell/libertas/cmdresp.c +1
-2@@ -48,7 +48,7 @@ void lbs_mac_event_disconnected(struct lbs_private *priv,/* Free Tx and Rx packets */ spin_lock_irqsave (&priv->driver_lock, flags); -kfree_skb (priv->currenttxskb); +dev_kfree_skb_irq (priv->currenttxskb); priv->currenttxskb =NULL ; priv->tx_pending_len =0 ;spin_unlock_irqrestore (&priv->driver_lock, flags); --2.25.1
_______________________________________________
libertas-dev mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/libertas-dev