spi: spi-fsl-lpspi: support multiple cs for lpspi
Subsystems (3)
PATCH 1/2 spi: spi-fsl-lpspi: support multiple cs for lpspi
support to get chip select number from DT file.
--- drivers/spi/spi-fsl-lpspi.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/spi/spi-fsl-lpspi.c +5 -0
@@ -98,6 +98,7 @@ struct fsl_lpspi_data {struct clk *clk_ipg;struct clk *clk_per;bool is_slave; +u32 num_cs;bool is_only_cs1;bool is_first_byte;
@@ -850,6 +851,9 @@ static int fsl_lpspi_probe(struct platform_device *pdev) fsl_lpspi->is_slave = is_slave; fsl_lpspi->is_only_cs1 =of_property_read_bool ((&pdev->dev)->of_node,"fsl,spi-only-use-cs1-sel" ); +if (of_property_read_u32 ((&pdev->dev)->of_node,"num-cs" , + &fsl_lpspi->num_cs)) + fsl_lpspi->num_cs =1 ; controller->bits_per_word_mask =SPI_BPW_RANGE_MASK (8 ,32 ); controller->transfer_one = fsl_lpspi_transfer_one;
@@ -859,6 +863,7 @@ static int fsl_lpspi_probe(struct platform_device *pdev) controller->flags =SPI_MASTER_MUST_RX |SPI_MASTER_MUST_TX ; controller->dev.of_node = pdev->dev.of_node; controller->bus_num = pdev->id; + controller->num_chipselect = fsl_lpspi->num_cs; controller->slave_abort = fsl_lpspi_slave_abort;if (!fsl_lpspi->is_slave) controller->use_gpio_descriptors = true;
Signature · 1 line
2.25.1
PATCH 2/2 dt-bindings: spi: spi-fsl-lpspi: add num-cs for lpspi
Add num-cs property to support multiple cs for lpspi. This property is optional.
--- Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)
Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml +8 -0
@@ -56,6 +56,13 @@ properties: this property to re-config the chipselect value in the LPSPI driver. type: boolean + num-cs: + description: + number of chip selects. + minimum: 1 + maximum: 2 + default: 1 + required: - compatible - reg
@@ -80,4 +87,5 @@ examples: clock-names = "per", "ipg"; spi-slave; fsl,spi-only-use-cs1-sel; + num-cs = <2>; };
Signature · 1 line
2.25.1
Re: [PATCH 2/2] dt-bindings: spi: spi-fsl-lpspi: add num-cs for lpspi
Quoted 13 lines · Han Xu
Add num-cs property to support multiple cs for lpspi. This property is optional.
Signed-off-by Han Xu <[email protected]>--- Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml | 8 ++++++++ 1 file changed, 8 insertions(+)Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml +0
-0
Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml properties: · line 61
Quoted 6 lines
Documentation/devicetree/bindings/spi/spi-fsl-lpspi.yaml +3
-0@@ -56,6 +56,13 @@ properties: this property to re-config the chipselect value in the LPSPI driver. type: boolean + num-cs: + description: + number of chip selects.
You do not need description, it's already in spi-controller.yaml.
Best regards,
Krzysztof
Hi,
Quoted 1 line · Han Xu
support to get chip select number from DT file.
In my humble opinion, a more elaborate commit message would help. You can add perhaps which DT node is to be set, like you might want to say,
support to get chip select number by Setting the value of num-cs in DT
or something on those lines.
Quoted 19 lines
Signed-off-by Han Xu <[email protected]>--- drivers/spi/spi-fsl-lpspi.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/spi/spi-fsl-lpspi.c +1
-0@@ -98,6 +98,7 @@ struct fsl_lpspi_data {struct clk *clk_ipg;struct clk *clk_per;bool is_slave; +u32 num_cs;bool is_only_cs1;bool is_first_byte;
drivers/spi/spi-fsl-lpspi.c static int fsl_lpspi_probe(struct platform_device *pdev) · line 854
Quoted 4 lines
drivers/spi/spi-fsl-lpspi.c +1
-0@@ -850,6 +851,9 @@ static int fsl_lpspi_probe(struct platform_device *pdev) fsl_lpspi->is_slave = is_slave; fsl_lpspi->is_only_cs1 =of_property_read_bool ((&pdev->dev)->of_node,"fsl,spi-only-use-cs1-sel" ); + if (of_property_read_u32((&pdev->dev)->of_node, "num-cs",
Running a checkpatch on this patch gave me the following,
CHECK: Unnecessary parentheses around '&pdev->dev' #36: FILE: drivers/spi/spi-fsl-lpspi.c:854:
+ if (of_property_read_u32((&pdev->dev)->of_node, "num-cs",
+ &fsl_lpspi->num_cs))
You might want to just do &pdev->dev->of_node instead
drivers/spi/spi-fsl-lpspi.c static int fsl_lpspi_probe(struct platform_device *pdev) · line 856
Quoted 2 lines
drivers/spi/spi-fsl-lpspi.c +2
-0+ &fsl_lpspi->num_cs)) + fsl_lpspi->num_cs =1 ;
I am not sure I understand why you are setting this to 1 here? I am assuming it is because you want num_cs to default to 1 if it is not specified in DT.
Please can you also add a dev_err and be sure to warn about this?
Also adding a comment or even a message inside dev err that you are setting this to 1 if it fails to get from DT would be helpful.
Quoted 11 lines
drivers/spi/spi-fsl-lpspi.c +1
-0controller->bits_per_word_mask =SPI_BPW_RANGE_MASK (8 ,32 ); controller->transfer_one = fsl_lpspi_transfer_one;@@ -859,6 +863,7 @@ static int fsl_lpspi_probe(struct platform_device *pdev) controller->flags =SPI_MASTER_MUST_RX |SPI_MASTER_MUST_TX ; controller->dev.of_node = pdev->dev.of_node; controller->bus_num = pdev->id; + controller->num_chipselect = fsl_lpspi->num_cs; controller->slave_abort = fsl_lpspi_slave_abort;if (!fsl_lpspi->is_slave) controller->use_gpio_descriptors = true;
Signature · 2 lines
Thanks and Regards, Dhruva Gole
Mark Brown
maintainerQuoted 9 lines · Dhruva Gole
drivers/spi/spi-fsl-lpspi.c static int fsl_lpspi_probe(struct platform_device *pdev) · line 856
Quoted 3 lines · Han Xu
support to get chip select number from DT file.
drivers/spi/spi-fsl-lpspi.c +1
-0+ fsl_lpspi->num_cs =1 ;I am not sure I understand why you are setting this to 1 here? I am assuming it is because you want
num_csto default to 1 if it is not specified in DT.Please can you also add a
dev_errand be sure to warn about this?
The binding says that this property is optional with a default of 1 so it should be totally fine for a system to not specify anything.
Mark Brown
maintainerQuoted 3 lines · Han Xu
support to get chip select number from DT file.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/2] spi: spi-fsl-lpspi: support multiple cs for lpspi
commit: 5f947746f0089529c85654704643f158b420ff92
[2/2] dt-bindings: spi: spi-fsl-lpspi: add num-cs for lpspi
commit: bc9ab1b7a6c687370b5d4edf34064bf04af8d369All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark