drm/virtio: use strscpy() to instead of strncpy()
Subsystems (3)
PATCH 1/1 drm/virtio: use strscpy() to instead of strncpy()
From: Xu Panda <[email protected]>
The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings.
Signed-off-by Xu Panda <[email protected]>
Signed-off-by Yang Yang <[email protected]>
--- drivers/gpu/drm/virtio/virtgpu_vq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/virtio/virtgpu_vq.c +1 -2
@@ -916,8 +916,7 @@ void virtio_gpu_cmd_context_create(struct virtio_gpu_device *vgdev, uint32_t id, cmd_p->hdr.ctx_id =cpu_to_le32 (id); cmd_p->nlen =cpu_to_le32 (nlen); cmd_p->context_init =cpu_to_le32 (context_init); -strncpy (cmd_p->debug_name, name,sizeof (cmd_p->debug_name) -1 ); - cmd_p->debug_name[sizeof (cmd_p->debug_name) -1 ] =0 ; +strscpy (cmd_p->debug_name, name,sizeof (cmd_p->debug_name));virtio_gpu_queue_ctrl_buffer (vgdev, vbuf); }
Signature · 1 line
2.15.2
Quoted 16 lines · On 12/7/22 04:13, [email protected] wrote:
From: Xu Panda <[email protected]>
The implementation of
strscpy()is more robust and safer. That's now the recommended way to copy NUL terminated strings.Signed-off-by Xu Panda <[email protected]>Signed-off-by Yang Yang <[email protected]>--- drivers/gpu/drm/virtio/virtgpu_vq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/gpu/drm/virtio/virtgpu_vq.c +0
-0
drivers/gpu/drm/virtio/virtgpu_vq.c void virtio_gpu_cmd_context_create(struct virtio_gpu_device *vgdev, uint32_t id, · line 922
Quoted 9 lines
drivers/gpu/drm/virtio/virtgpu_vq.c +1
-2@@ -916,8 +916,7 @@ void virtio_gpu_cmd_context_create(struct virtio_gpu_device *vgdev, uint32_t id, cmd_p->hdr.ctx_id =cpu_to_le32 (id); cmd_p->nlen =cpu_to_le32 (nlen); cmd_p->context_init =cpu_to_le32 (context_init); -strncpy (cmd_p->debug_name, name,sizeof (cmd_p->debug_name) -1 ); - cmd_p->debug_name[sizeof (cmd_p->debug_name) -1 ] =0 ; +strscpy (cmd_p->debug_name, name,sizeof (cmd_p->debug_name));virtio_gpu_queue_ctrl_buffer (vgdev, vbuf); }
Applied to misc-next
Signature · 2 lines
Best regards, Dmitry