Skip to contentSkip to conversation

iio: light: tsl2772: Convert to use sysfs_emit()/sysfs_emit_at() APIs

PATCH New [email protected] 1 participant 1 message Dec 7, 2022 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: light: tsl2772: Convert to use sysfs_emit()/sysfs_emit_at() APIs

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

---
 drivers/iio/light/tsl2772.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/iio/light/tsl2772.c +5 -5
index ad50baa0202c..03cae6a536b4 100644
@@ -927,7 +927,7 @@ static ssize_t in_illuminance0_target_input_show(struct device *dev,
 {
 	struct tsl2772_chip *chip = iio_priv(dev_to_iio_dev(dev));
 
-	return scnprintf(buf, PAGE_SIZE, "%d\n", chip->settings.als_cal_target);
+	return sysfs_emit(buf, "%d\n", chip->settings.als_cal_target);
 }
 
 static ssize_t in_illuminance0_target_input_store(struct device *dev,
@@ -981,9 +981,9 @@ static ssize_t in_illuminance0_lux_table_show(struct device *dev,
 	int offset = 0;
 
 	while (i < TSL2772_MAX_LUX_TABLE_SIZE) {
-		offset += scnprintf(buf + offset, PAGE_SIZE - offset, "%u,%u,",
-			chip->tsl2772_device_lux[i].ch0,
-			chip->tsl2772_device_lux[i].ch1);
+		offset += sysfs_emit_at(buf, offset, "%u,%u,",
+					chip->tsl2772_device_lux[i].ch0,
+					chip->tsl2772_device_lux[i].ch1);
 		if (chip->tsl2772_device_lux[i].ch0 == 0) {
 			/*
 			 * We just printed the first "0" entry.
@@ -995,7 +995,7 @@ static ssize_t in_illuminance0_lux_table_show(struct device *dev,
 		i++;
 	}
 
-	offset += scnprintf(buf + offset, PAGE_SIZE - offset, "\n");
+	offset += sysfs_emit_at(buf, offset, "\n");
 	return offset;
 }
 
Signature · 1 line
2.25.1