Skip to contentSkip to conversation

iio: magnetometer: bmc150_magn: Convert to use sysfs_emit_at() API

PATCH In review [email protected] 3 participants 3 messages Dec 7, 2022 – Dec 11, 2022 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: magnetometer: bmc150_magn: Convert to use sysfs_emit_at() API

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

---
 drivers/iio/magnetometer/bmc150_magn.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/magnetometer/bmc150_magn.c +1 -2
index 06d5a1ef1fbd..1398684a7f30 100644
@@ -598,8 +598,7 @@ static ssize_t bmc150_magn_show_samp_freq_avail(struct device *dev,
 	for (i = 0; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); i++) {
 		if (bmc150_magn_samp_freq_table[i].freq > data->max_odr)
 			break;
-		len += scnprintf(buf + len, PAGE_SIZE - len, "%d ",
-				 bmc150_magn_samp_freq_table[i].freq);
+		len += sysfs_emit_at(buf, len, "%d ", bmc150_magn_samp_freq_table[i].freq);
 	}
 	/* replace last space with a newline */
 	buf[len - 1] = '\n';
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · On Wed, Dec 7, 2022 at 9:49 AM <[email protected]> wrote:

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

Quoted 21 lines
---
 drivers/iio/magnetometer/bmc150_magn.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/iio/magnetometer/bmc150_magn.c +1 -3
index 06d5a1ef1fbd..1398684a7f30 100644
@@ -598,8 +598,7 @@ static ssize_t bmc150_magn_show_samp_freq_avail(struct device *dev,
        for (i = 0; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); i++) {
                if (bmc150_magn_samp_freq_table[i].freq > data->max_odr)
                        break;
-               len += scnprintf(buf + len, PAGE_SIZE - len, "%d ",
-                                bmc150_magn_samp_freq_table[i].freq);
+               len += sysfs_emit_at(buf, len, "%d ", bmc150_magn_samp_freq_table[i].freq);
        }
        /* replace last space with a newline */
        buf[len - 1] = '\n';
--

2.25.1

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#2 lore raw
Quoted 15 lines · On Wed, 7 Dec 2022 10:46:14 +0200 Andy Shevchenko <[email protected]>…
Quoted 6 lines · On Wed, Dec 7, 2022 at 9:49 AM <[email protected]> wrote:

From: ye xingchen <[email protected]>

Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.

Quoted 5 lines
---
 drivers/iio/magnetometer/bmc150_magn.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Quoted 12 lines

drivers/iio/magnetometer/bmc150_magn.c static ssize_t bmc150_magn_show_samp_freq_avail(struct device *dev, · line 602

Quoted 12 lines
drivers/iio/magnetometer/bmc150_magn.c +1 -2
index 06d5a1ef1fbd..1398684a7f30 100644
@@ -598,8 +598,7 @@ static ssize_t bmc150_magn_show_samp_freq_avail(struct device *dev,
        for (i = 0; i < ARRAY_SIZE(bmc150_magn_samp_freq_table); i++) {
                if (bmc150_magn_samp_freq_table[i].freq > data->max_odr)
                        break;
-               len += scnprintf(buf + len, PAGE_SIZE - len, "%d ",
-                                bmc150_magn_samp_freq_table[i].freq);
+               len += sysfs_emit_at(buf, len, "%d ", bmc150_magn_samp_freq_table[i].freq);
        }

I'd prefer we keep the line break before the last parameter.

Generally in IIO at least, preference is for < 80 chars except where readability is significantly enhanced by a longer line. That's not true in this case.

Jonathan

Quoted 7 lines
Quoted 4 lines
drivers/iio/magnetometer/bmc150_magn.c +0 -1
        /* replace last space with a newline */
        buf[len - 1] = '\n';
--

2.25.1