net: ethernet: use strscpy() to instead of strncpy()
PATCH 1/1 net: ethernet: use strscpy() to instead of strncpy()
From: Xu Panda <[email protected]>
The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings.
Signed-off-by Xu Panda <[email protected]>
Signed-off-by Yang Yang <[email protected]>
--- drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ethernet/myricom/myri10ge/myri10ge.c +1 -2
@@ -552,8 +552,7 @@ myri10ge_validate_firmware(struct myri10ge_priv *mgp, }/* save firmware version for ethtool */ -strncpy (mgp->fw_version, hdr->version,sizeof (mgp->fw_version)); - mgp->fw_version[sizeof (mgp->fw_version) -1 ] ='\0' ; +strscpy (mgp->fw_version, hdr->version,sizeof (mgp->fw_version));sscanf (mgp->fw_version,"%d.%d.%d" , &mgp->fw_ver_major, &mgp->fw_ver_minor, &mgp->fw_ver_tiny);
Signature · 1 line
2.15.2
Quoted 7 lines · On Thu, Dec 08, 2022 at 07:52:03PM +0800, [email protected] wrote:
From: Xu Panda <[email protected]>
The implementation of
strscpy()is more robust and safer. That's now the recommended way to copy NUL terminated strings.Signed-off-by Xu Panda <[email protected]>Signed-off-by Yang Yang <[email protected]>
This change looks good to me, but I think the subject should be:
[PATCH net-next] myri10ge: use strscpy() to instead of strncpy()
That not withstanding,
Reviewed-by Simon Horman <[email protected]>