fs: ext4: Fix free(NULL) The 'depth_dirname', 'ptr', 'parent_inode' and 'first_inode' pointers may be null. Thus, it is necessary to check them before using free() to avoid free(NULL) cases.
PATCH 1/1 fs: ext4: Fix free(NULL) The 'depth_dirname', 'ptr', 'parent_inode' and 'first_inode' pointers may be null. Thus, it is necessary to check them before using free() to avoid free(NULL) cases.
Fixes 934b14f2bb30 ("ext4: free allocations by parse_path()")
Signed-off-by Mikhail Ilin <[email protected]>
--- fs/ext4/ext4_common.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-)
fs/ext4/ext4_common.c +13 -8
@@ -847,15 +847,20 @@ end: fail:free (depth_dirname); -free (parse_dirname); -for (i =0 ; i < depth; i++) { -if (!ptr[i]) -break ; -free (ptr[i]); +if (parse_dirname) +free (parse_dirname); +if (ptr) { +for (i =0 ; i < depth; i++) { +if (!ptr[i]) +break ; +free (ptr[i]); + } +free (ptr); } -free (ptr); -free (parent_inode); -free (first_inode); +if (parent_inode) +free (parent_inode); +if (first_inode) +free (first_inode);return result_inode_no; }
Signature · 1 line
2.17.1
Quoted 2 lines · Mikhail Ilin
Fixes 934b14f2bb30 ("ext4: free allocations by parse_path()")Signed-off-by Mikhail Ilin <[email protected]>
Applied to u-boot/next, thanks!
Signature · 1 line
Tom