Skip to contentSkip to conversation

acpi: add support for the NBFT

PATCH In review Stuart Hayes 3 participants 4 messages Dec 8, 2022 – Jan 12, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 acpi: add support for the NBFT

Add support for the NVMe Boot Firmware Table (NBFT) to facilitate booting from NVM Express namespaces which are accessed via NVMe over Fabrics (NVMe-oF).

---
 drivers/acpi/tables.c | 3 ++-
 include/acpi/actbl1.h | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)
drivers/acpi/tables.c +2 -1
index 47ec11d4c68e..f390c5883b56 100644
@@ -545,7 +545,8 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
 	ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
 	ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
 	ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
-	ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI };
+	ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI,
+	ACPI_SIG_NBFT };
 
 #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
 
include/acpi/actbl1.h +2 -0
index 15c78678c5d3..6ec43410288a 100644
@@ -49,6 +49,8 @@
 #define ACPI_SIG_S3PT           "S3PT"	/* S3 Performance (sub)Table */
 #define ACPI_SIG_PCCS           "PCC"	/* PCC Shared Memory Region */
 
+#define ACPI_SIG_NBFT		"NBFT"	/* NVMe Boot Firmware Table */
+
 /* Reserved table signatures */
 
 #define ACPI_SIG_MATR           "MATR"	/* Memory Address Translation Table */
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 39 lines · Stuart Hayes

Add support for the NVMe Boot Firmware Table (NBFT) to facilitate booting from NVM Express namespaces which are accessed via NVMe over Fabrics (NVMe-oF).

---
  drivers/acpi/tables.c | 3 ++-
  include/acpi/actbl1.h | 2 ++
  2 files changed, 4 insertions(+), 1 deletion(-)
drivers/acpi/tables.c +2 -1
index 47ec11d4c68e..f390c5883b56 100644
@@ -545,7 +545,8 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
  	ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
  	ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
  	ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
-	ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI };
+	ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI,
+	ACPI_SIG_NBFT };
 
  #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
 
include/acpi/actbl1.h +2 -0
index 15c78678c5d3..6ec43410288a 100644
@@ -49,6 +49,8 @@
  #define ACPI_SIG_S3PT           "S3PT"	/* S3 Performance (sub)Table */
  #define ACPI_SIG_PCCS           "PCC"	/* PCC Shared Memory Region */
 
+#define ACPI_SIG_NBFT		"NBFT"	/* NVMe Boot Firmware Table */
+
  /* Reserved table signatures */
 
  #define ACPI_SIG_MATR           "MATR"	/* Memory Address Translation Table */
#2 lore raw
In reply to Stuart Hayes
Quoted 6 lines · Stuart Hayes

Add support for the NVMe Boot Firmware Table (NBFT) to facilitate booting from NVM Express namespaces which are accessed via NVMe over Fabrics (NVMe-oF).

Tentatively applied as 6.3 material, but it was unclear what the S-o-b tags below mean, so I've dropped them.

If you are not the original author of the patch, you should add a From line pointing to the original author to it and the corresponding S-o-b tag along with your S-o-b.

If you have developed the patch in collaboration with someone, there should be a Co-developed-by tag pointing to the other author along with the corresponding S-o-b tag.

S-o-b alone is meaningful only if you are sending a patch from someone else, for example as a code maintainer.

Quoted 37 lines
---
 drivers/acpi/tables.c | 3 ++-
 include/acpi/actbl1.h | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)
drivers/acpi/tables.c +2 -1
index 47ec11d4c68e..f390c5883b56 100644
@@ -545,7 +545,8 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
        ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
        ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
        ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
-       ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI };
+       ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI,
+       ACPI_SIG_NBFT };
 
 #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
 
include/acpi/actbl1.h +2 -1
index 15c78678c5d3..6ec43410288a 100644
@@ -49,6 +49,8 @@
 #define ACPI_SIG_S3PT           "S3PT" /* S3 Performance (sub)Table */
 #define ACPI_SIG_PCCS           "PCC"  /* PCC Shared Memory Region */
 
+#define ACPI_SIG_NBFT          "NBFT"  /* NVMe Boot Firmware Table */
+
 /* Reserved table signatures */
 
 #define ACPI_SIG_MATR           "MATR" /* Memory Address Translation Table */
--

2.31.1

#3 lore raw

Thank Rafael.

To clarify: this patch was developed by Stuart Hayes. So there should be no need for that additional Signed-off-bys.

Sorry for the confusion...

John A. Meneghini
Senior Principal Platform Storage Engineer
RHEL SST - Platform Storage Group
[email protected]

Quoted 60 lines · Rafael J. Wysocki
Quoted 6 lines · Stuart Hayes

Add support for the NVMe Boot Firmware Table (NBFT) to facilitate booting from NVM Express namespaces which are accessed via NVMe over Fabrics (NVMe-oF).

Tentatively applied as 6.3 material, but it was unclear what the S-o-b tags below mean, so I've dropped them.

If you are not the original author of the patch, you should add a From line pointing to the original author to it and the corresponding S-o-b tag along with your S-o-b.

If you have developed the patch in collaboration with someone, there should be a Co-developed-by tag pointing to the other author along with the corresponding S-o-b tag.

S-o-b alone is meaningful only if you are sending a patch from someone else, for example as a code maintainer.

Quoted 37 lines
---
  drivers/acpi/tables.c | 3 ++-
  include/acpi/actbl1.h | 2 ++
  2 files changed, 4 insertions(+), 1 deletion(-)
drivers/acpi/tables.c +2 -1
index 47ec11d4c68e..f390c5883b56 100644
@@ -545,7 +545,8 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
         ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
         ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
         ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
-       ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI };
+       ACPI_SIG_NHLT, ACPI_SIG_AEST, ACPI_SIG_CEDT, ACPI_SIG_AGDI,
+       ACPI_SIG_NBFT };
 
  #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
 
include/acpi/actbl1.h +2 -1
index 15c78678c5d3..6ec43410288a 100644
@@ -49,6 +49,8 @@
  #define ACPI_SIG_S3PT           "S3PT" /* S3 Performance (sub)Table */
  #define ACPI_SIG_PCCS           "PCC"  /* PCC Shared Memory Region */
 
+#define ACPI_SIG_NBFT          "NBFT"  /* NVMe Boot Firmware Table */
+
  /* Reserved table signatures */
 
  #define ACPI_SIG_MATR           "MATR" /* Memory Address Translation Table */
--

2.31.1