liquidio: use strscpy() to instead of strncpy()
Subsystems (3)
PATCH v2 1/1 liquidio: use strscpy() to instead of strncpy()
From: Xu Panda <[email protected]>
The implementation of strscpy() is more robust and safer. That's now the recommended way to copy NUL terminated strings.
Signed-off-by Xu Panda <[email protected]>
Signed-off-by Yang Yang <[email protected]>
---
change for v2
- change the subject, replace linux-next with net-next.
--- drivers/net/ethernet/cavium/liquidio/octeon_console.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/net/ethernet/cavium/liquidio/octeon_console.c +3 -4
@@ -247,8 +247,7 @@ static const struct cvmx_bootmem_named_block_desc struct cvmx_bootmem_named_block_desc, size)); -strncpy (desc->name, name,sizeof (desc->name)); - desc->name[sizeof (desc->name) -1 ] =0 ; +strscpy (desc->name, name,sizeof (desc->name));return &oct->bootmem_named_block_desc; }else {return NULL ;
@@ -471,8 +470,8 @@ static void output_console_line(struct octeon_device *oct,if (line != &console_buffer[bytes_read]) { console_buffer[bytes_read] ='\0' ; len =strlen (console->leftover); -strncpy (&console->leftover[len], line, -sizeof (console->leftover) - len); +strscpy (&console->leftover[len], line, +sizeof (console->leftover) - len +1 ); } }
Signature · 1 line
2.15.2
Quoted 7 lines · Fri, Dec 09, 2022 at 08:34:49AM CET, [email protected] wrote:
From: Xu Panda <[email protected]>
The implementation of
strscpy()is more robust and safer. That's now the recommended way to copy NUL terminated strings.Signed-off-by Xu Panda <[email protected]>Signed-off-by Yang Yang <[email protected]>
Reviewed-by Jiri Pirko <[email protected]>