Skip to contentSkip to conversation

net: ipa: Remove redundant dev_err()

PATCH In review Kang Minchul 2 participants 3 messages Dec 12, 2022 – Dec 16, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: ipa: Remove redundant dev_err()

Function dev_err() is redundant because platform_get_irq_byname() already prints an error.

Also, platform_get_irq_byname() can't return 0 so ret <= 0 should be ret < 0.

---
Changes in v2:
- Annotate patch with net-next.
- Remove unnecessary comparison with zero.

 drivers/net/ipa/gsi.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/net/ipa/gsi.c +1 -4
index 55226b264e3c..a4f19f7f188e 100644
@@ -1967,11 +1967,8 @@ int gsi_init(struct gsi *gsi, struct platform_device *pdev, bool prefetch,
 
 	/* Get the GSI IRQ and request for it to wake the system */
 	ret = platform_get_irq_byname(pdev, "gsi");
-	if (ret <= 0) {
-		dev_err(gsi->dev,
-			"DT error %d getting \"gsi\" IRQ property\n", ret);
+	if (ret < 0)
 		return ret ? : -EINVAL;
-	}
 	irq = ret;
 
 	ret = request_irq(irq, gsi_isr, 0, "gsi", gsi);
Signature · 1 line
2.34.1
#1 lore raw
Quoted 7 lines · Kang Minchul

Function dev_err() is redundant because platform_get_irq_byname() already prints an error.

Also, platform_get_irq_byname() can't return 0 so ret <= 0 should be ret < 0.

Now that I've looked at this closely, it's not clear what version of the code you are basing your patch on.

The current version of net-next/master, as well as the current linus/master, do not include the message you are removing. This patch removed the message more than a year ago:

91306d1d131ee net: ipa: Remove useless error message

So at least the portion of your patch that removes the message is unnecessary.

Meanwhile, it seems there is no need to check for a 0 return from platform_get_irq_byname(), but there is no harm in doing so.

If you would like to send version 3 of this patch, which would return what platform_get_irq_byname() returns if it is less than 0 in gsi_irq_init(), I would be OK with that.

But please it on net-next/master.

Thanks.

-Alex

Quoted 25 lines

---
Changes in v2:
- Annotate patch with net-next.
- Remove unnecessary comparison with zero.

  drivers/net/ipa/gsi.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)
drivers/net/ipa/gsi.c +1 -4
index 55226b264e3c..a4f19f7f188e 100644
@@ -1967,11 +1967,8 @@ int gsi_init(struct gsi *gsi, struct platform_device *pdev, bool prefetch,
 
  	/* Get the GSI IRQ and request for it to wake the system */
  	ret = platform_get_irq_byname(pdev, "gsi");
-	if (ret <= 0) {
-		dev_err(gsi->dev,
-			"DT error %d getting \"gsi\" IRQ property\n", ret);
+	if (ret < 0)
  		return ret ? : -EINVAL;
-	}
  	irq = ret;
 
  	ret = request_irq(irq, gsi_isr, 0, "gsi", gsi);
#2 lore raw

Thank you for your precious feedback.

Quoted 9 lines

The current version of net-next/master, as well as the current linus/master, do not include the message you are removing. This patch removed the message more than a year ago:

91306d1d131ee net: ipa: Remove useless error message

So at least the portion of your patch that removes the message is unnecessary.

Yes, I think I mistakenly worked on the wrong branch..

Quoted 9 lines

Meanwhile, it seems there is no need to check for a 0 return from platform_get_irq_byname(), but there is no harm in doing so.

If you would like to send version 3 of this patch, which would return what platform_get_irq_byname() returns if it is less than 0 in gsi_irq_init(), I would be OK with that.

But please it on net-next/master.

Ok, I'll send v3 of this patch soon.