Skip to contentSkip to conversation

tools: tests: remove leftover echo

PATCH In review Bartosz Golaszewski 2 participants 2 messages Dec 12, 2022 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools: tests: remove leftover echo

From: Bartosz Golaszewski <[email protected]>

This looks like some unneeded leftover from the development that was missed because bats intercepts all echo output.

---
 tools/gpio-tools-test.bats | 1 -
 1 file changed, 1 deletion(-)
tools/gpio-tools-test.bats +0 -1
index bf7f3d6..adbce94 100755
@@ -392,7 +392,6 @@ request_release_line() {
 
 	run_tool gpioinfo
 
-    echo "$output"
 	output_contains_line "${GPIOSIM_CHIP_NAME[sim0]} - 4 lines:"
 	output_contains_line "${GPIOSIM_CHIP_NAME[sim1]} - 8 lines:"
 	output_regex_match "\\s+line\\s+0:\\s+unnamed\\s+input"
Signature · 1 line
2.37.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This looks like some unneeded leftover from the development that was missed because bats intercepts all echo output.

Indeed - you only see it when a test fails, and I obviously missed removing it after getting the offending test to pass.

Quoted 20 lines
---
 tools/gpio-tools-test.bats | 1 -
 1 file changed, 1 deletion(-)
tools/gpio-tools-test.bats +0 -1
index bf7f3d6..adbce94 100755
@@ -392,7 +392,6 @@ request_release_line() {
 
 	run_tool gpioinfo
 
-    echo "$output"
 	output_contains_line "${GPIOSIM_CHIP_NAME[sim0]} - 4 lines:"
 	output_contains_line "${GPIOSIM_CHIP_NAME[sim1]} - 8 lines:"
 	output_regex_match "\\s+line\\s+0:\\s+unnamed\\s+input"
Signature · 1 line
2.37.2