Skip to contentSkip to conversation

Configs: enable gigadevice xilinx_zynqmp_mini_qspi_defconfig

PATCH In review Victor Lim 2 participants 6 messages Dec 12, 2022 – Dec 13, 2022 Arm/Zynq architecture

lore
Share & tools
lore

Victor Lim

author
#0 lore raw

PATCH v2 1/1 Configs: enable gigadevice xilinx_zynqmp_mini_qspi_defconfig

enabling gigadevice in this file

---
 configs/xilinx_zynqmp_mini_qspi_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/xilinx_zynqmp_mini_qspi_defconfig +1 -0
index c6401c2a54..2171d09fc3 100644
@@ -69,6 +69,7 @@ CONFIG_SPI_FLASH_MACRONIX=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
+CONFIG_SPI_FLASH_GIGADEVICE=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
 # CONFIG_POWER is not set
 CONFIG_ARM_DCC=y
Signature · 1 line
2.25.1
#1 lore raw

Hi Victor,

po 12. 12. 2022 v 15:50 odesílatel Victor Lim <[email protected]> napsal:

Quoted 2 lines

enabling gigadevice in this file

it is quite clear that you are changing it in this file not another one. Remove it.

And send it as a series because I really don't want to pick it up one by one when we have b4
and can download all of them together.

Thanks,
Michal

Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
author
#2 lore raw

Hi, Michal,

Do you mean group a few files in to one patch?

Regards,

Victor

Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Michal Simek <[email protected]>
Sent: Monday, December 12, 2022 10:58:00 PM
To: Vlim <[email protected]>
Cc: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: Re: [PATCH V2 1/1] Configs: enable gigadevice xilinx_zynqmp_mini_qspi_defconfig

此为外部邮件,谨防钓鱼邮件,请注意邮件是否涉及敏感信息

This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information

Hi Victor,

po 12. 12. 2022 v 15:50 odesílatel Victor Lim <[email protected]> napsal:

Quoted 2 lines

enabling gigadevice in this file

it is quite clear that you are changing it in this file not another one. Remove it.

And send it as a series because I really don't want to pick it up one by one when we have b4
and can download all of them together.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: https://apc01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.monstr.eu%2F&amp;data=05%7C01%7Cvlim%40gigadevice.com%7C6bb31077525c42d9ad9c08dadc514ae1%7Cf84ba339959c4ab19b671e43414f945e%7C0%7C0%7C638064538983434499%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000%7C%7C%7C&amp;sdata=%2BA3kGtoOST4zkZ0hCpiCiU5D9Zlm%2BzHpmVxpfs1Llj0%3D&amp;reserved=0 p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs

#3 lore raw

Hi,

first of all no top posting.

po 12. 12. 2022 v 16:07 odesílatel Vlim <[email protected]> napsal:

Quoted 4 lines

Hi, Michal,

Do you mean group a few files in to one patch?

I am fine with one patch per SOC but up2you.
But definitely send it as series with --thread with cover letter.

Thanks,
Michal

author
#4 lore raw

Hi, Michal,

Sorry, what is top posting?

Regards,

Victor

Get Outlook for Android<https://aka.ms/AAb9ysg>

________________________________
From: Michal Simek <[email protected]>
Sent: Tuesday, December 13, 2022, 12:08 AM
To: Vlim <[email protected]>
Cc: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>
Subject: Re: [PATCH V2 1/1] Configs: enable gigadevice xilinx_zynqmp_mini_qspi_defconfig

此为外部邮件,谨防钓鱼邮件,请注意邮件是否涉及敏感信息

This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information

Hi,

first of all no top posting.

po 12. 12. 2022 v 16:07 odesílatel Vlim <[email protected]> napsal:

Quoted 4 lines

Hi, Michal,

Do you mean group a few files in to one patch?

I am fine with one patch per SOC but up2you.
But definitely send it as series with --thread with cover letter.

Thanks,
Michal

#5 lore raw

po 12. 12. 2022 v 23:48 odesílatel Vlim <[email protected]> napsal:

Quoted 4 lines

Hi, Michal,

Sorry, what is top posting?

Take a look
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/2.Process.rst?h=v6.1#n437

Thanks,
Michal

Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs