Skip to contentSkip to conversation

drm/i915/migrate: fix corner case in CCS aux copying

PATCH In review Matthew Auld 3 participants 7 messages Dec 12, 2022 – Dec 13, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/i915/migrate: fix corner case in CCS aux copying

In the case of lmem -> lmem transfers, which is currently only possible with small-bar systems, we need to ensure we copy the CCS aux state as-is, rather than nuke it. This should fix some nasty display corruption sometimes seen on DG2 small-bar systems, when also using DG2_RC_CCS_CC for the surface.

Fixes e3afc690188b ("drm/i915/display: consider DG2_RC_CCS_CC when migrating buffers")
Cc Ville Syrjälä <[email protected]>
Cc Nirmoy Das <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Shuicheng Lin <[email protected]>
---
 drivers/gpu/drm/i915/gt/intel_migrate.c | 37 +++++++++++++++++++------
 1 file changed, 29 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/gt/intel_migrate.c +29 -8
index e08a739b7091..3f638f198796 100644
@@ -839,14 +839,35 @@ intel_context_migrate_copy(struct intel_context *ce,
 			if (err)
 				goto out_rq;
 
-			/*
-			 * While we can't always restore/manage the CCS state,
-			 * we still need to ensure we don't leak the CCS state
-			 * from the previous user, so make sure we overwrite it
-			 * with something.
-			 */
-			err = emit_copy_ccs(rq, dst_offset, INDIRECT_ACCESS,
-					    dst_offset, DIRECT_ACCESS, len);
+			if (src_is_lmem) {
+				/*
+				 * If the src is already in lmem, then we must
+				 * be doing an lmem -> lmem transfer, and so
+				 * should be safe to directly copy the CCS
+				 * state. In this case we have either
+				 * initialised the CCS aux state when first
+				 * clearing the pages (since it is already
+				 * allocated in lmem), or the user has
+				 * potentially populated it, in which case we
+				 * need to copy the CCS state as-is.
+				 */
+				err = emit_copy_ccs(rq,
+						    dst_offset, INDIRECT_ACCESS,
+						    src_offset, INDIRECT_ACCESS,
+						    len);
+			} else {
+				/*
+				 * While we can't always restore/manage the CCS
+				 * state, we still need to ensure we don't leak
+				 * the CCS state from the previous user, so make
+				 * sure we overwrite it with something.
+				 */
+				err = emit_copy_ccs(rq,
+						    dst_offset, INDIRECT_ACCESS,
+						    dst_offset, DIRECT_ACCESS,
+						    len);
+			}
+
 			if (err)
 				goto out_rq;
 
Signature · 1 line
2.38.1
#1 lore raw

PATCH 2/2 drm/i915/ttm: consider CCS for backup objects

It seems we can have one or more framebuffers that are still pinned when suspending lmem, in such a case we end up creating a shmem backup object, instead of evicting the object directly, but this will skip copying the CCS aux state, since we don't allocate the extra storage for the CCS pages as part of the ttm_tt construction. Since we can already deal with pinned objects just fine, it doesn't seem too nasty to just extend to support dealing with the CCS aux state, if the object is a pinned framebuffer. This fixes display corruption (like in gnome-shell) seen on DG2 when returning from suspend.

Fixes da0595ae91da ("drm/i915/migrate: Evict and restore the flatccs capable lmem obj")
Cc Ville Syrjälä <[email protected]>
Cc Nirmoy Das <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Shuicheng Lin <[email protected]>
Cc <[email protected]> # v5.19+
---
 drivers/gpu/drm/i915/gem/i915_gem_object.c     |  3 +++
 .../gpu/drm/i915/gem/i915_gem_object_types.h   | 10 ++++++----
 drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c     | 18 +++++++++++++++++-
 3 files changed, 26 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_object.c +3 -0
index 733696057761..1a0886b8aaa1 100644
@@ -785,6 +785,9 @@ bool i915_gem_object_needs_ccs_pages(struct drm_i915_gem_object *obj)
 	if (!HAS_FLAT_CCS(to_i915(obj->base.dev)))
 		return false;
 
+	if (obj->flags & I915_BO_ALLOC_CCS_AUX)
+		return true;
+
 	for (i = 0; i < obj->mm.n_placements; i++) {
 		/* Compression is not allowed for the objects with smem placement */
 		if (obj->mm.placements[i]->type == INTEL_MEMORY_SYSTEM)
drivers/gpu/drm/i915/gem/i915_gem_object_types.h +6 -4
index a7b70701617a..19c9bdd8f905 100644
@@ -327,16 +327,18 @@ struct drm_i915_gem_object {
  * dealing with userspace objects the CPU fault handler is free to ignore this.
  */
 #define I915_BO_ALLOC_GPU_ONLY	  BIT(6)
+#define I915_BO_ALLOC_CCS_AUX	  BIT(7)
 #define I915_BO_ALLOC_FLAGS (I915_BO_ALLOC_CONTIGUOUS | \
 			     I915_BO_ALLOC_VOLATILE | \
 			     I915_BO_ALLOC_CPU_CLEAR | \
 			     I915_BO_ALLOC_USER | \
 			     I915_BO_ALLOC_PM_VOLATILE | \
 			     I915_BO_ALLOC_PM_EARLY | \
-			     I915_BO_ALLOC_GPU_ONLY)
-#define I915_BO_READONLY          BIT(7)
-#define I915_TILING_QUIRK_BIT     8 /* unknown swizzling; do not release! */
-#define I915_BO_PROTECTED         BIT(9)
+			     I915_BO_ALLOC_GPU_ONLY | \
+			     I915_BO_ALLOC_CCS_AUX)
+#define I915_BO_READONLY          BIT(8)
+#define I915_TILING_QUIRK_BIT     9 /* unknown swizzling; do not release! */
+#define I915_BO_PROTECTED         BIT(10)
 	/**
 	 * @mem_flags - Mutable placement-related flags
 	 *
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c +17 -1
index 07e49f22f2de..7e67742bc65e 100644
@@ -50,6 +50,7 @@ static int i915_ttm_backup(struct i915_gem_apply_to_region *apply,
 		container_of(bo->bdev, typeof(*i915), bdev);
 	struct drm_i915_gem_object *backup;
 	struct ttm_operation_ctx ctx = {};
+	unsigned int flags;
 	int err = 0;
 
 	if (bo->resource->mem_type == I915_PL_SYSTEM || obj->ttm.backup)
@@ -65,7 +66,22 @@ static int i915_ttm_backup(struct i915_gem_apply_to_region *apply,
 	if (obj->flags & I915_BO_ALLOC_PM_VOLATILE)
 		return 0;
 
-	backup = i915_gem_object_create_shmem(i915, obj->base.size);
+	/*
+	 * It seems that we might have some framebuffers still pinned at this
+	 * stage, but for such objects we might also need to deal with the CCS
+	 * aux state. Make sure we force the save/restore of the CCS state,
+	 * otherwise we might observe display corruption, when returning from
+	 * suspend.
+	 */
+	flags = 0;
+	if (i915_gem_object_needs_ccs_pages(obj)) {
+		WARN_ON_ONCE(!i915_gem_object_is_framebuffer(obj));
+		WARN_ON_ONCE(!pm_apply->allow_gpu);
+
+		flags = I915_BO_ALLOC_CCS_AUX;
+	}
+	backup = i915_gem_object_create_region(i915->mm.regions[INTEL_REGION_SMEM],
+					       obj->base.size, 0, flags);
 	if (IS_ERR(backup))
 		return PTR_ERR(backup);
 
Signature · 1 line
2.38.1
Tested-by Nirmoy Das Reviewed-by Nirmoy Das on v1 2/2
#2 lore raw

Re: [Intel-gfx] [PATCH 2/2] drm/i915/ttm: consider CCS for backup objects

Quoted 9 lines · Matthew Auld

It seems we can have one or more framebuffers that are still pinned when suspending lmem, in such a case we end up creating a shmem backup object, instead of evicting the object directly, but this will skip copying the CCS aux state, since we don't allocate the extra storage for the CCS pages as part of the ttm_tt construction. Since we can already deal with pinned objects just fine, it doesn't seem too nasty to just extend to support dealing with the CCS aux state, if the object is a pinned framebuffer. This fixes display corruption (like in gnome-shell) seen on DG2 when returning from suspend.

This patch fixes resume corruption with full-bar as well, tested with sway.

Thanks,

Nirmoy

Quoted 91 lines
Fixes da0595ae91da ("drm/i915/migrate: Evict and restore the flatccs capable lmem obj")
Cc Ville Syrjälä <[email protected]>
Cc Nirmoy Das <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Shuicheng Lin <[email protected]>
Cc <[email protected]> # v5.19+
---
  drivers/gpu/drm/i915/gem/i915_gem_object.c     |  3 +++
  .../gpu/drm/i915/gem/i915_gem_object_types.h   | 10 ++++++----
  drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c     | 18 +++++++++++++++++-
  3 files changed, 26 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_object.c +3 -0
index 733696057761..1a0886b8aaa1 100644
@@ -785,6 +785,9 @@ bool i915_gem_object_needs_ccs_pages(struct drm_i915_gem_object *obj)
  	if (!HAS_FLAT_CCS(to_i915(obj->base.dev)))
  		return false;
 
+	if (obj->flags & I915_BO_ALLOC_CCS_AUX)
+		return true;
+
  	for (i = 0; i < obj->mm.n_placements; i++) {
  		/* Compression is not allowed for the objects with smem placement */
  		if (obj->mm.placements[i]->type == INTEL_MEMORY_SYSTEM)
drivers/gpu/drm/i915/gem/i915_gem_object_types.h +6 -4
index a7b70701617a..19c9bdd8f905 100644
@@ -327,16 +327,18 @@ struct drm_i915_gem_object {
   * dealing with userspace objects the CPU fault handler is free to ignore this.
   */
  #define I915_BO_ALLOC_GPU_ONLY	  BIT(6)
+#define I915_BO_ALLOC_CCS_AUX	  BIT(7)
  #define I915_BO_ALLOC_FLAGS (I915_BO_ALLOC_CONTIGUOUS | \
  			     I915_BO_ALLOC_VOLATILE | \
  			     I915_BO_ALLOC_CPU_CLEAR | \
  			     I915_BO_ALLOC_USER | \
  			     I915_BO_ALLOC_PM_VOLATILE | \
  			     I915_BO_ALLOC_PM_EARLY | \
-			     I915_BO_ALLOC_GPU_ONLY)
-#define I915_BO_READONLY          BIT(7)
-#define I915_TILING_QUIRK_BIT     8 /* unknown swizzling; do not release! */
-#define I915_BO_PROTECTED         BIT(9)
+			     I915_BO_ALLOC_GPU_ONLY | \
+			     I915_BO_ALLOC_CCS_AUX)
+#define I915_BO_READONLY          BIT(8)
+#define I915_TILING_QUIRK_BIT     9 /* unknown swizzling; do not release! */
+#define I915_BO_PROTECTED         BIT(10)
  	/**
  	 * @mem_flags - Mutable placement-related flags
  	 *
drivers/gpu/drm/i915/gem/i915_gem_ttm_pm.c +17 -1
index 07e49f22f2de..7e67742bc65e 100644
@@ -50,6 +50,7 @@ static int i915_ttm_backup(struct i915_gem_apply_to_region *apply,
  		container_of(bo->bdev, typeof(*i915), bdev);
  	struct drm_i915_gem_object *backup;
  	struct ttm_operation_ctx ctx = {};
+	unsigned int flags;
  	int err = 0;
 
  	if (bo->resource->mem_type == I915_PL_SYSTEM || obj->ttm.backup)
@@ -65,7 +66,22 @@ static int i915_ttm_backup(struct i915_gem_apply_to_region *apply,
  	if (obj->flags & I915_BO_ALLOC_PM_VOLATILE)
  		return 0;
 
-	backup = i915_gem_object_create_shmem(i915, obj->base.size);
+	/*
+	 * It seems that we might have some framebuffers still pinned at this
+	 * stage, but for such objects we might also need to deal with the CCS
+	 * aux state. Make sure we force the save/restore of the CCS state,
+	 * otherwise we might observe display corruption, when returning from
+	 * suspend.
+	 */
+	flags = 0;
+	if (i915_gem_object_needs_ccs_pages(obj)) {
+		WARN_ON_ONCE(!i915_gem_object_is_framebuffer(obj));
+		WARN_ON_ONCE(!pm_apply->allow_gpu);
+
+		flags = I915_BO_ALLOC_CCS_AUX;
+	}
+	backup = i915_gem_object_create_region(i915->mm.regions[INTEL_REGION_SMEM],
+					       obj->base.size, 0, flags);
  	if (IS_ERR(backup))
  		return PTR_ERR(backup);
 
#3 lore raw

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/migrate: fix corner case in CCS aux copying

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/migrate: fix corner case in CCS aux copying
URL : https://patchwork.freedesktop.org/series/111863/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.

#4 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/migrate: fix corner case in CCS aux copying

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/migrate: fix corner case in CCS aux copying
URL : https://patchwork.freedesktop.org/series/111863/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12497 -> Patchwork_111863v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/index.html

Participating hosts (18 -> 18)
------------------------------

Additional (1): fi-pnv-d510
Missing (1): fi-rkl-11600

Known issues
------------

Here are the changes found in Patchwork_111863v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][1] -> [INCOMPLETE][2] ([i915#4785])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/fi-hsw-4770/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/fi-hsw-4770/igt@i915_selftest@[email protected]

* igt@kms_psr@primary_page_flip:
- fi-pnv-d510: NOTRUN -> [SKIP][3] ([fdo#109271]) +44 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/fi-pnv-d510/igt@kms_psr@primary_page_flip.html

* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][4] ([fdo#109271] / [i915#4312] / [i915#5594])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/fi-hsw-4770/igt@[email protected]

#### Possible fixes ####

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [FAIL][5] ([i915#6298]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#5594]: https://gitlab.freedesktop.org/drm/intel/issues/5594
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298

Build changes
-------------

* Linux: CI_DRM_12497 -> Patchwork_111863v1

CI-20190529: 20190529
CI_DRM_12497: 6636ff92fd32bda3fed63832bc12bf2a9d7c1c33 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7091: b8015f920c9f469d3733854263cb878373c1df51 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111863v1: 6636ff92fd32bda3fed63832bc12bf2a9d7c1c33 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

9e50a42eec84 drm/i915/ttm: consider CCS for backup objects ae02d971ae1c drm/i915/migrate: fix corner case in CCS aux copying

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/index.html

Reviewed-by Nirmoy Das on v1 1/2
#5 lore raw
In reply to Matthew Auld
Quoted 6 lines · Matthew Auld

In the case of lmem -> lmem transfers, which is currently only possible with small-bar systems, we need to ensure we copy the CCS aux state as-is, rather than nuke it. This should fix some nasty display corruption sometimes seen on DG2 small-bar systems, when also using DG2_RC_CCS_CC for the surface.

Quoted 6 lines
Fixes e3afc690188b ("drm/i915/display: consider DG2_RC_CCS_CC when migrating buffers")
Cc Ville Syrjälä <[email protected]>
Cc Nirmoy Das <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Shuicheng Lin <[email protected]>
Quoted 52 lines
---
  drivers/gpu/drm/i915/gt/intel_migrate.c | 37 +++++++++++++++++++------
  1 file changed, 29 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/gt/intel_migrate.c +29 -8
index e08a739b7091..3f638f198796 100644
@@ -839,14 +839,35 @@ intel_context_migrate_copy(struct intel_context *ce,
  			if (err)
  				goto out_rq;
 
-			/*
-			 * While we can't always restore/manage the CCS state,
-			 * we still need to ensure we don't leak the CCS state
-			 * from the previous user, so make sure we overwrite it
-			 * with something.
-			 */
-			err = emit_copy_ccs(rq, dst_offset, INDIRECT_ACCESS,
-					    dst_offset, DIRECT_ACCESS, len);
+			if (src_is_lmem) {
+				/*
+				 * If the src is already in lmem, then we must
+				 * be doing an lmem -> lmem transfer, and so
+				 * should be safe to directly copy the CCS
+				 * state. In this case we have either
+				 * initialised the CCS aux state when first
+				 * clearing the pages (since it is already
+				 * allocated in lmem), or the user has
+				 * potentially populated it, in which case we
+				 * need to copy the CCS state as-is.
+				 */
+				err = emit_copy_ccs(rq,
+						    dst_offset, INDIRECT_ACCESS,
+						    src_offset, INDIRECT_ACCESS,
+						    len);
+			} else {
+				/*
+				 * While we can't always restore/manage the CCS
+				 * state, we still need to ensure we don't leak
+				 * the CCS state from the previous user, so make
+				 * sure we overwrite it with something.
+				 */
+				err = emit_copy_ccs(rq,
+						    dst_offset, INDIRECT_ACCESS,
+						    dst_offset, DIRECT_ACCESS,
+						    len);
+			}
+
  			if (err)
  				goto out_rq;
 
#6 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/migrate: fix corner case in CCS aux copying

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915/migrate: fix corner case in CCS aux copying
URL : https://patchwork.freedesktop.org/series/111863/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_12497_full -> Patchwork_111863v1_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_111863v1_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_111863v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (14 -> 9)
------------------------------

Missing (5): shard-tglu shard-tglu-10 shard-tglu-9 shard-rkl shard-dg1

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_111863v1_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_ctx_isolation@preservation-s3@vcs1:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-tglb5/igt@gem_ctx_isolation@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-tglb3/igt@gem_ctx_isolation@[email protected]

New tests
---------

New tests have been introduced between CI_DRM_12497_full and Patchwork_111863v1_full:

### New IGT tests (16) ###

* igt@fbdev@eof:
- Statuses :
- Exec time: [None] s

* igt@fbdev@nullptr:
- Statuses : 5 pass(s)
- Exec time: [0.0] s

* igt@fbdev@read:
- Statuses : 4 pass(s)
- Exec time: [0.0] s

* igt@fbdev@unaligned-read:
- Statuses : 5 pass(s)
- Exec time: [0.0] s

* igt@fbdev@unaligned-write:
- Statuses : 5 pass(s)
- Exec time: [0.0] s

* igt@fbdev@write:
- Statuses : 4 pass(s)
- Exec time: [0.0] s

* igt@gem_ctx_exec@basic-close-race:
- Statuses : 5 pass(s)
- Exec time: [0.0] s

* igt@gem_exec_suspend@basic-s0:
- Statuses :
- Exec time: [None] s

* igt@kms_big_joiner@basic:
- Statuses : 5 skip(s)
- Exec time: [0.0] s

* igt@kms_big_joiner@invalid-modeset:
- Statuses : 5 skip(s)
- Exec time: [0.0] s

* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- Statuses : 5 skip(s)
- Exec time: [0.0] s

* igt@kms_psr2_su@frontbuffer-xrgb8888:
- Statuses : 5 skip(s)
- Exec time: [0.0] s

* igt@kms_psr2_su@page_flip-nv12:
- Statuses : 3 skip(s)
- Exec time: [0.0] s

* igt@kms_psr2_su@page_flip-p010:
- Statuses : 5 skip(s)
- Exec time: [0.0] s

* igt@kms_psr2_su@page_flip-xrgb8888:
- Statuses : 5 skip(s)
- Exec time: [0.0] s

* igt@sysfs_defaults@readonly:
- Statuses :
- Exec time: [None] s

Known issues
------------

Here are the changes found in Patchwork_111863v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@api_intel_allocator@fork-simple-stress-signal:
- shard-tglb: [PASS][3] -> [INCOMPLETE][4] ([i915#6453])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-tglb1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-tglb6/igt@[email protected]

* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [PASS][5] -> [SKIP][6] ([i915#4525]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-iclb2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb3/igt@[email protected]

* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][7] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb2/igt@gem_exec_fair@[email protected]

* igt@i915_pm_backlight@fade-with-suspend:
- shard-skl: NOTRUN -> [INCOMPLETE][8] ([i915#7256])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-skl1/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-skl: NOTRUN -> [FAIL][9] ([i915#3989] / [i915#454])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-skl6/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-skl: [PASS][10] -> [WARN][11] ([i915#1804])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-skl6/igt@i915_pm_rc6_residency@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-skl4/igt@i915_pm_rc6_residency@[email protected]

* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#3886]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-skl6/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_chamelium@hdmi-hpd-with-enabled-mode:
- shard-skl: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-skl6/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: [PASS][14] -> [FAIL][15] ([i915#79])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-skl4/igt@kms_flip@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-skl1/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-apl: [PASS][16] -> [DMESG-WARN][17] ([i915#180])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-apl8/igt@kms_flip@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-apl1/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][18] ([i915#2672] / [i915#3555])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][19] ([i915#2672]) +3 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][20] -> [SKIP][21] ([i915#3555])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling@pipe-a-default-mode.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling@pipe-a-default-mode.html

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc:
- shard-skl: NOTRUN -> [SKIP][22] ([fdo#109271]) +34 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-skl6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu:
- shard-skl: [PASS][23] -> [DMESG-WARN][24] ([i915#1982]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-skl4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-cpu.html

* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1:
- shard-iclb: [PASS][25] -> [SKIP][26] ([i915#5176]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-iclb6/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html

* igt@kms_psr2_su@page_flip-nv12@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [FAIL][27] ([i915#5939]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb2/igt@kms_psr2_su@[email protected]

* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][28] -> [SKIP][29] ([fdo#109441])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html

* igt@kms_psr_stress_test@flip-primary-invalidate-overlay:
- shard-skl: [PASS][30] -> [SKIP][31] ([fdo#109271])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-skl4/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-skl1/igt@[email protected]

* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-tglb: [PASS][32] -> [SKIP][33] ([i915#5519])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-tglb2/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-tglb7/igt@[email protected]
- shard-iclb: [PASS][34] -> [SKIP][35] ([i915#5519])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-iclb2/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb6/igt@[email protected]

* igt@perf@polling:
- shard-skl: [PASS][36] -> [FAIL][37] ([i915#1542])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-skl4/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-skl1/igt@[email protected]

* igt@sysfs_clients@fair-7:
- shard-skl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#2994])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-skl6/igt@[email protected]

* igt@sysfs_heartbeat_interval@nopreempt@rcs0:
- shard-tglb: [PASS][39] -> [FAIL][40] ([i915#6015])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-tglb7/igt@sysfs_heartbeat_interval@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-tglb5/igt@sysfs_heartbeat_interval@[email protected]

#### Possible fixes ####

* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][41] ([i915#658]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-iclb5/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb2/igt@[email protected]

* igt@gem_exec_balancer@parallel:
- shard-iclb: [SKIP][43] ([i915#4525]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-iclb5/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb1/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [DMESG-FAIL][45] ([i915#5334]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-apl1/igt@i915_selftest@live@gt_heartbeat.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-apl3/igt@i915_selftest@live@gt_heartbeat.html

* igt@i915_selftest@live@hangcheck:
- shard-tglb: [DMESG-WARN][47] ([i915#5591]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-tglb5/igt@i915_selftest@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-tglb1/igt@i915_selftest@[email protected]

* igt@i915_suspend@forcewake:
- shard-skl: [INCOMPLETE][49] ([i915#4817] / [i915#7233]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-skl1/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-skl6/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [FAIL][51] ([i915#79]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-skl4/igt@kms_flip@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-skl1/igt@kms_flip@[email protected]

* igt@kms_flip@plain-flip-fb-recreate@c-edp1:
- shard-skl: [FAIL][53] ([i915#2122]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-skl4/igt@kms_flip@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-skl7/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode:
- shard-iclb: [SKIP][55] ([i915#6375]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode.html

* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][57] ([fdo#109441]) -> [PASS][58] +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-iclb5/igt@kms_psr@psr2_sprite_blt.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html

#### Warnings ####

* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [SKIP][59] ([i915#4525]) -> [FAIL][60] ([i915#6117])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-iclb3/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb2/igt@[email protected]

* igt@kms_plane_alpha_blend@alpha-basic@pipe-c-edp-1:
- shard-skl: [FAIL][61] ([i915#4573]) -> [DMESG-FAIL][62] ([IGT#6])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-skl1/igt@kms_plane_alpha_blend@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-skl4/igt@kms_plane_alpha_blend@[email protected]

* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][63] ([i915#2920]) -> [SKIP][64] ([i915#658])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-iclb2/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb8/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][65] ([i915#2920]) -> [SKIP][66] ([fdo#111068] / [i915#658]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-iclb2/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-iclb6/igt@[email protected]

* igt@runner@aborted:
- shard-apl: ([FAIL][67], [FAIL][68]) ([i915#3002] / [i915#4312]) -> ([FAIL][69], [FAIL][70], [FAIL][71]) ([i915#180] / [i915#3002] / [i915#4312])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-apl8/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12497/shard-apl1/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-apl1/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-apl3/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/shard-apl3/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6015]: https://gitlab.freedesktop.org/drm/intel/issues/6015
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6375]: https://gitlab.freedesktop.org/drm/intel/issues/6375
[i915#6453]: https://gitlab.freedesktop.org/drm/intel/issues/6453
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#7233]: https://gitlab.freedesktop.org/drm/intel/issues/7233
[i915#7256]: https://gitlab.freedesktop.org/drm/intel/issues/7256
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79

Build changes
-------------

* Linux: CI_DRM_12497 -> Patchwork_111863v1

CI-20190529: 20190529
CI_DRM_12497: 6636ff92fd32bda3fed63832bc12bf2a9d7c1c33 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7091: b8015f920c9f469d3733854263cb878373c1df51 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_111863v1: 6636ff92fd32bda3fed63832bc12bf2a9d7c1c33 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111863v1/index.html