bpf/selftests: Use parent instead of last_wakee in task kfunc test
Subsystems (3)
PATCH 1/1 bpf/selftests: Use parent instead of last_wakee in task kfunc test
Commit fe147956fca4 ("bpf/selftests: Add selftests for new task kfuncs") added a negative selftest called task_kfunc_acquire_trusted_walked which ensures that a BPF program that gets a struct task_struct * pointer from walking a struct is properly rejected by the verifier if it tries to pass that pointer to a task kfunc. In order to do this, it uses task->last_wakee, but unfortunately that's not defined on UP builds. Just use task->parent instead.
Reported-by kernel test robot <[email protected]>
Fixes fe147956fca4 ("bpf/selftests: Add selftests for new task kfuncs")
Signed-off-by David Vernet <[email protected]>
--- tools/testing/selftests/bpf/progs/task_kfunc_failure.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/progs/task_kfunc_failure.c +1 -1
@@ -73,7 +73,7 @@ int BPF_PROG(task_kfunc_acquire_trusted_walked, struct task_struct *task, u64 clstruct task_struct *acquired;/* Can't invoke bpf_task_acquire() on a trusted pointer obtained from walking a struct. */ - acquired =bpf_task_acquire (task->last_wakee); + acquired =bpf_task_acquire (task->parent);bpf_task_release (acquired);return 0 ;
Signature · 1 line
2.38.1