vdpasim: fix memory leak when freeing IOTLBs
PATCH 1/1 vdpasim: fix memory leak when freeing IOTLBs
After commit bda324fd037a ("vdpasim: control virtqueue support"), vdpasim->iommu became an array of IOTLB, so we should clean the mappings of each free one by one instead of just deleting the ranges in the first IOTLB which may leak maps.
Fixes bda324fd037a ("vdpasim: control virtqueue support")
Cc Gautam Dawar <[email protected]>
Signed-off-by Jason Wang <[email protected]>
--- drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/vdpa/vdpa_sim/vdpa_sim.c +3 -1
@@ -690,7 +690,9 @@ static void vdpasim_free(struct vdpa_device *vdpa) }kvfree (vdpasim->buffer); -vhost_iotlb_free (vdpasim->iommu); +for (i =0 ; i < vdpasim->dev_attr.nas; i++) +vhost_iotlb_reset (&vdpasim->iommu[i]); +kfree (vdpasim->iommu);kfree (vdpasim->vqs);kfree (vdpasim->config); }
Signature · 6 lines
2.25.1 _______________________________________________ Virtualization mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 31 lines · Jason Wang
CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.
After commit
bda324fd037a("vdpasim: control virtqueue support"),vdpasim->iommubecame an array of IOTLB, so we should clean the mappings of each free one by one instead of just deleting the ranges in the first IOTLB which may leak maps.Fixes bda324fd037a ("vdpasim: control virtqueue support")Cc Gautam Dawar <[email protected]>Signed-off-by Jason Wang <[email protected]>--- drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/vdpa/vdpa_sim/vdpa_sim.c +3
-2@@ -690,7 +690,9 @@ static void vdpasim_free(struct vdpa_device *vdpa) }kvfree (vdpasim->buffer); -vhost_iotlb_free (vdpasim->iommu); +for (i =0 ; i < vdpasim->dev_attr.nas; i++) +vhost_iotlb_reset (&vdpasim->iommu[i]); +kfree (vdpasim->iommu);kfree (vdpasim->vqs);kfree (vdpasim->config); } --
Quoted 2 lines
2.25.1
Looks good to me.
Reviewed-by Gautam Dawar <[email protected]>