Skip to contentSkip to conversation

dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property

PATCH Superseded Marek Vasut 2 participants 2 messages Dec 13, 2022

Subsystems (4)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Marek Vasut

author maintainer
#0 lore raw

PATCH v4 1/1 dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property

The power-domains property is mandatory on i.MX8M Mini, Nano, Plus and i.MX6SX, i.MX6SL. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

---
Cc: Fabio Estevam <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Liu Ying <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: - Add AB from Krzysztof
- Add mx6sx power domain into the list
V3: - Update commit message
- Add i.MX6SL
- Update example
V4: - Drop ack from Krzysztof
- Rebase on next 20221213 instead of previous 20221208, which now contains power-domains: part of this patch

---
 .../devicetree/bindings/display/fsl,lcdif.yaml     | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +14 -0
index f449cfc767899..fd5aab93dd103 100644
@@ -114,6 +114,19 @@ allOf:
           maxItems: 1
         clock-names:
           maxItems: 1
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx6sl-lcdif
+              - fsl,imx6sx-lcdif
+              - fsl,imx8mm-lcdif
+              - fsl,imx8mn-lcdif
+              - fsl,imx8mp-lcdif
+    then:
+      required:
+        - power-domains
 
 examples:
   - |
@@ -128,6 +141,7 @@ examples:
                  <&clks IMX6SX_CLK_LCDIF_APB>,
                  <&clks IMX6SX_CLK_DISPLAY_AXI>;
         clock-names = "pix", "axi", "disp_axi";
+        power-domains = <&pd_disp>;
 
         port {
             endpoint {
Signature · 1 line
2.35.1
#1 lore raw
Quoted 39 lines · Marek Vasut

The power-domains property is mandatory on i.MX8M Mini, Nano, Plus and i.MX6SX, i.MX6SL. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs.

---
Cc: Fabio Estevam <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Liu Ying <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: [email protected]
To: [email protected]
---
V2: - Add AB from Krzysztof
- Add mx6sx power domain into the list
V3: - Update commit message
- Add i.MX6SL
- Update example
V4: - Drop ack from Krzysztof
- Rebase on next 20221213 instead of previous 20221208, which now contains power-domains: part of this patch

---
 .../devicetree/bindings/display/fsl,lcdif.yaml     | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +3 -0
index f449cfc767899..fd5aab93dd103 100644
@@ -114,6 +114,19 @@ allOf:
           maxItems: 1
         clock-names:
           maxItems: 1
+  - if:
+      properties:
+        compatible:

Documentation/devicetree/bindings/display/fsl,lcdif.yaml allOf: · line 129

Quoted 10 lines
Documentation/devicetree/bindings/display/fsl,lcdif.yaml +10 -0
+          contains:
+            enum:
+              - fsl,imx6sl-lcdif
+              - fsl,imx6sx-lcdif
+              - fsl,imx8mm-lcdif
+              - fsl,imx8mn-lcdif
+              - fsl,imx8mp-lcdif
+    then:
+      required:
+        - power-domains

Looks ok, but in such case please drop reguired:power-domains from the existing entry for fsl,imx8mp-lcdif.

Best regards,
Krzysztof