Skip to contentSkip to conversation

MAINTAINERS: Update maintainer list for virtio i2c

PATCH In review Conghui 5 participants 11 messages Dec 14, 2022 – Dec 27, 2022

Subsystems (2)
lore
Share & tools
lore

Conghui

author
#0 lore raw

PATCH 1/1 MAINTAINERS: Update maintainer list for virtio i2c

This updates the maintainer for virtio i2c drvier

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index a8c8f6b42436..44747f4641a6 100644
@@ -21920,7 +21920,7 @@ F:	include/uapi/linux/virtio_snd.h
 F:	sound/virtio/*
 
 VIRTIO I2C DRIVER
-M:	Conghui Chen <[email protected]>
+M:	Jian Jun Chen <[email protected]>
 M:	Viresh Kumar <[email protected]>
 L:	[email protected]
 L:	[email protected]
Signature · 1 line
2.25.1
#1 lore raw
Quoted 13 lines · Conghui

This updates the maintainer for virtio i2c drvier

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index a8c8f6b42436..44747f4641a6 100644

MAINTAINERS F: include/uapi/linux/virtio_snd.h · line 21926

Quoted 8 lines
MAINTAINERS +1 -1
@@ -21920,7 +21920,7 @@ F:	include/uapi/linux/virtio_snd.h
 F:	sound/virtio/*
 
 VIRTIO I2C DRIVER
-M:	Conghui Chen <[email protected]>
+M:	Jian Jun Chen <[email protected]>
 M:	Viresh Kumar <[email protected]>
 L:	[email protected]
 L:	[email protected]

Wolfram,

I understand that it is okay to pass the maintainership, within the company, for platform specific parts from one person to another, since they have the best knowledge of the code and are the only one interested in maintaining it too.

But what is the rule for generic drivers like this one ?

Signature · 5 lines
viresh
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
#2 lore raw

Hi Viresh,

Quoted 6 lines

I understand that it is okay to pass the maintainership, within the company, for platform specific parts from one person to another, since they have the best knowledge of the code and are the only one interested in maintaining it too.

But what is the rule for generic drivers like this one ?

Dunno if this is really a rule, but if a maintainer steps out and makes sure there is someone to pick up the work, this is more than welcome. Way better than a stale entry in the MAINTAINERS file.

I mean, it does not limit the chance to have further maintainers, for example. I believe in meritocracy here. Those who do and collaborate, shall get responsibility. If not, then not. We can fix this, too, if needed.

What is the reason for your question?

All the best,

Wolfram

Acked-by
#3 lore raw
Quoted 3 lines · Wolfram Sang

Dunno if this is really a rule, but if a maintainer steps out and makes sure there is someone to pick up the work, this is more than welcome. Way better than a stale entry in the MAINTAINERS file.

Sure, a stale entry is always bad.

Quoted 6 lines

I mean, it does not limit the chance to have further maintainers, for example. I believe in meritocracy here. Those who do and collaborate, shall get responsibility. If not, then not. We can fix this, too, if needed.

What is the reason for your question?

It was a general question that I asked myself and didn't know an answer to. I wasn't sure if adding someone to be a maintainer here to a driver, which they haven't contributed to until now (at least based on open source commits), is right or not, since this isn't a stale entry in MAINTAINERS anyway.

An entry as R: would be okay normally IMO, as this makes sure interested party is kept aware of the development in the area. An M:
entry somehow gives a higher level of authority to the person and without any prior contributions, it feels tricky at least.

Anyway, I don't have any objection to the patch at least as it was primarily developed by Intel engineers.

Signature · 1 line
viresh
#4 lore raw
Quoted 25 lines · Viresh Kumar
Quoted 3 lines · Wolfram Sang

Dunno if this is really a rule, but if a maintainer steps out and makes sure there is someone to pick up the work, this is more than welcome. Way better than a stale entry in the MAINTAINERS file.

Sure, a stale entry is always bad.

Quoted 6 lines

I mean, it does not limit the chance to have further maintainers, for example. I believe in meritocracy here. Those who do and collaborate, shall get responsibility. If not, then not. We can fix this, too, if needed.

What is the reason for your question?

It was a general question that I asked myself and didn't know an answer to. I wasn't sure if adding someone to be a maintainer here to a driver, which they haven't contributed to until now (at least based on open source commits), is right or not, since this isn't a stale entry in MAINTAINERS anyway.

An entry as R: would be okay normally IMO, as this makes sure interested party is kept aware of the development in the area. An M:
entry somehow gives a higher level of authority to the person and without any prior contributions, it feels tricky at least.

Quoted 4 lines

Anyway, I don't have any objection to the patch at least as it was primarily developed by Intel engineers.

If a maintainer acks a patch I generally expect that the patch is good. If we have a maintainer who's not familiar with the codebase, this assumption does not hold.
R: would be ok with me.

Quoted 2 lines
Signature · 1 line
viresh

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#5 lore raw
In reply to Wolfram Sang
Quoted 9 lines · Wolfram Sang

Hi Viresh,

Quoted 6 lines

I understand that it is okay to pass the maintainership, within the company, for platform specific parts from one person to another, since they have the best knowledge of the code and are the only one interested in maintaining it too.

But what is the rule for generic drivers like this one ?

Quoted 7 lines

Dunno if this is really a rule, but if a maintainer steps out and makes sure there is someone to pick up the work, this is more than welcome. Way better than a stale entry in the MAINTAINERS file.

I mean, it does not limit the chance to have further maintainers, for example. I believe in meritocracy here. Those who do and collaborate, shall get responsibility.

Exactly. I'd like to see Jian Jun Chen do and collaborate first.

Quoted 9 lines

If not, then not. We can fix this, too, if
needed.

What is the reason for your question?

All the best,

Wolfram

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#6 lore raw
Quoted 9 lines · Michael S. Tsirkin
Quoted 8 lines · Wolfram Sang

Hi Viresh,

Quoted 6 lines

I understand that it is okay to pass the maintainership, within the company, for platform specific parts from one person to another, since they have the best knowledge of the code and are the only one interested in maintaining it too.

But what is the rule for generic drivers like this one ?

Quoted 8 lines
Quoted 7 lines

Dunno if this is really a rule, but if a maintainer steps out and makes sure there is someone to pick up the work, this is more than welcome. Way better than a stale entry in the MAINTAINERS file.

I mean, it does not limit the chance to have further maintainers, for example. I believe in meritocracy here. Those who do and collaborate, shall get responsibility.

Exactly. I'd like to see Jian Jun Chen do and collaborate first.

Hi Michael,

Sure, I will start to collaborate first.

Quoted 10 lines
Quoted 9 lines

If not, then not. We can fix this, too, if
needed.

What is the reason for your question?

All the best,

Wolfram

#7 lore raw
Quoted 15 lines · Jian Jun
Quoted 13 lines · Michael S. Tsirkin
Quoted 12 lines · Wolfram Sang

Hi Viresh,

Quoted 6 lines

I understand that it is okay to pass the maintainership, within the company, for platform specific parts from one person to another, since they have the best knowledge of the code and are the only one interested in maintaining it too.

But what is the rule for generic drivers like this one ?

Dunno if this is really a rule, but if a maintainer steps out and makes sure there is someone to pick up the work, this is more than welcome. Way better than a stale entry in the MAINTAINERS file.

Quoted 8 lines
Quoted 4 lines
Quoted 3 lines

I mean, it does not limit the chance to have further maintainers, for example. I believe in meritocracy here. Those who do and collaborate, shall get responsibility.

Exactly. I'd like to see Jian Jun Chen do and collaborate first.

Hi Michael,

Sure, I will start to collaborate first.

Great!

Quoted 10 lines
Quoted 10 lines
Quoted 9 lines

If not, then not. We can fix this, too, if
needed.

What is the reason for your question?

All the best,

Wolfram

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#8 lore raw
In reply to Conghui
Quoted 1 line · Conghui

This updates the maintainer for virtio i2c drvier

I got that, but what is going on here exactly?
I generally expect a new maintainer to be active in the project for a while first.
I don't see contributions or reviews for this driver or for that matter for any virtio or i2c drivers from Jian Jun Chen. It looks like you are no longer interested in maintaining this? In that case pls just send a patch removing yourself.

Jian Jun Chen, if you are interested in reviewing patches please start doing so, you don't need to be listed as a maintainer for this to happen. Once you do this for a while and write some patches, you can become a maintainer, this is not a high bar to clear.

Quoted 21 lines
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index a8c8f6b42436..44747f4641a6 100644
@@ -21920,7 +21920,7 @@ F:	include/uapi/linux/virtio_snd.h
 F:	sound/virtio/*
 
 VIRTIO I2C DRIVER
-M:	Conghui Chen <[email protected]>
+M:	Jian Jun Chen <[email protected]>
 M:	Viresh Kumar <[email protected]>
 L:	[email protected]
 L:	[email protected]
Signature · 1 line
2.25.1

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

#9 lore raw
Quoted 10 lines · Michael S. Tsirkin
Quoted 1 line · Conghui

This updates the maintainer for virtio i2c drvier

I got that, but what is going on here exactly?
I generally expect a new maintainer to be active in the project for a while first.
I don't see contributions or reviews for this driver or for that matter for any virtio or i2c drivers from Jian Jun Chen. It looks like you are no longer interested in maintaining this? In that case pls just send a patch removing yourself.

Quoted 6 lines

Jian Jun Chen, if you are interested in reviewing patches please start doing so, you don't need to be listed as a maintainer for this to happen. Once you do this for a while and write some patches, you can become a maintainer, this is not a high bar to clear.

Hi Michael,

Yes. I am interested in the virtio I2C maintenance. I have lots of virtio experience in ACRN device model development and was involved in the early phase virtio I2C discussion in ACRN before Jie/Conghui upstream the virtio I2C spec. Sure, I will start to collaborate first.

Quoted 21 lines
Quoted 21 lines
---
  MAINTAINERS | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index a8c8f6b42436..44747f4641a6 100644
@@ -21920,7 +21920,7 @@ F:	include/uapi/linux/virtio_snd.h
  F:	sound/virtio/*
 
  VIRTIO I2C DRIVER
-M:	Conghui Chen <[email protected]>
+M:	Jian Jun Chen <[email protected]>
  M:	Viresh Kumar <[email protected]>
  L:	[email protected]
  L:	[email protected]
Signature · 1 line
2.25.1
#10 lore raw
Quoted 19 lines · Jian Jun
Quoted 10 lines · Michael S. Tsirkin
Quoted 1 line · Conghui

This updates the maintainer for virtio i2c drvier

I got that, but what is going on here exactly?
I generally expect a new maintainer to be active in the project for a while first.
I don't see contributions or reviews for this driver or for that matter for any virtio or i2c drivers from Jian Jun Chen. It looks like you are no longer interested in maintaining this? In that case pls just send a patch removing yourself.

Quoted 6 lines

Jian Jun Chen, if you are interested in reviewing patches please start doing so, you don't need to be listed as a maintainer for this to happen. Once you do this for a while and write some patches, you can become a maintainer, this is not a high bar to clear.

Quoted 6 lines

Hi Michael,

Yes. I am interested in the virtio I2C maintenance. I have lots of virtio experience in ACRN device model development and was involved in the early phase virtio I2C discussion in ACRN before Jie/Conghui upstream the virtio I2C spec. Sure, I will start to collaborate first.

Excellent, thanks a lot!

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
---
  MAINTAINERS | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
MAINTAINERS +0 -0
index a8c8f6b42436..44747f4641a6 100644
@@ -21920,7 +21920,7 @@ F:	include/uapi/linux/virtio_snd.h
  F:	sound/virtio/*
Quoted 8 lines
Quoted 8 lines
MAINTAINERS +1 -1
  VIRTIO I2C DRIVER
-M:	Conghui Chen <[email protected]>
+M:	Jian Jun Chen <[email protected]>
  M:	Viresh Kumar <[email protected]>
  L:	[email protected]
  L:	[email protected]
Signature · 1 line
2.25.1

_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization