Skip to contentSkip to conversation

staging: qlge: remove unnecessary spaces before function pointer args

PATCH In review Aldas Taraškevičius 3 participants 3 messages Dec 14, 2022 – Jan 17, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: qlge: remove unnecessary spaces before function pointer args

Remove unnecessary spaces before the function pointer arguments as warned by checkpatch.

---
 drivers/staging/qlge/qlge.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/qlge/qlge.h +2 -2
index fc8c5ca89..05e4f4744 100644
@@ -2057,8 +2057,8 @@ enum {
 };
 
 struct nic_operations {
-	int (*get_flash) (struct ql_adapter *);
-	int (*port_initialize) (struct ql_adapter *);
+	int (*get_flash)(struct ql_adapter *);
+	int (*port_initialize)(struct ql_adapter *);
 };
 
 /*
Signature · 1 line
2.37.2
#1 lore raw
Quoted 13 lines · Aldas Taraškevičius

Remove unnecessary spaces before the function pointer arguments as warned by checkpatch.

---
 drivers/staging/qlge/qlge.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/qlge/qlge.h +0 -0
index fc8c5ca89..05e4f4744 100644

drivers/staging/qlge/qlge.h enum { · line 2062

Quoted 8 lines
drivers/staging/qlge/qlge.h +2 -2
@@ -2057,8 +2057,8 @@ enum {
 };
 
 struct nic_operations {
-	int (*get_flash) (struct ql_adapter *);
-	int (*port_initialize) (struct ql_adapter *);
+	int (*get_flash)(struct ql_adapter *);
+	int (*port_initialize)(struct ql_adapter *);
 };

I'm not clear if there is consensus on the style issue at play here. And so I am neutral on this patch.

But perhaps if these lines are being updated then the following check patch warnings could be addressed.

$ scripts/checkpatch.pl --strict this.patch
WARNING: function definition argument 'struct ql_adapter *' should also have an identifier name
#122: FILE: drivers/staging/qlge/qlge.h:2060:
+	int (*get_flash)(struct ql_adapter *);

WARNING: function definition argument 'struct ql_adapter *' should also have an identifier name #123: FILE: drivers/staging/qlge/qlge.h:2061:
+ int (*port_initialize)(struct ql_adapter *);

total: 0 errors, 2 warnings, 0 checks, 10 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] staging: qlge: remove unnecessary spaces before function pointer args" has style problems, please review.

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

maintainer
#2 lore raw
In reply to Aldas Taraškevičius
Quoted 27 lines · Aldas Taraškevičius

Remove unnecessary spaces before the function pointer arguments as warned by checkpatch.

---
 drivers/staging/qlge/qlge.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/qlge/qlge.h +2 -2
index fc8c5ca89..05e4f4744 100644
@@ -2057,8 +2057,8 @@ enum {
 };
 
 struct nic_operations {
-	int (*get_flash) (struct ql_adapter *);
-	int (*port_initialize) (struct ql_adapter *);
+	int (*get_flash)(struct ql_adapter *);
+	int (*port_initialize)(struct ql_adapter *);
 };
 
 /*
Signature · 1 line
2.37.2

Does not apply to my tree :(