f2fs: avoid to check PG_error flag
Chao Yu
maintainerPATCH 1/1 f2fs: avoid to check PG_error flag
After below changes:
commit 14db0b3c7b83 ("fscrypt: stop using PG_error to track error status") commit 98dc08bae678 ("fsverity: stop using PG_error to track error status")
There is no place in f2fs we will set PG_error flag in page, let's remove other PG_error usage in f2fs, as a step towards freeing the PG_error flag for other uses.
Cc Eric Biggers <[email protected]>
Signed-off-by Chao Yu <[email protected]>
--- fs/f2fs/data.c | 2 -- fs/f2fs/gc.c | 1 - fs/f2fs/inline.c | 1 - fs/f2fs/node.c | 3 --- fs/f2fs/segment.c | 1 - 5 files changed, 8 deletions(-)
fs/f2fs/data.c +0 -2
@@ -2700,7 +2700,6 @@ int f2fs_do_write_data_page(struct f2fs_io_info *fio) goto out_writepage;set_page_writeback (page); -ClearPageError (page);f2fs_put_dnode (&dn);if (fio->need_lock ==LOCK_REQ )f2fs_unlock_op (fio->sbi);
@@ -2736,7 +2735,6 @@ int f2fs_do_write_data_page(struct f2fs_io_info *fio) goto out_writepage;set_page_writeback (page); -ClearPageError (page);if (fio->compr_blocks && fio->old_blkaddr ==COMPRESS_ADDR )f2fs_i_compr_blocks_update (inode, fio->compr_blocks -1 , false);
fs/f2fs/gc.c +0 -1
@@ -1365,7 +1365,6 @@ static int move_data_block(struct inode *inode, block_t bidx,dec_page_count (fio.sbi,F2FS_DIRTY_META );set_page_writeback (fio.encrypted_page); -ClearPageError (page); fio.op =REQ_OP_WRITE ; fio.op_flags =REQ_SYNC ;
fs/f2fs/inline.c +0 -1
@@ -174,7 +174,6 @@ int f2fs_convert_inline_page(struct dnode_of_data *dn, struct page *page)/* write data page to try to make data consistent */ set_page_writeback (page); -ClearPageError (page); fio.old_blkaddr = dn->data_blkaddr;set_inode_flag (dn->inode,FI_HOT_DATA );f2fs_outplace_write_data (dn, &fio);
fs/f2fs/node.c +0 -3
@@ -1650,7 +1650,6 @@ static int __write_node_page(struct page *page, bool atomic, bool *submitted, }set_page_writeback (page); -ClearPageError (page); fio.old_blkaddr = ni.blk_addr;f2fs_do_write_node_page (nid, &fio);
@@ -2079,8 +2078,6 @@ int f2fs_wait_on_node_pages_writeback(struct f2fs_sb_info *sbi,spin_unlock_irqrestore (&sbi->fsync_node_lock, flags);f2fs_wait_on_page_writeback (page,NODE , true, false); -if (TestClearPageError (page)) - ret = -EIO ;put_page (page);
fs/f2fs/segment.c +0 -1
@@ -3423,7 +3423,6 @@ void f2fs_do_write_meta_page(struct f2fs_sb_info *sbi, struct page *page, fio.op_flags &= ~REQ_META ;set_page_writeback (page); -ClearPageError (page);f2fs_submit_page_write (&fio);stat_inc_meta_count (sbi, page->index);
Signature · 1 line
2.25.1