lib/igt_draw: Change MOCS settings for MTL
PATCH 1/1 lib/igt_draw: Change MOCS settings for MTL
On MTL, we want the table entry labelled "UC (GO:Mem)" which has index 5. This means that the MOCS value is 10.
--- lib/igt_draw.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
lib/igt_draw.c +4 -1
@@ -703,7 +703,10 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,intel_bb_out (ibb,XY_FAST_COLOR_BLT | blt_cmd_depth);/* DG2 MOCS entry 2 is "UC - Non-Coherent; GO:Memory" */ -intel_bb_out (ibb, blt_cmd_tiling |2 <<21 | (pitch-1 )); +if (IS_METEORLAKE (intel_get_drm_devid (fd))) +intel_bb_out (ibb, blt_cmd_tiling |10 <<21 | (pitch-1 )); +else +intel_bb_out (ibb, blt_cmd_tiling |2 <<21 | (pitch-1 ));intel_bb_out (ibb, (rect->y <<16 ) | rect->x);intel_bb_out (ibb, ((rect->y + rect->h) <<16 ) | (rect->x + rect->w)); intel_bb_emit_reloc_fenced(ibb, dst->handle, 0,
Signature · 1 line
2.36.0
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_draw: Change MOCS settings for MTL
== Series Details ==
== Series Details ==
Series: lib/igt_draw: Change MOCS settings for MTL
URL : https://patchwork.freedesktop.org/series/111958/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12508 -> IGTPW_8237
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_8237 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_8237, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8237/index.html
Participating hosts (19 -> 18)
------------------------------
Missing (1): fi-rkl-11600
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8237:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@workarounds:
- fi-rkl-guc: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12508/fi-rkl-guc/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8237/fi-rkl-guc/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in IGTPW_8237 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_softpin@allocator-basic:
- fi-ivb-3770: NOTRUN -> [SKIP][3] ([fdo#109271]) +18 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8237/fi-ivb-3770/igt@[email protected]
* igt@i915_selftest@live@gt_mocs:
- fi-rkl-guc: [PASS][4] -> [INCOMPLETE][5] ([i915#4983])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12508/fi-rkl-guc/igt@i915_selftest@live@gt_mocs.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8237/fi-rkl-guc/igt@i915_selftest@live@gt_mocs.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-ivb-3770: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827]) +8 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8237/fi-ivb-3770/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153
[i915#6106]: https://gitlab.freedesktop.org/drm/intel/issues/6106
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7094 -> IGTPW_8237
CI-20190529: 20190529
CI_DRM_12508: 50bbaf39d655c47685f84dd1fb0c2cb4fb7e5286 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8237: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8237/index.html
IGT_7094: 1763071e9d50c5e992257c9197cb26f166de6fae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8237/index.html
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_draw: Change MOCS settings for MTL (rev2)
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: lib/igt_draw: Change MOCS settings for MTL (rev2)
URL : https://patchwork.freedesktop.org/series/111958/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12510 -> IGTPW_8239
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_8239 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_8239, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/index.html
Participating hosts (19 -> 41)
------------------------------
Additional (22): fi-kbl-soraka bat-dg1-6 bat-dg1-5 bat-adlp-6 bat-rpls-1 bat-rpls-2 fi-skl-6600u fi-bsw-n3050 bat-dg2-8 bat-adlm-1 bat-dg2-9 fi-bwr-2160 bat-adln-1 bat-atsm-1 bat-jsl-3 bat-rplp-1 bat-dg2-11 fi-bsw-nick bat-dg1-7 bat-kbl-2 bat-adlp-9 bat-adlp-4
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8239:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@guc_multi_lrc:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-b-edp-1:
- {bat-rplp-1}: NOTRUN -> [DMESG-WARN][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-rplp-1/igt@kms_pipe_crc_basic@[email protected]
Known issues
------------
Here are the changes found in IGTPW_8239 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-adlp-4: NOTRUN -> [SKIP][3] ([i915#7456])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-adlp-4/igt@[email protected]
* igt@gem_exec_gttfill@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271]) +7 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-kbl-soraka/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-skl-6600u: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-skl-6600u/igt@[email protected]
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-kbl-soraka/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-kbl-soraka/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-bsw-nick: NOTRUN -> [SKIP][8] ([fdo#109271]) +39 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-bsw-nick/igt@[email protected]
* igt@gem_lmem_swapping@random-engines:
- fi-bsw-n3050: NOTRUN -> [SKIP][9] ([fdo#109271]) +20 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-bsw-n3050/igt@[email protected]
- fi-skl-6600u: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-skl-6600u/igt@[email protected]
* igt@gem_lmem_swapping@verify-random:
- bat-adlp-4: NOTRUN -> [SKIP][11] ([i915#4613]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-adlp-4/igt@[email protected]
* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][12] ([i915#4083])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][13] ([i915#4083])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-6/igt@[email protected]
* igt@gem_render_tiled_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][14] ([i915#4079]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-6/igt@[email protected]
* igt@gem_tiled_fence_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][15] ([i915#4077]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-6/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][16] ([i915#4077]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-5/igt@[email protected]
* igt@gem_tiled_pread_basic:
- bat-dg1-5: NOTRUN -> [SKIP][17] ([i915#4079]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-5/igt@gem_tiled_pread_basic.html
- bat-adlp-4: NOTRUN -> [SKIP][18] ([i915#3282])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-adlp-4/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-6: NOTRUN -> [SKIP][19] ([i915#7561])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-6/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][20] ([i915#7561])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-5/igt@[email protected]
* igt@i915_pm_rps@basic-api:
- bat-dg1-6: NOTRUN -> [SKIP][21] ([i915#6621])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-6/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][22] ([i915#6621])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-5/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][23] ([i915#6621])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-adlp-4/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][24] ([i915#5334])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][25] ([i915#1886])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_addfb_basic@basic-x-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][26] ([i915#4212]) +7 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-5/igt@[email protected]
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][27] ([i915#4215])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][28] ([i915#4215])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-6/igt@[email protected]
* igt@kms_addfb_basic@tile-pitch-mismatch:
- bat-dg1-6: NOTRUN -> [SKIP][29] ([i915#4212]) +7 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-6/igt@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- bat-adlp-4: NOTRUN -> [SKIP][30] ([fdo#111827]) +8 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-adlp-4/igt@[email protected]
* igt@kms_chamelium@dp-edid-read:
- fi-bsw-n3050: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +8 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-bsw-n3050/igt@[email protected]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-skl-6600u: NOTRUN -> [SKIP][32] ([fdo#109271] / [fdo#111827]) +8 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-skl-6600u/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][33] ([fdo#111827]) +8 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-6/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-bsw-nick: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +8 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-bsw-nick/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][35] ([fdo#111827]) +8 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-5/igt@[email protected]
- fi-kbl-soraka: NOTRUN -> [SKIP][36] ([fdo#109271] / [fdo#111827]) +7 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-kbl-soraka/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- bat-adlp-4: NOTRUN -> [SKIP][37] ([i915#4103])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-adlp-4/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][38] ([i915#4103] / [i915#4213])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][39] ([i915#4103] / [i915#4213])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-6/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg1-5: NOTRUN -> [SKIP][40] ([fdo#109285])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][41] ([fdo#109285])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-6/igt@[email protected]
* igt@kms_force_connector_basic@prune-stale-modes:
- bat-adlp-4: NOTRUN -> [SKIP][42] ([i915#4093]) +3 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-adlp-4/igt@[email protected]
* igt@kms_psr@primary_mmap_gtt:
- fi-bwr-2160: NOTRUN -> [SKIP][43] ([fdo#109271]) +54 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-bwr-2160/igt@kms_psr@primary_mmap_gtt.html
* igt@kms_psr@sprite_plane_onoff:
- bat-dg1-6: NOTRUN -> [SKIP][44] ([i915#1072] / [i915#4078]) +3 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-6/igt@kms_psr@sprite_plane_onoff.html
- bat-dg1-5: NOTRUN -> [SKIP][45] ([i915#1072] / [i915#4078]) +3 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-5/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-dg1-6: NOTRUN -> [SKIP][46] ([i915#3555])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-6/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][47] ([i915#3555])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-5/igt@[email protected]
- bat-adlp-4: NOTRUN -> [SKIP][48] ([i915#3555] / [i915#4579])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-adlp-4/igt@[email protected]
* igt@prime_vgem@basic-fence-read:
- bat-dg1-5: NOTRUN -> [SKIP][49] ([i915#3708]) +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-5/igt@[email protected]
* igt@prime_vgem@basic-gtt:
- bat-dg1-5: NOTRUN -> [SKIP][50] ([i915#3708] / [i915#4077]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][51] ([i915#3708] / [i915#4077]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-6/igt@[email protected]
* igt@prime_vgem@basic-read:
- bat-dg1-6: NOTRUN -> [SKIP][52] ([i915#3708]) +3 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-6/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- bat-adlp-4: NOTRUN -> [SKIP][53] ([fdo#109295] / [i915#3301] / [i915#3708])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-adlp-4/igt@[email protected]
- fi-skl-6600u: NOTRUN -> [SKIP][54] ([fdo#109271]) +4 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-skl-6600u/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][55] ([i915#3708] / [i915#4873])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-5/igt@[email protected]
- bat-dg1-6: NOTRUN -> [SKIP][56] ([i915#3708] / [i915#4873])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-dg1-6/igt@[email protected]
* igt@prime_vgem@basic-write:
- bat-adlp-4: NOTRUN -> [SKIP][57] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/bat-adlp-4/igt@[email protected]
#### Possible fixes ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [FAIL][58] ([i915#6298]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12510/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/fi-bsw-kefka/igt@kms_cursor_legacy@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4303]: https://gitlab.freedesktop.org/drm/intel/issues/4303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077
[i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078
[i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093
[i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094
[i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6311]: https://gitlab.freedesktop.org/drm/intel/issues/6311
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7498]: https://gitlab.freedesktop.org/drm/intel/issues/7498
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7094 -> IGTPW_8239
CI-20190529: 20190529
CI_DRM_12510: e7a0d02714edf5ceac30b8da5ed7151d7dadbd40 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8239: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/index.html
IGT_7094: 1763071e9d50c5e992257c9197cb26f166de6fae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8239/index.html
We are seeing at BAT failure which is not related to this patch. Can you please help with this.
IGT changes
Possible regressions
igt@i915_selftest@live@guc_multi_lrc:
fi-kbl-soraka: NOTRUN -> INCOMPLETE
Thanks
Jeevan B
Quoted 37 lines
-----Original Message-----
From: B, Jeevan <[email protected]>
Sent: Thursday, December 15, 2022 1:50 PM
To: [email protected]
Cc: Roper, Matthew D <[email protected]>; B S, Karthik <[email protected]>; B, Jeevan <[email protected]>
Subject: [PATCH i-g-t]lib/igt_draw: Change MOCS settings for MTLOn MTL, we want the table entry labelled "UC (GO:Mem)" which has index 5. This means that the MOCS value is 10.
Signed-off-by Jeevan B <[email protected]>--- lib/igt_draw.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)lib/igt_draw.c +4
-1@@ -703,7 +703,10 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,intel_bb_out (ibb,XY_FAST_COLOR_BLT | blt_cmd_depth);/* DG2 MOCS entry 2 is "UC - Non-Coherent; GO:Memory" */ -intel_bb_out (ibb, blt_cmd_tiling |2 <<21 | (pitch-1 )); +if (IS_METEORLAKE (intel_get_drm_devid (fd))) +intel_bb_out (ibb, blt_cmd_tiling |10 <<21 | (pitch-1 )); +else +intel_bb_out (ibb, blt_cmd_tiling |2 <<21 | (pitch-1 ));lib/igt_draw.c +0
-0intel_bb_out (ibb, (rect->y <<16 ) | rect->x); intel_bb_out(ibb, ((rect->y + rect->h) << 16) | (rect->x + rect-Quoted 1 line
w));
intel_bb_emit_reloc_fenced(ibb,
dst->handle, 0,
--
2.36.0
Quoted 13 lines · Jeevan B
On MTL, we want the table entry labelled "UC (GO:Mem)" which has index 5. This means that the MOCS value is 10.
Signed-off-by Jeevan B <[email protected]>---
lib/igt_draw.c| 5 ++++-1 file changed, 4 insertions(+), 1 deletion(-)lib/igt_draw.c +0
-0
lib/igt_draw.c static void draw_rect_blt(int fd, struct cmd_data *cmd_data, · line 709
Quoted 8 lines
lib/igt_draw.c +4
-1@@ -703,7 +703,10 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,intel_bb_out (ibb,XY_FAST_COLOR_BLT | blt_cmd_depth);/* DG2 MOCS entry 2 is "UC - Non-Coherent; GO:Memory" */ -intel_bb_out (ibb, blt_cmd_tiling |2 <<21 | (pitch-1 )); +if (IS_METEORLAKE (intel_get_drm_devid (fd))) +intel_bb_out (ibb, blt_cmd_tiling |10 <<21 | (pitch-1 )); +else +intel_bb_out (ibb, blt_cmd_tiling |2 <<21 | (pitch-1 ));
if we avoid the magic number, we also don't need the comment. At the beginning of this file we can do:
#define DG2_MOCS_UC_GO_MEM 2 /* MOCS index 0x1 */
#define MTL_MOCS_UC_GO_MEM 10 /* MOCS index 0x5 */
draw_rect_blt()
{
..
if (IS_METEORLAKE(intel_get_drm_devid(fd))
mocs_val = MTL_MOCS_UC_GO_MEM; else mocs_val = DG2_MOCS_UC_GO_MEM;
...intel_bb_out(ibb, XY_FAST_COLOR_BLT | blt_cmd_depth); intel_bb_out(ibb, blt_cmd_tiling | mocs_val << 21 | (pitch-1));
Lucas De Marchi
Quoted 6 lines
lib/igt_draw.c +0
-0intel_bb_out (ibb, (rect->y <<16 ) | rect->x);intel_bb_out (ibb, ((rect->y + rect->h) <<16 ) | (rect->x + rect->w)); intel_bb_emit_reloc_fenced(ibb, dst->handle, 0,Signature · 1 line
2.36.0