Skip to contentSkip to conversation

pinctrl: mxs: avoid defines prefixed with CONFIG

PATCH In review Lukas Bulwahn 2 participants 2 messages Dec 15, 2022 – Dec 29, 2022

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: mxs: avoid defines prefixed with CONFIG

Defines prefixed with "CONFIG" should be limited to proper Kconfig options, that are introduced in a Kconfig file.

Here, expressions to convert pin configurations to booleans for pull-up, voltage and mA are macro definitions that begin with "CONFIG".

To avoid defines prefixed with "CONFIG", rename these defines to begin with "PIN_CONFIG" instead.

No functional change.

---
 drivers/pinctrl/freescale/pinctrl-mxs.c | 6 +++---
 drivers/pinctrl/freescale/pinctrl-mxs.h | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)
drivers/pinctrl/freescale/pinctrl-mxs.c +3 -3
index 9f78c9b29ddd..cf3f4d2e0c16 100644
@@ -269,9 +269,9 @@ static int mxs_pinconf_group_set(struct pinctrl_dev *pctldev,
 	for (n = 0; n < num_configs; n++) {
 		config = configs[n];
 
-		ma = CONFIG_TO_MA(config);
-		vol = CONFIG_TO_VOL(config);
-		pull = CONFIG_TO_PULL(config);
+		ma = PIN_CONFIG_TO_MA(config);
+		vol = PIN_CONFIG_TO_VOL(config);
+		pull = PIN_CONFIG_TO_PULL(config);
 
 		for (i = 0; i < g->npins; i++) {
 			bank = PINID_TO_BANK(g->pins[i]);
drivers/pinctrl/freescale/pinctrl-mxs.h +3 -3
index ab9f834b03e6..5b26511d56aa 100644
@@ -44,9 +44,9 @@
 #define VOL_SHIFT		3
 #define MA_PRESENT		(1 << 2)
 #define MA_SHIFT		0
-#define CONFIG_TO_PULL(c)	((c) >> PULL_SHIFT & 0x1)
-#define CONFIG_TO_VOL(c)	((c) >> VOL_SHIFT & 0x1)
-#define CONFIG_TO_MA(c)		((c) >> MA_SHIFT & 0x3)
+#define PIN_CONFIG_TO_PULL(c)	((c) >> PULL_SHIFT & 0x1)
+#define PIN_CONFIG_TO_VOL(c)	((c) >> VOL_SHIFT & 0x1)
+#define PIN_CONFIG_TO_MA(c)	((c) >> MA_SHIFT & 0x3)
 
 struct mxs_function {
 	const char *name;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 6 lines · Lukas Bulwahn

Defines prefixed with "CONFIG" should be limited to proper Kconfig options, that are introduced in a Kconfig file.

Here, expressions to convert pin configurations to booleans for pull-up, voltage and mA are macro definitions that begin with "CONFIG".

Quoted 6 lines

To avoid defines prefixed with "CONFIG", rename these defines to begin with "PIN_CONFIG" instead.

No functional change.

Patch applied.

Yours,
Linus Walleij