turbostat.c: Fix /dev/cpu_dma_latency warnings
PATCH 1/1 turbostat.c: Fix /dev/cpu_dma_latency warnings
When running as non-root the following error is seen in turbostat:
turbostat: fopen /dev/cpu_dma_latency
: Permission denied
turbostat and the man page have information on how to avoid other permission errors, so these can be fixed the same way.
Provide better /dev/cpu_dma_latency warnings that provide instructions on how to avoid the error, and update the man page.
Signed-off-by Prarit Bhargava <[email protected]>
Cc Len Brown <[email protected]>
--- tools/power/x86/turbostat/turbostat.8 | 2 ++ tools/power/x86/turbostat/turbostat.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-)
tools/power/x86/turbostat/turbostat.8 +2 -0
@@ -344,6 +344,8 @@ Alternatively, non-root users can be enabled to run turbostat this way: # chmod +r /dev/cpu/*/msr +# chmod +r /dev/cpu_dma_latency + .B "turbostat " reads hardware counters, but doesn't write them. So it will not interfere with the OS or other programs, including
tools/power/x86/turbostat/turbostat.c +2 -2
@@ -5476,13 +5476,13 @@ void print_dev_latency(void) fd =open (path,O_RDONLY );if (fd <0 ) { -warn ("fopen %s\n" , path); +warn ("open failed, try chmod +r %s\n" , path);return ; } retval =read (fd, (void *)&value,sizeof (int ));if (retval !=sizeof (int )) { -warn ("read %s\n" , path); +warn ("read failed %s\n" , path);close (fd);return ; }
Signature · 1 line
2.38.1