Skip to contentSkip to conversation

CI: define DEFAULT_TAG and CPU_REQUEST

PATCH Applied Jon Mason 2 participants 2 messages Dec 15, 2022 – Dec 16, 2022

lore
Share & tools
lore

Jon Mason

author
#0 lore raw

PATCH v2 1/1 CI: define DEFAULT_TAG and CPU_REQUEST

DEFAULT_TAG and CPU_REQUEST are being used to help with internal Gitlab pipeline setups know which type of machines to run on, but has no value outside of Arm Corp. Gitlab CI allows for variables to be overridden by default. So, we can give it a default value of NULL/empty and have everything work internally and externally by default.

---
 .gitlab-ci.yml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
.gitlab-ci.yml +4 -2
index 6ee42315..cc5710c2 100644
@@ -1,8 +1,10 @@
 image: ghcr.io/siemens/kas/kas:latest-release
 
-# These are needed as the k8s executor doesn't respect the container entrypoint
-# by default
 variables:
+  CPU_REQUEST: ""
+  DEFAULT_TAG: ""
+  # These are needed as the k8s executor doesn't respect the container entrypoint
+  # by default
   FF_USE_LEGACY_KUBERNETES_EXECUTION_STRATEGY: 0
   FF_KUBERNETES_HONOR_ENTRYPOINT: 1
 
Signature · 1 line
2.17.1
Applied
#1 lore raw
Quoted 5 lines · Jon Mason

DEFAULT_TAG and CPU_REQUEST are being used to help with internal Gitlab pipeline setups know which type of machines to run on, but has no value outside of Arm Corp. Gitlab CI allows for variables to be overridden by default. So, we can give it a default value of NULL/empty and have everything work internally and externally by default.

Applied, thanks!

[1/1] CI: define DEFAULT_TAG and CPU_REQUEST

      commit: c32c4043ff6fade1ec96ce1381512fbf7ce771e5

Best regards,

Signature · 1 line
Jon Mason <[email protected]>