drm/tests: reduce drm_mm_test stack usage
Subsystems (2)
PATCH 1/1 drm/tests: reduce drm_mm_test stack usage
From: Arnd Bergmann <[email protected]>
The check_reserve_boundaries function uses a lot of kernel stack, and it gets inlined by clang, which makes __drm_test_mm_reserve use even more of it, to the point of hitting the warning limit:
drivers/gpu/drm/tests/drm_mm_test.c:344:12: error: stack frame size (1048) exceeds limit (1024) in '__drm_test_mm_reserve' [-Werror,-Wframe-larger-than]
When building with gcc, this does not happen, but the structleak plugin can similarly increase the stack usage and needs to be disabled, as we do for all other kunit users.
--- drivers/gpu/drm/tests/Makefile | 2 ++ drivers/gpu/drm/tests/drm_mm_test.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/tests/Makefile +2 -0
@@ -12,3 +12,5 @@ obj-$(CONFIG_DRM_KUNIT_TEST) += \ drm_mm_test.o \ drm_plane_helper_test.o \ drm_rect_test.o + +CFLAGS_drm_mm_test.o := $(DISABLE_STRUCTLEAK_PLUGIN)
drivers/gpu/drm/tests/drm_mm_test.c +1 -1
@@ -298,7 +298,7 @@ static bool expect_reserve_fail(struct kunit *test, struct drm_mm *mm, struct drreturn false; } -static bool check_reserve_boundaries (struct kunit *test,struct drm_mm *mm, +static bool noinline_for_stack check_reserve_boundaries(struct kunit *test, struct drm_mm *mm,unsigned int count,u64 size) {
Signature · 1 line
2.35.1
Quoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The
check_reserve_boundariesfunction uses a lot of kernel stack, and it gets inlined by clang, which makes__drm_test_mm_reserveuse even more of it, to the point of hitting the warning limit:
Quoted 7 lines
drivers/gpu/drm/tests/drm_mm_test.c:344:12: error: stack frame size (1048) exceeds limit (1024) in '__drm_test_mm_reserve' [-Werror,-Wframe-larger-than]When building with gcc, this does not happen, but the structleak plugin can similarly increase the stack usage and needs to be disabled, as we do for all other kunit users.
Signed-off-by Arnd Bergmann <[email protected]>
Quoted 31 lines
--- drivers/gpu/drm/tests/Makefile | 2 ++ drivers/gpu/drm/tests/drm_mm_test.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)drivers/gpu/drm/tests/Makefile +2
-0@@ -12,3 +12,5 @@ obj-$(CONFIG_DRM_KUNIT_TEST) += \ drm_mm_test.o \ drm_plane_helper_test.o \ drm_rect_test.o + +CFLAGS_drm_mm_test.o := $(DISABLE_STRUCTLEAK_PLUGIN)drivers/gpu/drm/tests/drm_mm_test.c +1
-1@@ -298,7 +298,7 @@ static bool expect_reserve_fail(struct kunit *test, struct drm_mm *mm, struct drreturn false; } -static bool check_reserve_boundaries (struct kunit *test,struct drm_mm *mm, +static bool noinline_for_stack check_reserve_boundaries(struct kunit *test, struct drm_mm *mm,unsigned int count,u64 size) {Signature · 1 line
2.35.1
Quoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The
check_reserve_boundariesfunction uses a lot of kernel stack, and it gets inlined by clang, which makes__drm_test_mm_reserveuse even more of it, to the point of hitting the warning limit:
Quoted 7 lines
drivers/gpu/drm/tests/drm_mm_test.c:344:12: error: stack frame size (1048) exceeds limit (1024) in '__drm_test_mm_reserve' [-Werror,-Wframe-larger-than]When building with gcc, this does not happen, but the structleak plugin can similarly increase the stack usage and needs to be disabled, as we do for all other kunit users.
Signed-off-by Arnd Bergmann <[email protected]>
Apart from the checkpatch problem on the functioncheck_reserve_boundaries(),
Best Regards,
- Maíra Canal
Quoted 28 lines
--- drivers/gpu/drm/tests/Makefile | 2 ++ drivers/gpu/drm/tests/drm_mm_test.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)drivers/gpu/drm/tests/Makefile +2
-0@@ -12,3 +12,5 @@ obj-$(CONFIG_DRM_KUNIT_TEST) += \ drm_mm_test.o \ drm_plane_helper_test.o \ drm_rect_test.o + +CFLAGS_drm_mm_test.o := $(DISABLE_STRUCTLEAK_PLUGIN)drivers/gpu/drm/tests/drm_mm_test.c +1
-1@@ -298,7 +298,7 @@ static bool expect_reserve_fail(struct kunit *test, struct drm_mm *mm, struct drreturn false; } -static bool check_reserve_boundaries (struct kunit *test,struct drm_mm *mm, +static bool noinline_for_stack check_reserve_boundaries(struct kunit *test, struct drm_mm *mm,unsigned int count,u64 size) {
Maíra Canal
AppliedQuoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The
check_reserve_boundariesfunction uses a lot of kernel stack, and it gets inlined by clang, which makes__drm_test_mm_reserveuse even more of it, to the point of hitting the warning limit:
Quoted 7 lines
drivers/gpu/drm/tests/drm_mm_test.c:344:12: error: stack frame size (1048) exceeds limit (1024) in '__drm_test_mm_reserve' [-Werror,-Wframe-larger-than]When building with gcc, this does not happen, but the structleak plugin can similarly increase the stack usage and needs to be disabled, as we do for all other kunit users.
Signed-off-by Arnd Bergmann <[email protected]>
Applied it to drm-misc-next-fixes with the small checkpatch fix.
Best Regards,
- Maíra Canal