pinctrl: nomadik: include linux/seq_file.h
Subsystems (3)
PATCH 1/1 pinctrl: nomadik: include linux/seq_file.h
From: Arnd Bergmann <[email protected]>
In some randconfig builds, the missing #include causes a build failure:
drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip':drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]
1084 | seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank,
| ^~~~~~~~~~
| bstr_printf--- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 + 1 file changed, 1 insertion(+)
drivers/pinctrl/nomadik/pinctrl-nomadik.c +1 -0
@@ -17,6 +17,7 @@#include <linux/gpio/driver.h> #include <linux/spinlock.h> #include <linux/interrupt.h> +#include <linux/seq_file.h> #include <linux/slab.h> #include <linux/of_device.h> #include <linux/of_address.h>
Signature · 1 line
2.35.1
Quoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
In some randconfig builds, the missing #include causes a build failure:
drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip':drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]1084 | seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank, | ^~~~~~~~~~ | bstr_printf
Hmm... Strange that I have not noticed this from CIs. Nevertheless, I have a patch that adds more missing headers to this driver. I have planned to send it after v6.2-rc1.
I'm fine if this goes first. Up to Linus.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 12 lines · Andy Shevchenko
Quoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
In some randconfig builds, the missing #include causes a build failure:
drivers/pinctrl/nomadik/pinctrl-nomadik.c: In function 'nmk_gpio_irq_print_chip':drivers/pinctrl/nomadik/pinctrl-nomadik.c:1084:9: error: implicit declaration of function 'seq_printf'; did you mean 'bstr_printf'? [-Werror=implicit-function-declaration]1084 | seq_printf(p, "nmk%u-%u-%u", nmk_chip->bank, | ^~~~~~~~~~ | bstr_printf
Quoted 6 lines
Hmm... Strange that I have not noticed this from CIs. Nevertheless, I have a patch that adds more missing headers to this driver. I have planned to send it after v6.2-rc1.
I'm fine if this goes first. Up to Linus.
FYI: I have just sent my version
https://lore.kernel.org/r/[email protected]
Signature · 2 lines
With Best Regards, Andy Shevchenko