Skip to contentSkip to conversation

dt-bindings: arm: Split i.MX8M Mini Toradex Verdin based boards

PATCH In review Marek Vasut 3 participants 12 messages Dec 15, 2022 – Dec 16, 2022 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/4 dt-bindings: arm: Split i.MX8M Mini Toradex Verdin based boards

The Toradex Verdin based boards have compatible string in the form:
"vendor,custom-board", "toradex,som", "fsl,soc"
Split the binding entry so this triplet can be matched on.

---
Cc: Fabio Estevam <[email protected]>
Cc: Francesco Dolcini <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Marcel Ziswiler <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: [email protected]
To: [email protected]

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/fsl.yaml +6 -1
index 05b5276a0e14c..8dda0e25b99e4 100644
@@ -830,7 +830,6 @@ properties:
               - innocomm,wb15-evk         # i.MX8MM Innocomm EVK board with WB15 SoM
               - kontron,imx8mm-sl         # i.MX8MM Kontron SL (N801X) SOM
               - kontron,imx8mm-osm-s      # i.MX8MM Kontron OSM-S (N802X) SOM
-              - menlo,mx8menlo            # i.MX8MM Menlo board with Verdin SoM
               - toradex,verdin-imx8mm     # Verdin iMX8M Mini Modules
               - toradex,verdin-imx8mm-nonwifi  # Verdin iMX8M Mini Modules without Wi-Fi / BT
               - toradex,verdin-imx8mm-wifi  # Verdin iMX8M Mini Wi-Fi / BT Modules
@@ -838,6 +837,12 @@ properties:
               - prt,prt8mm                # i.MX8MM Protonic PRT8MM Board
           - const: fsl,imx8mm
 
+      - description: Verdin iMX8M Mini Module based Boards
+        items:
+          - const: menlo,mx8menlo         # i.MX8MM Menlo board with Verdin SoM
+          - const: toradex,verdin-imx8mm  # Verdin iMX8M Mini Modules
+          - const: fsl,imx8mm
+
       - description: Engicam i.Core MX8M Mini SoM based boards
         items:
           - enum:
Signature · 1 line
2.35.1
#1 lore raw

PATCH 2/4 dt-bindings: arm: Split i.MX8M Mini NITROGEN SoM based boards

The NITROGEN SoM based boards have compatible string in the form:
"vendor,custom-board", "boundary,som", "fsl,soc"
Split the binding entry so this triplet can be matched on.

---
Cc: Alexander Stein <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Lucas Stach <[email protected]>
Cc: Marcel Ziswiler <[email protected]>
Cc: Markus Niebel <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Pengutronix Kernel Team <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Sascha Hauer <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: [email protected]
To: [email protected]

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/fsl.yaml +6 -1
index 8dda0e25b99e4..8dfbf861a99b7 100644
@@ -1004,12 +1004,17 @@ properties:
               - fsl,imx8mq-evk            # i.MX8MQ EVK Board
               - google,imx8mq-phanbell    # Google Coral Edge TPU
               - kontron,pitx-imx8m        # Kontron pITX-imx8m Board
-              - mntre,reform2             # MNT Reform2 Laptop
               - purism,librem5-devkit     # Purism Librem5 devkit
               - solidrun,hummingboard-pulse # SolidRun Hummingboard Pulse
               - technexion,pico-pi-imx8m  # TechNexion PICO-PI-8M evk
           - const: fsl,imx8mq
 
+      - description: i.MX8MQ NITROGEN SoM based Boards
+        items:
+          - const: mntre,reform2                  # MNT Reform2 Laptop
+          - const: boundary,imx8mq-nitrogen8m-som # i.MX8MQ NITROGEN SoM
+          - const: fsl,imx8mq
+
       - description: Purism Librem5 phones
         items:
           - enum:
Signature · 1 line
2.35.1
#3 lore raw

PATCH 3/4 dt-bindings: arm: Split i.MX8M Plus DHCOM based boards

In reply to Marek Vasut

The i.MX8M Plus DHCOM based boards have compatible string in the form:
"vendor,custom-board", "dh,som", "fsl,soc"
or
"dh,carrier-board", "dh,som", "fsl,soc"
Split the binding entry so this triplet can be matched on.

---
Cc: Christoph Niedermaier <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: [email protected]
Cc: [email protected]
To: [email protected]

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/arm/fsl.yaml +6 -2
index 8dfbf861a99b7..04f4179a52ab7 100644
@@ -936,8 +936,6 @@ properties:
       - description: i.MX8MP based Boards
         items:
           - enum:
-              - dh,imx8mp-dhcom-som       # i.MX8MP DHCOM SoM
-              - dh,imx8mp-dhcom-pdk2      # i.MX8MP DHCOM SoM on PDK2 board
               - fsl,imx8mp-evk            # i.MX8MP EVK Board
               - gateworks,imx8mp-gw74xx   # i.MX8MP Gateworks Board
               - toradex,verdin-imx8mp     # Verdin iMX8M Plus Modules
@@ -952,6 +950,12 @@ properties:
           - const: avnet,sm2s-imx8mp              # SM2S-IMX8PLUS SoM
           - const: fsl,imx8mp
 
+      - description: i.MX8MP DHCOM based Boards
+        items:
+          - const: dh,imx8mp-dhcom-pdk2      # i.MX8MP DHCOM SoM on PDK2 board
+          - const: dh,imx8mp-dhcom-som       # i.MX8MP DHCOM SoM
+          - const: fsl,imx8mp
+
       - description: Engicam i.Core MX8M Plus SoM based boards
         items:
           - enum:
Signature · 1 line
2.35.1
Acked-by on v1 3/4
#4 lore raw

Re: [PATCH 3/4] dt-bindings: arm: Split i.MX8M Plus DHCOM based boards

Quoted 7 lines · Marek Vasut

The i.MX8M Plus DHCOM based boards have compatible string in the form:
"vendor,custom-board", "dh,som", "fsl,soc"
or
"dh,carrier-board", "dh,som", "fsl,soc"
Split the binding entry so this triplet can be matched on.

Best regards,
Krzysztof

#5 lore raw

PATCH 4/4 dt-bindings: arm: Move i.MX8MM Cloos PHG Board to TQM entry

In reply to Marek Vasut

The i.MX8MM Cloos PHG Board is based on TQ-Systems GmbH i.MX8MM TQMa8MQML SOM, which results in compatible string in the form:
"vendor,custom-board", "tqm,som", "fsl,soc"
Move the binding entry so this triplet can be matched on.

---
Cc: Alexander Stein <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: [email protected]
To: [email protected]

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/fsl.yaml +1 -1
index 04f4179a52ab7..16609aa41f462 100644
@@ -815,7 +815,6 @@ properties:
           - enum:
               - beacon,imx8mm-beacon-kit  # i.MX8MM Beacon Development Kit
               - boundary,imx8mm-nitrogen8mm  # i.MX8MM Nitrogen Board
-              - cloos,imx8mm-phg          # i.MX8MM Cloos PHG Board
               - dmo,imx8mm-data-modul-edm-sbc # i.MX8MM eDM SBC
               - emtrion,emcon-mx8mm-avari # emCON-MX8MM SoM on Avari Base
               - fsl,imx8mm-ddr4-evk       # i.MX8MM DDR4 EVK Board
@@ -900,6 +899,7 @@ properties:
           one compatible is needed.
         items:
           - enum:
+              - cloos,imx8mm-phg           # i.MX8MM Cloos PHG Board
               - tq,imx8mm-tqma8mqml-mba8mx # TQ-Systems GmbH i.MX8MM TQMa8MQML SOM on MBa8Mx
           - const: tq,imx8mm-tqma8mqml     # TQ-Systems GmbH i.MX8MM TQMa8MQML SOM
           - const: fsl,imx8mm
Signature · 1 line
2.35.1
Acked-by on v1 4/4
#6 lore raw

Re: [PATCH 4/4] dt-bindings: arm: Move i.MX8MM Cloos PHG Board to TQM entry

Quoted 7 lines · Marek Vasut

The i.MX8MM Cloos PHG Board is based on TQ-Systems GmbH i.MX8MM TQMa8MQML SOM, which results in compatible string in the form:
"vendor,custom-board", "tqm,som", "fsl,soc"
Move the binding entry so this triplet can be matched on.

---

Best regards,
Krzysztof

#7 lore raw
In reply to Marek Vasut

Hello Marek

Quoted 33 lines · Marek Vasut

The Toradex Verdin based boards have compatible string in the form:
"vendor,custom-board", "toradex,som", "fsl,soc"
Split the binding entry so this triplet can be matched on.

---
Cc: Fabio Estevam <[email protected]>
Cc: Francesco Dolcini <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Marcel Ziswiler <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: [email protected]
To: [email protected]

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/fsl.yaml +0 -1
index 05b5276a0e14c..8dda0e25b99e4 100644
@@ -830,7 +830,6 @@ properties:
               - innocomm,wb15-evk         # i.MX8MM Innocomm EVK board with WB15 SoM
               - kontron,imx8mm-sl         # i.MX8MM Kontron SL (N801X) SOM
               - kontron,imx8mm-osm-s      # i.MX8MM Kontron OSM-S (N802X) SOM
-              - menlo,mx8menlo            # i.MX8MM Menlo board with Verdin SoM
               - toradex,verdin-imx8mm     # Verdin iMX8M Mini Modules
               - toradex,verdin-imx8mm-nonwifi  # Verdin iMX8M Mini Modules without Wi-Fi / BT
               - toradex,verdin-imx8mm-wifi  # Verdin iMX8M Mini Wi-Fi / BT Modules

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 840

Quoted 4 lines
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
@@ -838,6 +837,12 @@ properties:
               - prt,prt8mm                # i.MX8MM Protonic PRT8MM Board
           - const: fsl,imx8mm
 
+      - description: Verdin iMX8M Mini Module based Boards

I would expect here something like "i.MX8MM Menlo board with Verdin SoM", am I wrong?

Francesco

#8 lore raw
Quoted 1 line · Francesco Dolcini

Hello Marek

Hi,

Quoted 37 lines · Marek Vasut
Quoted 36 lines

The Toradex Verdin based boards have compatible string in the form:
"vendor,custom-board", "toradex,som", "fsl,soc"
Split the binding entry so this triplet can be matched on.

---
Cc: Fabio Estevam <[email protected]>
Cc: Francesco Dolcini <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Marcel Ziswiler <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: [email protected]
To: [email protected]

---
  Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/fsl.yaml +0 -1
index 05b5276a0e14c..8dda0e25b99e4 100644
@@ -830,7 +830,6 @@ properties:
                - innocomm,wb15-evk         # i.MX8MM Innocomm EVK board with WB15 SoM
                - kontron,imx8mm-sl         # i.MX8MM Kontron SL (N801X) SOM
                - kontron,imx8mm-osm-s      # i.MX8MM Kontron OSM-S (N802X) SOM
-              - menlo,mx8menlo            # i.MX8MM Menlo board with Verdin SoM
                - toradex,verdin-imx8mm     # Verdin iMX8M Mini Modules
                - toradex,verdin-imx8mm-nonwifi  # Verdin iMX8M Mini Modules without Wi-Fi / BT
                - toradex,verdin-imx8mm-wifi  # Verdin iMX8M Mini Wi-Fi / BT Modules
@@ -838,6 +837,12 @@ properties:
                - prt,prt8mm                # i.MX8MM Protonic PRT8MM Board
            - const: fsl,imx8mm
 
Quoted 2 lines

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 840

Quoted 1 line
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
+      - description: Verdin iMX8M Mini Module based Boards

I would expect here something like "i.MX8MM Menlo board with Verdin SoM", am I wrong?

Partly wrong, look at 4/4 patch in this series for how this would grow once more boards based on the Verdin SoM would be added. The first -const: would turn into enum, the remaining two -const: would remain (different carrier board, same SoM, same SoC).

#9 lore raw
Quoted 44 lines · Marek Vasut
Quoted 1 line · Francesco Dolcini

Hello Marek

Hi,

Quoted 30 lines · Marek Vasut
Quoted 29 lines

The Toradex Verdin based boards have compatible string in the form:
"vendor,custom-board", "toradex,som", "fsl,soc"
Split the binding entry so this triplet can be matched on.

---
Cc: Fabio Estevam <[email protected]>
Cc: Francesco Dolcini <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Marcel Ziswiler <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: [email protected]
To: [email protected]

---
  Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/fsl.yaml +0 -1
index 05b5276a0e14c..8dda0e25b99e4 100644
@@ -830,7 +830,6 @@ properties:
                - innocomm,wb15-evk         # i.MX8MM Innocomm EVK board with WB15 SoM
                - kontron,imx8mm-sl         # i.MX8MM Kontron SL (N801X) SOM
                - kontron,imx8mm-osm-s      # i.MX8MM Kontron OSM-S (N802X) SOM
-              - menlo,mx8menlo            # i.MX8MM Menlo board with Verdin SoM
Quoted 8 lines

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 839

Quoted 7 lines
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
                - toradex,verdin-imx8mm     # Verdin iMX8M Mini Modules
                - toradex,verdin-imx8mm-nonwifi  # Verdin iMX8M Mini Modules without Wi-Fi / BT
                - toradex,verdin-imx8mm-wifi  # Verdin iMX8M Mini Wi-Fi / BT Modules
@@ -838,6 +837,12 @@ properties:
                - prt,prt8mm                # i.MX8MM Protonic PRT8MM Board
            - const: fsl,imx8mm
+      - description: Verdin iMX8M Mini Module based Boards

I would expect here something like "i.MX8MM Menlo board with Verdin SoM", am I wrong?

Quoted 4 lines

Partly wrong, look at 4/4 patch in this series for how this would grow once more boards based on the Verdin SoM would be added. The first -const: would turn into enum, the remaining two -const: would remain (different carrier board, same SoM, same SoC).

Shouldn't you than add it to existing Toradex Boards with Verdin iMX8M Mini Modules one as a new entry to the existing enum? Maybe the current name is not ideal if we do something like that and should become Boards using Toradex Verdin iMX8M Mini Modules if we add menlo to it ?

Francesco

#10 lore raw
Quoted 50 lines · Francesco Dolcini
Quoted 44 lines · Marek Vasut
Quoted 1 line · Francesco Dolcini

Hello Marek

Hi,

Quoted 30 lines · Marek Vasut
Quoted 29 lines

The Toradex Verdin based boards have compatible string in the form:
"vendor,custom-board", "toradex,som", "fsl,soc"
Split the binding entry so this triplet can be matched on.

---
Cc: Fabio Estevam <[email protected]>
Cc: Francesco Dolcini <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Marcel Ziswiler <[email protected]>
Cc: Peng Fan <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: [email protected]
To: [email protected]

---
   Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
   1 file changed, 6 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/arm/fsl.yaml +0 -1
index 05b5276a0e14c..8dda0e25b99e4 100644
@@ -830,7 +830,6 @@ properties:
                 - innocomm,wb15-evk         # i.MX8MM Innocomm EVK board with WB15 SoM
                 - kontron,imx8mm-sl         # i.MX8MM Kontron SL (N801X) SOM
                 - kontron,imx8mm-osm-s      # i.MX8MM Kontron OSM-S (N802X) SOM
-              - menlo,mx8menlo            # i.MX8MM Menlo board with Verdin SoM
Quoted 8 lines

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 839

Quoted 7 lines
Documentation/devicetree/bindings/arm/fsl.yaml +1 -0
                 - toradex,verdin-imx8mm     # Verdin iMX8M Mini Modules
                 - toradex,verdin-imx8mm-nonwifi  # Verdin iMX8M Mini Modules without Wi-Fi / BT
                 - toradex,verdin-imx8mm-wifi  # Verdin iMX8M Mini Wi-Fi / BT Modules
@@ -838,6 +837,12 @@ properties:
                 - prt,prt8mm                # i.MX8MM Protonic PRT8MM Board
             - const: fsl,imx8mm
+      - description: Verdin iMX8M Mini Module based Boards

I would expect here something like "i.MX8MM Menlo board with Verdin SoM", am I wrong?

Quoted 4 lines

Partly wrong, look at 4/4 patch in this series for how this would grow once more boards based on the Verdin SoM would be added. The first -const: would turn into enum, the remaining two -const: would remain (different carrier board, same SoM, same SoC).

Quoted 4 lines

Shouldn't you than add it to existing Toradex Boards with Verdin iMX8M Mini Modules one as a new entry to the existing enum? Maybe the current name is not ideal if we do something like that and should become Boards using Toradex Verdin iMX8M Mini Modules if we add menlo to it ?

I should, I missed that, will be fixed in V2, thanks.