Skip to contentSkip to conversation

drm/plane-helper: Add the missing declaration of drm_atomic_state

PATCH In review Ma Jun 2 participants 2 messages Dec 16, 2022

Subsystems (2)
lore
Share & tools
lore

Ma Jun

author
#0 lore raw

PATCH v2 1/1 drm/plane-helper: Add the missing declaration of drm_atomic_state

Add the missing declaration of struct drm_atomic_state to fix the compile error below:

error: 'struct drm_atomic_state' declared inside parameter
list will not be visible outside of this definition or declaration [-Werror]

---
 include/drm/drm_plane_helper.h | 1 +
 1 file changed, 1 insertion(+)
include/drm/drm_plane_helper.h +1 -0
index b00ad36cf5b6..90156e13ac11 100644
@@ -26,6 +26,7 @@
 
 #include <linux/types.h>
 
+struct drm_atomic_state;
 struct drm_crtc;
 struct drm_framebuffer;
 struct drm_modeset_acquire_ctx;
Signature · 1 line
2.25.1
#1 lore raw

Hi

Am 16.12.22 um 04:05 schrieb Ma Jun:

Quoted 7 lines

Add the missing declaration of struct drm_atomic_state to fix the compile error below:

error: 'struct drm_atomic_state' declared inside parameter
list will not be visible outside of this definition or declaration [-Werror]

Thanks. I added a Fixes tag and merged the patch into drm-misc-fixes.

Best regards
Thomas

Quoted 16 lines
---
  include/drm/drm_plane_helper.h | 1 +
  1 file changed, 1 insertion(+)
include/drm/drm_plane_helper.h +1 -0
index b00ad36cf5b6..90156e13ac11 100644
@@ -26,6 +26,7 @@
 
  #include <linux/types.h>
 
+struct drm_atomic_state;
  struct drm_crtc;
  struct drm_framebuffer;
  struct drm_modeset_acquire_ctx;
Signature · 6 lines
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev