Skip to contentSkip to conversation

net/i40e: reduce the ITR interval of multi-driver mode

PATCH Applied Qiming Yang 3 participants 4 messages Dec 16, 2022 – Feb 23, 2023 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/i40e: reduce the ITR interval of multi-driver mode

This patch change the interrupt interval from 8160us to 32us to improve the performance of multi-driver mode.

---
 drivers/net/i40e/i40e_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.h +1 -1
index fe943a45ff..7c4cc44a27 100644
@@ -1497,7 +1497,7 @@ i40e_calc_itr_interval(bool is_pf, bool is_multi_drv)
 	uint16_t interval = 0;
 
 	if (is_multi_drv) {
-		interval = I40E_QUEUE_ITR_INTERVAL_MAX;
+		interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT;
 	} else {
 		if (is_pf)
 			interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT;
Signature · 1 line
2.25.1
Acked-by on v1 1/1 Applied
#1 lore raw
Quoted 9 lines

-----Original Message-----
From: Qiming Yang <[email protected]>
Sent: Friday, December 16, 2022 11:12 AM
To: [email protected]; Xing, Beilei <[email protected]>
Cc: Yang, Qiming <[email protected]>
Subject: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode

Quoted 4 lines

This patch change the interrupt interval from 8160us to 32us to improve the performance of multi-driver mode.

Applied to dpdk-next-net-intel.

The patch also looks good for backporting, so added Cc stable tag.

Thanks
Qi

Quoted 19 lines
---
 drivers/net/i40e/i40e_ethdev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.h +1 -2
index fe943a45ff..7c4cc44a27 100644
@@ -1497,7 +1497,7 @@ i40e_calc_itr_interval(bool is_pf, bool is_multi_drv)
 	uint16_t interval = 0;
 
 	if (is_multi_drv) {
-		interval = I40E_QUEUE_ITR_INTERVAL_MAX;
+		interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT;
 	} else {
 		if (is_pf)
 			interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT;
--

2.25.1

#2 lore raw
Quoted 12 lines · Qi Z
Quoted 12 lines

-----Original Message-----
From: Qiming Yang <[email protected]>
Sent: Friday, December 16, 2022 11:12 AM
To: [email protected]; Xing, Beilei <[email protected]>
Cc: Yang, Qiming <[email protected]>
Subject: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode

This patch change the interrupt interval from 8160us to 32us to improve the performance of multi-driver mode.

Quoted 8 lines
Quoted 1 line

Applied to dpdk-next-net-intel.

The patch also looks good for backporting, so added Cc stable tag.

Hi. This looks like it is not fixing anything and it is changing a behaviour, so I won't take for 21.11.4.

thanks,
Kevin.

Quoted 24 lines

Thanks
Qi

Quoted 19 lines
---
  drivers/net/i40e/i40e_ethdev.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/i40e/i40e_ethdev.h +1 -2
index fe943a45ff..7c4cc44a27 100644
@@ -1497,7 +1497,7 @@ i40e_calc_itr_interval(bool is_pf, bool is_multi_drv)
  	uint16_t interval = 0;
 
  	if (is_multi_drv) {
-		interval = I40E_QUEUE_ITR_INTERVAL_MAX;
+		interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT;
  	} else {
  		if (is_pf)
  			interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT;
--

2.25.1

#3 lore raw
Quoted 29 lines

-----Original Message-----
From: Kevin Traynor <[email protected]>
Sent: Thursday, February 23, 2023 12:49 AM
To: Zhang, Qi Z <[email protected]>; Yang, Qiming <[email protected]>; [email protected]; Xing, Beilei <[email protected]>; Xueming(Steven) Li <[email protected]>; Luca Boccassi <[email protected]>
Subject: Re: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode

Quoted 17 lines · Qi Z
Quoted 10 lines

-----Original Message-----
From: Qiming Yang <[email protected]>
Sent: Friday, December 16, 2022 11:12 AM
To: [email protected]; Xing, Beilei <[email protected]>
Cc: Yang, Qiming <[email protected]>
Subject: [PATCH] net/i40e: reduce the ITR interval of multi-driver mode

Quoted 4 lines

This patch change the interrupt interval from 8160us to 32us to improve the performance of multi-driver mode.

Quoted 7 lines
Quoted 4 lines

Applied to dpdk-next-net-intel.

The patch also looks good for backporting, so added Cc stable tag.

Hi. This looks like it is not fixing anything and it is changing a behaviour, so I won't take for 21.11.4.

This comes from customer issue, it does fix for the usage when latency is critical, will be nice if it can be applied, thanks.

Quoted 29 lines

thanks,
Kevin.

Quoted 8 lines

Thanks
Qi

Quoted 4 lines
---
  drivers/net/i40e/i40e_ethdev.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines

drivers/net/i40e/i40e_ethdev.h i40e_calc_itr_interval(bool is_pf, bool

Quoted 5 lines
(quoted diff) +0 -0

b/drivers/net/i40e/i40e_ethdev.h index fe943a45ff..7c4cc44a27 100644

drivers/net/i40e/i40e_ethdev.h +0 -0
@@ -1497,7 +1497,7 @@ i40e_calc_itr_interval(bool is_pf, bool

is_multi_drv)

Quoted 11 lines
Quoted 10 lines
drivers/net/i40e/i40e_ethdev.h +1 -2
  	uint16_t interval = 0;
 
  	if (is_multi_drv) {
-		interval = I40E_QUEUE_ITR_INTERVAL_MAX;
+		interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT;
  	} else {
  		if (is_pf)
  			interval = I40E_QUEUE_ITR_INTERVAL_DEFAULT;
--

2.25.1