Skip to contentSkip to conversation

drm/amdgpu: skip MES for S0ix as well since it's part of GFX

PATCH In review Alex Deucher 2 participants 2 messages Dec 16, 2022

Subsystems (2)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/1 drm/amdgpu: skip MES for S0ix as well since it's part of GFX

It's also part of gfxoff.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +3 -2
index 582a80a9850e..e4609b8d574c 100644
@@ -3018,14 +3018,15 @@ static int amdgpu_device_ip_suspend_phase2(struct amdgpu_device *adev)
 			continue;
 		}
 
-		/* skip suspend of gfx and psp for S0ix
+		/* skip suspend of gfx/mes and psp for S0ix
 		 * gfx is in gfxoff state, so on resume it will exit gfxoff just
 		 * like at runtime. PSP is also part of the always on hardware
 		 * so no need to suspend it.
 		 */
 		if (adev->in_s0ix &&
 		    (adev->ip_blocks[i].version->type == AMD_IP_BLOCK_TYPE_PSP ||
-		     adev->ip_blocks[i].version->type == AMD_IP_BLOCK_TYPE_GFX))
+		     adev->ip_blocks[i].version->type == AMD_IP_BLOCK_TYPE_GFX ||
+		     adev->ip_blocks[i].version->type == AMD_IP_BLOCK_TYPE_MES))
 			continue;
 
 		/* SDMA 5.x+ is part of GFX power domain so it's covered by GFXOFF */
Signature · 1 line
2.38.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Alex Deucher

It's also part of gfxoff.

Even without the other series this alone has been shown to improve things for the affected ASIC, so it should probably go to stable.

Cc [email protected] # 6.0, 6.1
Quoted 26 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +3 -2
index 582a80a9850e..e4609b8d574c 100644
@@ -3018,14 +3018,15 @@ static int amdgpu_device_ip_suspend_phase2(struct amdgpu_device *adev)
  			continue;
  		}
 
-		/* skip suspend of gfx and psp for S0ix
+		/* skip suspend of gfx/mes and psp for S0ix
  		 * gfx is in gfxoff state, so on resume it will exit gfxoff just
  		 * like at runtime. PSP is also part of the always on hardware
  		 * so no need to suspend it.
  		 */
  		if (adev->in_s0ix &&
  		    (adev->ip_blocks[i].version->type == AMD_IP_BLOCK_TYPE_PSP ||
-		     adev->ip_blocks[i].version->type == AMD_IP_BLOCK_TYPE_GFX))
+		     adev->ip_blocks[i].version->type == AMD_IP_BLOCK_TYPE_GFX ||
+		     adev->ip_blocks[i].version->type == AMD_IP_BLOCK_TYPE_MES))
  			continue;
 
  		/* SDMA 5.x+ is part of GFX power domain so it's covered by GFXOFF */