Skip to contentSkip to conversation

dt-bindings: usb: tegra-xusb: Remove path references

PATCH In review Thierry Reding 4 participants 6 messages Nov 30, 2022 – Dec 21, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: usb: tegra-xusb: Remove path references

From: Thierry Reding <[email protected]>

Unresolved path references are now flagged as errors when checking the device tree binding examples, so convert them into label references.

---
 .../devicetree/bindings/usb/nvidia,tegra124-xusb.yaml     | 4 +---
 .../devicetree/bindings/usb/nvidia,tegra186-xusb.yaml     | 4 +---
 .../devicetree/bindings/usb/nvidia,tegra194-xusb.yaml     | 8 ++------
 .../devicetree/bindings/usb/nvidia,tegra210-xusb.yaml     | 8 ++------
 4 files changed, 6 insertions(+), 18 deletions(-)
Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.yaml +1 -3
index 4a6616bf9bab..d6ca8c93073d 100644
@@ -186,9 +186,7 @@ examples:
 
         nvidia,xusb-padctl = <&padctl>;
 
-        phys = <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-1}>, /* mini-PCIe USB */
-               <&{/padctl@0,7009f000/pads/usb2/lanes/usb2-2}>, /* USB A */
-               <&{/padctl@0,7009f000/pads/pcie/lanes/pcie-0}>; /* USB A */
+        phys = <&phy_usb2_1>, <&phy_usb2_2>, <&phy_pcie_0>;
         phy-names = "usb2-1", "usb2-2", "usb3-0";
 
         avddio-pex-supply = <&vdd_1v05_run>;
Documentation/devicetree/bindings/usb/nvidia,tegra186-xusb.yaml +1 -3
index 6f62944fc597..a04c6ce1e0f6 100644
@@ -166,8 +166,6 @@ examples:
         #address-cells = <1>;
         #size-cells = <0>;
 
-        phys = <&{/padctl@3520000/pads/usb2/lanes/usb2-0}>,
-               <&{/padctl@3520000/pads/usb2/lanes/usb2-1}>,
-               <&{/padctl@3520000/pads/usb3/lanes/usb3-0}>;
+        phys = <&phy_usb2_0>, <&phy_usb2_1>, <&phy_usb3_0>;
         phy-names = "usb2-0", "usb2-1", "usb3-0";
     };
Documentation/devicetree/bindings/usb/nvidia,tegra194-xusb.yaml +2 -6
index 65ae9ae9b0b7..b356793f73a1 100644
@@ -169,11 +169,7 @@ examples:
 
         nvidia,xusb-padctl = <&xusb_padctl>;
 
-        phys = <&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-0}>,
-               <&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-1}>,
-               <&{/bus@0/padctl@3520000/pads/usb2/lanes/usb2-3}>,
-               <&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-0}>,
-               <&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-2}>,
-               <&{/bus@0/padctl@3520000/pads/usb3/lanes/usb3-3}>;
+        phys = <&phy_usb2_0>, <&phy_usb2_1>, <&phy_usb2_3>, <&phy_usb3_0>,
+               <&phy_usb3_2>, <&phy_usb3_3>;
         phy-names = "usb2-0", "usb2-1", "usb2-3", "usb3-0", "usb3-2", "usb3-3";
     };
Documentation/devicetree/bindings/usb/nvidia,tegra210-xusb.yaml +2 -6
index da1e1ec0e7c8..90296613b3a5 100644
@@ -173,12 +173,8 @@ examples:
 
         nvidia,xusb-padctl = <&padctl>;
 
-        phys = <&{/padctl@7009f000/pads/usb2/lanes/usb2-0}>,
-               <&{/padctl@7009f000/pads/usb2/lanes/usb2-1}>,
-               <&{/padctl@7009f000/pads/usb2/lanes/usb2-2}>,
-               <&{/padctl@7009f000/pads/usb2/lanes/usb2-3}>,
-               <&{/padctl@7009f000/pads/pcie/lanes/pcie-6}>,
-               <&{/padctl@7009f000/pads/pcie/lanes/pcie-5}>;
+        phys = <&phy_usb2_0>, <&phy_usb2_1>, <&phy_usb2_2>, <&phy_usb2_3>,
+               <&phy_pcie_6>, <&phy_pcie_5>;
         phy-names = "usb2-0", "usb2-1", "usb2-2", "usb2-3", "usb3-0",
                     "usb3-1";
         dvddio-pex-supply = <&vdd_pex_1v05>;
Signature · 1 line
2.38.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Unresolved path references are now flagged as errors when checking the device tree binding examples, so convert them into label references.

---

Best regards,
Krzysztof

Tested-by on v1 1/1
#2 lore raw
In reply to Thierry Reding
Quoted 8 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Unresolved path references are now flagged as errors when checking the device tree binding examples, so convert them into label references.

This fixes "make dt_binding_check" for me, so

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Thierry Reding
Quoted 8 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Unresolved path references are now flagged as errors when checking the device tree binding examples, so convert them into label references.

Quoted 6 lines
---
 .../devicetree/bindings/usb/nvidia,tegra124-xusb.yaml     | 4 +---
 .../devicetree/bindings/usb/nvidia,tegra186-xusb.yaml     | 4 +---
 .../devicetree/bindings/usb/nvidia,tegra194-xusb.yaml     | 8 ++------
 .../devicetree/bindings/usb/nvidia,tegra210-xusb.yaml     | 8 ++------
 4 files changed, 6 insertions(+), 18 deletions(-)
maintainer
#4 lore raw
In reply to Thierry Reding
Quoted 8 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Unresolved path references are now flagged as errors when checking the device tree binding examples, so convert them into label references.

Quoted 6 lines
---
 .../devicetree/bindings/usb/nvidia,tegra124-xusb.yaml     | 4 +---
 .../devicetree/bindings/usb/nvidia,tegra186-xusb.yaml     | 4 +---
 .../devicetree/bindings/usb/nvidia,tegra194-xusb.yaml     | 8 ++------
 .../devicetree/bindings/usb/nvidia,tegra210-xusb.yaml     | 8 ++------
 4 files changed, 6 insertions(+), 18 deletions(-)

As this is the only binding issue remaining in Linus's tree and it's the only thing in the Tegra tree, I've applied it for rc1.

Rob

#5 lore raw
Quoted 16 lines · Rob Herring
Quoted 8 lines · Thierry Reding

From: Thierry Reding <[email protected]>

Unresolved path references are now flagged as errors when checking the device tree binding examples, so convert them into label references.

Quoted 6 lines
---
 .../devicetree/bindings/usb/nvidia,tegra124-xusb.yaml     | 4 +---
 .../devicetree/bindings/usb/nvidia,tegra186-xusb.yaml     | 4 +---
 .../devicetree/bindings/usb/nvidia,tegra194-xusb.yaml     | 8 ++------
 .../devicetree/bindings/usb/nvidia,tegra210-xusb.yaml     | 8 ++------
 4 files changed, 6 insertions(+), 18 deletions(-)
Quoted 2 lines

As this is the only binding issue remaining in Linus's tree and it's the only thing in the Tegra tree, I've applied it for rc1.

I was waiting for more fixes to come in before sending out another PR, but nothing else showed up, so taking this through your tree makes more sense.

Thanks,
Thierry