Skip to contentSkip to conversation

scripts: kconfig: Added static text for search information in help menu

PATCH In review Bhaskar Chowdhury 4 participants 4 messages Dec 17, 2022 – Dec 29, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 scripts: kconfig: Added static text for search information in help menu

Reconstructed the sentence for the better readability.

---
Changes from V2: Inducted Randy's suggestion to make it more readable.

 scripts/kconfig/mconf.c | 6 ++++++
 1 file changed, 6 insertions(+)
scripts/kconfig/mconf.c +6 -0
index 9d3cf510562f..760ebf6c20b1 100644
@@ -161,6 +161,12 @@ static const char mconf_readme[] =
 "(especially with a larger number of unrolled categories) than the\n"
 "default mode.\n"
 "\n"
+
+"Search\n"
+"-------\n"
+"Pressing the forward-slash (/) anywhere brings up a search dialog box.\n"
+"\n"
+
 "Different color themes available\n"
 "--------------------------------\n"
 "It is possible to select different color themes using the variable\n"

--
2.38.1

Acked-by on v3 1/1
#1 lore raw
Quoted 3 lines · Bhaskar Chowdhury

Reconstructed the sentence for the better readability.

Quoted 25 lines

---
Changes from V2: Inducted Randy's suggestion to make it more readable.

 scripts/kconfig/mconf.c | 6 ++++++
 1 file changed, 6 insertions(+)
scripts/kconfig/mconf.c +6 -1
index 9d3cf510562f..760ebf6c20b1 100644
@@ -161,6 +161,12 @@ static const char mconf_readme[] =
 "(especially with a larger number of unrolled categories) than the\n"
 "default mode.\n"
 "\n"
+
+"Search\n"
+"-------\n"
+"Pressing the forward-slash (/) anywhere brings up a search dialog box.\n"
+"\n"
+
 "Different color themes available\n"
 "--------------------------------\n"
 "It is possible to select different color themes using the variable\n"
--

2.38.1

Signature · 1 line
~Randy
#2 lore raw
In reply to Bhaskar Chowdhury
Quoted 3 lines · Bhaskar Chowdhury

Reconstructed the sentence for the better readability.

I liked the commit message your v1 much better (minimally changed):

Quoted 2 lines

Add few static text to explain how one can bring up the search dialog box by pressing the forward slash key anywhere on this interface.

Would you mind updating it once again?

Kind regards,
Nicolas

#3 lore raw
Quoted 6 lines · Nicolas Schier
Quoted 3 lines · Bhaskar Chowdhury

Reconstructed the sentence for the better readability.

Quoted 8 lines

I liked the commit message your v1 much better (minimally changed):

Quoted 2 lines

Add few static text to explain how one can bring up the search dialog box by pressing the forward slash key anywhere on this interface.

Would you mind updating it once again?

Kind regards,
Nicolas

I replaced the commit description with v1's one,
and applied.
Thanks.

Signature · 2 lines
Best Regards
Masahiro Yamada